From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4307DC433EF for ; Wed, 2 Mar 2022 17:28:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D20C08D0006; Wed, 2 Mar 2022 12:28:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0088D0001; Wed, 2 Mar 2022 12:28:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B99438D0006; Wed, 2 Mar 2022 12:28:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id AB76C8D0001 for ; Wed, 2 Mar 2022 12:28:49 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 86FE1121F86 for ; Wed, 2 Mar 2022 17:28:49 +0000 (UTC) X-FDA: 79200131178.03.40F81FC Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf19.hostedemail.com (Postfix) with ESMTP id 0A70F1A000F for ; Wed, 2 Mar 2022 17:28:48 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id w1so2294498qtj.2 for ; Wed, 02 Mar 2022 09:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Iq0rZlsMU4r+zqOLQvMXoooXg8dosVQwWXeWcKc1Jjg=; b=hoUQHly0CK3GLw+r/sMonCNWnxuMzGVPhFsU6yrHWtEWVgoazyjdv4SaS14u8PMoAQ rNwr1JjTyS2/bUeKrZDCc8NkzTXgTP45jl9cveoz0Qcvl0vJD0GRnd87ZsbGoWUY22Sz 2SJH8pyO5B0Zz005C8Vm9BFFZdI8SMHb92OzII1NuTAH1Jesss3D9yFaAXY8uNU+7xi1 wPBVrebBeHAvpmo2F4hNGXCVRQgiOwsy+/ioQJfV0mCl+m6IiS6x6eN7J4VGaxtG0bGN ivW9Gpv5nZvohIKB152aXuW9IUW2ouqvA6/B6+ql+VDmipzDWJRSI2s4GnSGgIhz2u85 vqDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Iq0rZlsMU4r+zqOLQvMXoooXg8dosVQwWXeWcKc1Jjg=; b=5Eukeq2kj8GpBXIFMECMWjGoj8BrYWDqf2LNxwkG/V8zskaJ+AcS2TM6qhyEWkoLq3 H0XUNwB4ahLnMAtMY6uIq3FaTLi6wHIRNmU/BSEsiollibvI+VHWBw+HOuXev1e22AtZ p+Yy5rGuviNrV+VzIzuPo1RQCS5vVgTRO6LOvbdjm91mtNSHSK35LHOaQ7MtG7rcUOAG zuHtPECI1YAjYnEZcWTItgsZ/0UQpQnZvaOWPcRloCV/xanU6oBLDPcoJdl3gDMWgMC/ +GpP4rC9V/oXbD025R7vI2a132TWxW1qDrEaAo18jzcbnSMjpRK4WBsHngv6weMYIBQa p3kQ== X-Gm-Message-State: AOAM5304lAnM62cKC4YjBEo/RHbujl4fRlQ3HW9vLFZkoOiQwq26NSAU 5O2CvM/uFsJAdS8VQAUVcTily/Qs07JgMFR5QLvgyA== X-Google-Smtp-Source: ABdhPJylumbcWJCUUDvYXIdYlmEEQwx6IqD0uwFghbV1tb9lP1Bap+OfOpGLLijwcndczQQOsOQ4188is7/hBcZbj/o= X-Received: by 2002:ac8:5e4b:0:b0:2dd:dc99:d22b with SMTP id i11-20020ac85e4b000000b002dddc99d22bmr24536834qtx.165.1646242128126; Wed, 02 Mar 2022 09:28:48 -0800 (PST) MIME-Version: 1.0 References: <8682c4558e533cd0f99bdb964ce2fe741f2a9212.1646237226.git.andreyknvl@google.com> In-Reply-To: <8682c4558e533cd0f99bdb964ce2fe741f2a9212.1646237226.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 2 Mar 2022 18:28:12 +0100 Message-ID: Subject: Re: [PATCH mm 02/22] kasan: more line breaks in reports To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: multipart/alternative; boundary="00000000000043522105d93f9de0" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0A70F1A000F X-Stat-Signature: 4837e841xi6pa8yp88k8zatoh4z6rhxh Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=hoUQHly0; spf=pass (imf19.hostedemail.com: domain of glider@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1646242128-81444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.301071, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --00000000000043522105d93f9de0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 2, 2022 at 5:36 PM wrote: > From: Andrey Konovalov > > Add a line break after each part that describes the buggy address. > Improves readability of reports. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > --- > mm/kasan/report.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 607a8c2e4674..ded648c0a0e4 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -250,11 +250,13 @@ static void print_address_description(void *addr, u= 8 > tag) > void *object =3D nearest_obj(cache, slab, addr); > > describe_object(cache, object, addr, tag); > + pr_err("\n"); > } > > if (kernel_or_module_addr(addr) && !init_task_stack_addr(addr)) { > pr_err("The buggy address belongs to the variable:\n"); > pr_err(" %pS\n", addr); > + pr_err("\n"); > } > > if (is_vmalloc_addr(addr)) { > @@ -265,6 +267,7 @@ static void print_address_description(void *addr, u8 > tag) > " [%px, %px) created by:\n" > " %pS\n", > va->addr, va->addr + va->size, va->caller)= ; > + pr_err("\n"); > > page =3D vmalloc_to_page(page); > } > @@ -273,9 +276,11 @@ static void print_address_description(void *addr, u8 > tag) > if (page) { > pr_err("The buggy address belongs to the physical > page:\n"); > dump_page(page, "kasan: bad access detected"); > + pr_err("\n"); > } > > kasan_print_address_stack_frame(addr); > + pr_err("\n"); > } > > static bool meta_row_is_guilty(const void *row, const void *addr) > @@ -382,7 +387,6 @@ void kasan_report_invalid_free(void *object, unsigned > long ip) > kasan_print_tags(tag, object); > pr_err("\n"); > print_address_description(object, tag); > - pr_err("\n"); > print_memory_metadata(object); > end_report(&flags, (unsigned long)object); > } > @@ -443,7 +447,6 @@ static void __kasan_report(unsigned long addr, size_t > size, bool is_write, > > if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, > get_tag(tagged_addr)); > - pr_err("\n"); > print_memory_metadata(info.first_bad_addr); > } else { > dump_stack_lvl(KERN_ERR); > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups > "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/kasan-dev/8682c4558e533cd0f99bdb964ce2f= e741f2a9212.1646237226.git.andreyknvl%40google.com > . > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhalt= en haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bit= te wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --00000000000043522105d93f9de0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 2, 2022 at 5:36 PM <andrey.konovalov@linux.dev&= gt; wrote:
From:= Andrey Konovalov <andreyknvl@google.com>

Add a line break after each part that describes the buggy address.
Improves readability of reports.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Revi= ewed-by: Alexander Potapenko <glide= r@google.com>=C2=A0
---
=C2=A0mm/kasan/report.c | 7 +++++--
=C2=A01 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 607a8c2e4674..ded648c0a0e4 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -250,11 +250,13 @@ static void print_address_description(void *addr, u8 = tag)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 void *object =3D ne= arest_obj(cache, slab, addr);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 describe_object(cac= he, object, addr, tag);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n&quo= t;);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (kernel_or_module_addr(addr) && !ini= t_task_stack_addr(addr)) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("The bu= ggy address belongs to the variable:\n");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err(" %pS\n= ", addr);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n&quo= t;);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (is_vmalloc_addr(addr)) {
@@ -265,6 +267,7 @@ static void print_address_description(void *addr, u8 ta= g)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0" [%px, %px) created by:\n"=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0" %pS\n",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0va->addr, va->addr + va->siz= e, va->caller);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0pr_err("\n");

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 page =3D vmalloc_to_page(page);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
@@ -273,9 +276,11 @@ static void print_address_description(void *addr, u8 t= ag)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (page) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("The bu= ggy address belongs to the physical page:\n");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dump_page(page, &qu= ot;kasan: bad access detected");
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n&quo= t;);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }

=C2=A0 =C2=A0 =C2=A0 =C2=A0 kasan_print_address_stack_frame(addr);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n");
=C2=A0}

=C2=A0static bool meta_row_is_guilty(const void *row, const void *addr)
@@ -382,7 +387,6 @@ void kasan_report_invalid_free(void *object, unsigned l= ong ip)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 kasan_print_tags(tag, object);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("\n");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 print_address_description(object, tag);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n");
=C2=A0 =C2=A0 =C2=A0 =C2=A0 print_memory_metadata(object);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 end_report(&flags, (unsigned long)object);<= br> =C2=A0}
@@ -443,7 +447,6 @@ static void __kasan_report(unsigned long addr, size_t s= ize, bool is_write,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (addr_has_metadata(untagged_addr)) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 print_address_descr= iption(untagged_addr, get_tag(tagged_addr));
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n&quo= t;);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 print_memory_metada= ta(info.first_bad_addr);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 } else {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 dump_stack_lvl(KERN= _ERR);
--
2.25.1

--
You received this message because you are subscribed to the Google Groups &= quot;kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to kasan-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://gro= ups.google.com/d/msgid/kasan-dev/8682c4558e533cd0f99bdb964ce2fe741f2a9212.1= 646237226.git.andreyknvl%40google.com.


--
Alexander Potapenko
Software= Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636= M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebasti= an
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellsch= aft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4ls= chlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jeman= d anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und l= assen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet= wurde.

=C2=A0 =C2=A0 =C2=A0

This e-mail is confidential. If= you received this communication by mistake, please don't forward it to= anyone else, please erase all copies and attachments, and please let me kn= ow that it has gone to the wrong person.
--00000000000043522105d93f9de0--