From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0053C38142 for ; Tue, 31 Jan 2023 10:21:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BBB16B0074; Tue, 31 Jan 2023 05:21:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26BD86B0075; Tue, 31 Jan 2023 05:21:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133C86B0078; Tue, 31 Jan 2023 05:21:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 01CA06B0074 for ; Tue, 31 Jan 2023 05:21:11 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C8ADE801E6 for ; Tue, 31 Jan 2023 10:21:11 +0000 (UTC) X-FDA: 80414701542.20.D8570F3 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 1988280010 for ; Tue, 31 Jan 2023 10:21:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kPzlMIjk; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675160468; a=rsa-sha256; cv=none; b=K90wFWY2YxvDM8OzJYXEkQZ+OAN/qV8LuTp313r6uIRuTye6ByxgI/k0KLVBdND9yxm2Ay CSVM1qV87/1/TdpteOOfQHz8WRTpE8G7MEj2iDqkfTirOQVXavUK9coyUocG34CwlupYpe +tcMSvA+DFl+99SZ2pNY875MLZdYaRg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=kPzlMIjk; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675160468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JccB23TS0/KWTmAaso9Rq5suOvDS6HlaZd7+/LF1Vkw=; b=iLNK6eEv7BuGbe4GDS37zzrGikfZSGXpugyvYFOyAP/O6qcRb+/EJJxe0t6BRFrO7k/Yoq /3C4QORCPchnCNFA1jjNCLTXuH/9GYQSYlARz/IYjFKnC2PUMsnbmwGoEF+49INdLrIkP6 Cm9ehqhdfJaVaMOcq7JHXDf7l49APBo= Received: by mail-vk1-f173.google.com with SMTP id b81so7146606vkf.1 for ; Tue, 31 Jan 2023 02:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JccB23TS0/KWTmAaso9Rq5suOvDS6HlaZd7+/LF1Vkw=; b=kPzlMIjk1hn148XGLPYyLoo/c33fmO3machzfyEMLLC6AYuTlF/3rHyJqsHLaew3RC rKOZ7En6cxhBo1ETfCZ2h1PDtxGGnUYUGS4Bp8VKSqms4N83srTa0eq+S0uoIl5x4Aiq Idq4hcPXS+LD9AeAtOx2EWuWzBDeQYicw1d51crVIBtnAbtt3d9JuFud2MLjyUGgiI7O Tgvsv/j3AeNwC0YOvKrBLaiDE+FUTv3+zC1fDKx2KiXFWe2zZz3aREIoLhmpNNIx67zN tgacgWgHUwMVTIk+0p9mp+A6L0LNWoHSLepZyzQP56pdjgnpR29YLDJUFLlsWE5F3g8o RAJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JccB23TS0/KWTmAaso9Rq5suOvDS6HlaZd7+/LF1Vkw=; b=bC3DRaCco8dnuPgM2hVbkiDJCniNUcXysjg1QlUS5kgFt4LEd3tJSuHvjymX9L9mV6 6XEsdg34avDBvvhkw7HVV6z5CmtRmfc/rdfGg3KNn0gHYBnwKuRXz+W6nqjsQafbjcjX f9FBW13r+CE9EiFJeCJ0lA1eXZHKty/sUaKQeCSODcAIGbXXBaYEDbvviR84MHZxAuQz n5LwD1R50048PK/0PIE/4oqp185efynCPojmqDLEHsSEzNQLKx6HBksrMRGkoZHfDmKm WVjDiYG2ytQuFKpqG9Cd8bnwFq5FAT1yAsM4p2qFZ3AQg8OtSZrsCntQ4ojjNdzBxy4Z 7d+w== X-Gm-Message-State: AO0yUKVc6sEQ8VTEUasvNxaf7XU13wNWYdKYZSA7tr7gocif1C+ELHFT DYmN6TMuSmR+Fx6UZlwWTFJUtsofoc+h/9LK32xdx8exWJmvy0t3 X-Google-Smtp-Source: AK7set/dLpJNgzL9xXAJBfuyOSZj0MVUxK8kDY+ZIgX2NTS+3vDslis5aE4+oLKIsG3RRa0YnZr2ZJcm86bKrsu0guo= X-Received: by 2002:a05:6122:2498:b0:3e8:a035:4860 with SMTP id by24-20020a056122249800b003e8a0354860mr2503258vkb.7.1675160467019; Tue, 31 Jan 2023 02:21:07 -0800 (PST) MIME-Version: 1.0 References: <632393332c364171c69b7c054b3b2233acbfa996.1675111415.git.andreyknvl@google.com> In-Reply-To: <632393332c364171c69b7c054b3b2233acbfa996.1675111415.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 31 Jan 2023 11:20:30 +0100 Message-ID: Subject: Re: [PATCH 02/18] lib/stackdepot: put functions in logical order To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 1988280010 X-Rspamd-Server: rspam01 X-Stat-Signature: zt1f9eh1nhf3or8cfrrm1q8zo1bgnpe1 X-HE-Tag: 1675160467-477455 X-HE-Meta: U2FsdGVkX1+Um0Zq8450LEbyXRnSycS046lvB6hIowk0qVgai8IkmThovYJ5xqidVtWmIn/ckrzgOZsFIatOfI60VIEnosrA9GbSnEoVOKlmAkkj4vqjoVp/Tk5CiTMmkH3XCQ6IghBpS/blIi0HpfD36QZkr772zlH1CVZ1JHUPSnljsC+wKCGeJsa0Ya9aqsZT3uN1zCgu80guCU3s+eQ05yF+5N7tMTZx9EuG4a0bGmmS0EeKAuHwAjNHPxv5L6fZehN9CbqLLYqw37dLb1+3P4/mm8C8fKSrt6HAYcluOfMaVDeppQHUaZhLrshQO1/dhjHRWKjUjXcpIkzO3o84eZKP0FKOtEDDCvZjrKBZ6Zm8OSapBO1JClpKYEm8nifrr1mP3NCHMd8X7RNl7QhcApQ5uvK0zd5JpYcZ32ciXM7pnnYjMQPuJPhrusX3RXCesLGoVvuV1Hdvsj/dGaSCxh4QCOhU8j7TUQZwwAGII5jmzeb+js5ISSfqip3Aqjmbg3iPZu5FblJi4S+46xtgJS1cGx6+1BHN/Gcm1DHjn6St6sBtJsiuVZQziP6BIyVkNVhTMrR2u21V4zM37mWuB4gCDE5T8lf+7Px8cXpfUyLdo7+uccYu4OyvJuv+ygtOPLA/4fvyv0SAiSKfJTK4BZSrS5KP+YthJsz2R6XYhgRbLgN09O1aQl43dYhUG6vdG0UcDZZFjItsTc784N5YTC1yRzI93MrCHGpmNxUa/5viSpsgRxbFTIbHr5ELMA//LVNFj6/pD92eo9A+jYjULN/g0NPC5oaGXr5/zligwafRpvx80uzrBkXhkSvDFHWyGqqqYSjWcbgbwBwNKVRrsq6M+Jnot1i6dz/S0cDAdyAXYBPlG7mogLtVQcbCJWov8/sL+Y9r9ExCvXUjxgJltU4+JnpcLGpKyTgiWjMJ3K0+Usjo+bJbDe7pBlgQj7uvotUBLQHjGL1Yx0I jK5ls4qi SL5OV6dS+tNnw43eeZRkPbpVpU+EWAtkEK7rr8S6d2gWxhdyHLRn6KdAhM4gh4vwgPggWbZFAxd2NW3yIuNqBR7+YB4XXmLWQQwWzmE2EZKFquVzVzDA/uHixB8l2xVqRp2I0yRq2SQWR9MbOmaJSj0WScYx+6e6YUR68yqN7UreN1KNRpTYGQOeCbgG2E5dXeVa/CQE/j6xp6ODHeetNf/ge11OeF4G/SzAxv6Zj0eObWt9nsCQpbWTkZKJLi4w0J+rg5GiNy7TBQFX2fE2tBjoHoY1FoY9vQFS2zfIvU2B0or5Re+G5F4nbmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 9:49 PM wrote: > > From: Andrey Konovalov > > Put stack depot functions' declarations and definitions in a more logical > order: > > 1. Functions that save stack traces into stack depot. > 2. Functions that fetch and print stack traces. > 3. stack_depot_get_extra_bits that operates on stack depot handles > and does not interact with the stack depot storage. > > No functional changes. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko