From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45015C433F5 for ; Tue, 14 Sep 2021 12:13:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0B3061155 for ; Tue, 14 Sep 2021 12:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0B3061155 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 883D66B006C; Tue, 14 Sep 2021 08:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83350940008; Tue, 14 Sep 2021 08:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3B3940007; Tue, 14 Sep 2021 08:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 5E72E6B006C for ; Tue, 14 Sep 2021 08:13:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1008918026A19 for ; Tue, 14 Sep 2021 12:13:21 +0000 (UTC) X-FDA: 78586069002.06.7181D14 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf11.hostedemail.com (Postfix) with ESMTP id CE3B2F0000B5 for ; Tue, 14 Sep 2021 12:13:20 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id p4so14432367qki.3 for ; Tue, 14 Sep 2021 05:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pJ0yW4/1Jn6ZEeGlxOvvBqEA1VuZRtIwgqtBes2tjIY=; b=ZT9oblhQOkOXScfXKv8+xOqRaGE0WgSKWm93+I3oT8FQcNL6gNEpMSrGUSsbksVmfb y3GdJxN/nkFI6szxiiq0GYBxjof1k3RzFbKXcRnSuWr4rVjPew9FTFreNBDbfz40ABvo YanTFu3rpFNJteFkq1DEjpegEKUARWnyRjEIzDqMN7dP42I5ZDNIpsB9bI+TihY+0XUL bv4DOR9LPuDOLM35CzaDQdyEX5X0wD3aSkGeKI7PsqOJ8PCeYKPsRhATLiU1PE4trcAM Ds5AcFT2m80OecQVCK6+2q3MWUedgmTfqjtPs1EYRflv/K24dgoNYftDbBq4MCldfxXH qnKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pJ0yW4/1Jn6ZEeGlxOvvBqEA1VuZRtIwgqtBes2tjIY=; b=4BZQ/vnHFcf2tJCmAMS3/C+tF1BGu119CG1cXZGxOswEpCd1l7Jjv2YP0C0PYoDBVk WyX1aYDN3eX5EcqKR4gAgzsSLU8RoZpXlaGWOIbqwYHdDSFnbGDLMhZ3HWOGx1suJfvR LSVhXd/AtVc7l8OeC6bIQ+8QeIBCHaLaK+qeIiJ7M4j7SPzKEb6IvOUJ5cDpoyFg+OM7 LVkhEpYsDt/R8Qb+IBCQZbGqx+RlG1PwVDFIs/dZM9s/w1ekHni3Nt8pwSYmg2IALAmH +wZ1EFCFTpYNo5bBWV4SOztv6SXC2fF8nQ54M8OugsTFmUhILaL+9gqM4LZjTrPuyQZx bDrA== X-Gm-Message-State: AOAM531u3h+/aS/KpeD0SV6I8Q/q4IDsLscHUHGLJ8CY1BZqlzetVBH5 8+RC3Ith/nOCQ6PilT6n9160uW5gM0CG8DMxzeiIFA== X-Google-Smtp-Source: ABdhPJwLVdTNZsVxxo92ilXBQEiuYtzkaFYtDjigb7vv+T3hwYVL5wZO3l5lC4q8vtXtFjs2gqHYUYVCTZ6pi+MGjVQ= X-Received: by 2002:a05:620a:191d:: with SMTP id bj29mr4500655qkb.362.1631621599977; Tue, 14 Sep 2021 05:13:19 -0700 (PDT) MIME-Version: 1.0 References: <20210907141307.1437816-1-elver@google.com> <20210907141307.1437816-3-elver@google.com> In-Reply-To: <20210907141307.1437816-3-elver@google.com> From: Alexander Potapenko Date: Tue, 14 Sep 2021 14:12:43 +0200 Message-ID: Subject: Re: [PATCH 2/6] lib/stackdepot: remove unused function argument To: Marco Elver Cc: Andrew Morton , Shuah Khan , Tejun Heo , Lai Jiangshan , Andrey Konovalov , Walter Wu , Andrey Ryabinin , Dmitry Vyukov , Vijayanand Jitta , Vinayak Menon , "Gustavo A. R. Silva" , kasan-dev , LKML , Linux Memory Management List , Aleksandr Nogikh , Taras Madan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZT9oblhQ; spf=pass (imf11.hostedemail.com: domain of glider@google.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: he5q5xn4cdhb5zgb9sfk7jdwgad1fmgx X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CE3B2F0000B5 X-HE-Tag: 1631621600-300128 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 7, 2021 at 4:14 PM Marco Elver wrote: > > alloc_flags in depot_alloc_stack() is no longer used; remove it. > > Signed-off-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > lib/stackdepot.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > index 0a2e417f83cb..c80a9f734253 100644 > --- a/lib/stackdepot.c > +++ b/lib/stackdepot.c > @@ -102,8 +102,8 @@ static bool init_stack_slab(void **prealloc) > } > > /* Allocation of a new stack in raw storage */ > -static struct stack_record *depot_alloc_stack(unsigned long *entries, in= t size, > - u32 hash, void **prealloc, gfp_t alloc_flags) > +static struct stack_record * > +depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **pre= alloc) > { > struct stack_record *stack; > size_t required_size =3D struct_size(stack, entries, size); > @@ -309,9 +309,8 @@ depot_stack_handle_t stack_depot_save(unsigned long *= entries, > > found =3D find_stack(*bucket, entries, nr_entries, hash); > if (!found) { > - struct stack_record *new =3D > - depot_alloc_stack(entries, nr_entries, > - hash, &prealloc, alloc_flags); > + struct stack_record *new =3D depot_alloc_stack(entries, n= r_entries, hash, &prealloc); > + > if (new) { > new->next =3D *bucket; > /* > -- > 2.33.0.153.gba50c8fa24-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg