From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A42EC433F5 for ; Thu, 28 Apr 2022 16:42:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2582F8D000B; Thu, 28 Apr 2022 12:42:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E0C48D0005; Thu, 28 Apr 2022 12:42:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05C5E8D000B; Thu, 28 Apr 2022 12:42:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id E81278D0005 for ; Thu, 28 Apr 2022 12:42:53 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id AB35162424 for ; Thu, 28 Apr 2022 16:42:53 +0000 (UTC) X-FDA: 79406857026.03.AB57C3E Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 4F7E61C0070 for ; Thu, 28 Apr 2022 16:42:49 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id m128so10066958ybm.5 for ; Thu, 28 Apr 2022 09:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r56JqmyEKwLfjjTuw56FZ5cxoCmhZkz1FIGkAdMEzhg=; b=gmEWLK/G4g326vlQfUkD0s/whD9rJnz2/equnQIJF2nnqQbb7pM3Ed+1fibophD2N7 CIa1/jAvm7oxqS3hLTUpPUD84dJivbYpULK+unSOmhJB0bFDTKwLDO0h8/WXg9AnVau6 /eZZhSk1wL0rTdkQQdONX8rlY2390cpw5zfJe1m+vvD4CErK/cim9uNN2ixWR5kCXw98 sKyiLO6SNAeFdazNmNIccaHuwNOpcCDd1uDbTbIyuRtBb6eesZm85F1l8qARnu7FPXZ6 kyIRcsOWWwVkvKcKgb8XkWMuGKki4vACrXFntBmRLJ4xOvBarkPtDxwDSGM+RbyM+45n YxaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r56JqmyEKwLfjjTuw56FZ5cxoCmhZkz1FIGkAdMEzhg=; b=oYWHF6ScYwDRN64zg/ImNJneBy90W1tUGMH41yG/NX4vIzONCXi7QHEiq7AstBBNVJ Vzl7ZPz0Zl+9s4gX495PUpVUpiQuMWtrq7vdJeRyy2kj7T0IySDdMkoJUl0cMtmHN+st qiKjXsnlft4JIXJxT6OyMribm1ecZxk9HBbDLmhpVAeV1v8/MeWaN9mwik4QqvyW6prX tHI+0AL0KUlwlNEuT5beP7/iouVLFCsorkShT/Xa0Pt2Df5XdinUW22yC+Rof2YwRhXR 18EPegqZjpi3LxSScOIFBXFXn/nUtZqKzNLCkRxb08jJxZXIDLOzvQupEOcNJV6jJMOQ +Dxw== X-Gm-Message-State: AOAM533oS9bfmUCIWEDKxmGxJ0EC25x00nn5UN37UjxENQu50FPC9EPr f3zY3K7zbbmdrhNk/w2GNWPqYBetK90MBMakj01ahQ== X-Google-Smtp-Source: ABdhPJwULhotWKO+NXz+dcEVz2aj7n4dvaBRBZ72IUvS4DL/hWhIkaotQI0g/VvhyXUYmLNxVAYiXldqMl9RMubQXGY= X-Received: by 2002:a25:9bc5:0:b0:644:c1bc:1f12 with SMTP id w5-20020a259bc5000000b00644c1bc1f12mr30361921ybo.138.1651164172335; Thu, 28 Apr 2022 09:42:52 -0700 (PDT) MIME-Version: 1.0 References: <3167cbec7a82704c1ed2c6bfe85b77534a836fdc.1651162840.git.andreyknvl@google.com> In-Reply-To: <3167cbec7a82704c1ed2c6bfe85b77534a836fdc.1651162840.git.andreyknvl@google.com> From: Alexander Potapenko Date: Thu, 28 Apr 2022 18:42:16 +0200 Message-ID: Subject: Re: [PATCH 1/3] kasan: clean up comments in internal kasan.h To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="gmEWLK/G"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of glider@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=glider@google.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4F7E61C0070 X-Rspam-User: X-Stat-Signature: dgjbk9n11u6hq68zkxmbdjum85qqjpg5 X-HE-Tag: 1651164169-210364 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 28, 2022 at 6:21 PM wrote: > > From: Andrey Konovalov > > Clean up comments in mm/kasan/kasan.h: clarify, unify styles, fix > punctuation, etc. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko > > +/* alloca redzone size. Compiler's ABI, do not change. */ s/Compiler's/Compiler ? > #define KASAN_ALLOCA_REDZONE_SIZE 32 > > -/* > - * Stack frame marker (compiler ABI). > - */ > +/* Stack frame marker. Compiler's ABI, do not change. */ Ditto > > -/* The layout of struct dictated by compiler */ > +/* Do not change the struct layout: compiler's ABI. */ Ditto > -/* The layout of struct dictated by compiler */ > +/* Do not change the struct layout: compiler's ABI. */ Ditto > - unsigned long has_dynamic_init; /* This needed for C++ */ > + unsigned long has_dynamic_init; /* This needed for C++. */ "is needed"? > - * is accepted since SLAB redzones aren't enabled in production builds. > + * is accepted since slab redzones aren't enabled in production builds. s/accepted/acceptable ?