From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C799C433E0 for ; Mon, 18 Jan 2021 13:14:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E01F22B49 for ; Mon, 18 Jan 2021 13:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E01F22B49 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 787CB6B026E; Mon, 18 Jan 2021 08:14:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 710F76B026F; Mon, 18 Jan 2021 08:14:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D8A66B0270; Mon, 18 Jan 2021 08:14:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 41DB56B026E for ; Mon, 18 Jan 2021 08:14:29 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0AAB0180AD830 for ; Mon, 18 Jan 2021 13:14:29 +0000 (UTC) X-FDA: 77718939858.03.waves99_04160d427549 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id DAC0828A4EA for ; Mon, 18 Jan 2021 13:14:28 +0000 (UTC) X-HE-Tag: waves99_04160d427549 X-Filterd-Recvd-Size: 3621 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 Jan 2021 13:14:28 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id z6so4099766qtn.0 for ; Mon, 18 Jan 2021 05:14:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7A/Elja0tqTh5xl8zVGHbIgBSUloF7XCymm9bzQL4Zg=; b=G+02ve1Cp0Ve+zAIDgeCoRcOPI4rO9Xl9bLUnd9i0gsVR7HlMsCDZl5U8bMZ5iau69 hnFFJYdEUe2AsUjqN+w0g2dI9DUrxO6ki2rBh5ZP59EKBv5ZBkyLu8SShSMKVz4B2QqN wPz8j69raE5PeNWNJvHzhM5eGgevOlmBDGrVSMlTN1W4TKuSpzPqrL/EwfqJZADVdpcQ r+aUo3mRLFSUd9cSA4ktzCyEnVqpEEsJxnMZMrCkKw3qdyCdDi+KM1d3UVmMqzi3MBb2 zSF5miT16KEWh2i+48dEusQINaVwQ61fgVoUocCuHlViBZ0xzpJKACaGSl8RIEF5tEQv Q0QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7A/Elja0tqTh5xl8zVGHbIgBSUloF7XCymm9bzQL4Zg=; b=Om1IZlVpvypXBAffOCTHEz1yy+zf7lvJ4CKAI3kVwX4ShZ5XLD9fLWfbzrkaDFT9Af nLoUrL2CPvKgN/FWmMTuH+9Go3aLAHmvhZVxE20o86w0svx2kWVGnD76uZsPpharnMvM I/or6nyVnLcZLGazlHhfnmUWlAw6dpByXCVnwfUQBqtkGckmU9oYAdI9FVHLnXXZMcQb CkvbLQipG9PkJUxu9+PUH00ru8lmIuSUfAj2YktBxONzFMZ4HrdNEagVbMfO/x2ztoAS jCm016569wOa8cP5CQkEUqZU+U40AwPINhuqwwp9xQVVi7i5TxOkmq3N9EP6sPtIK/HT e28w== X-Gm-Message-State: AOAM532Du68SRUHPp2Q8JzyoZ4kgs9paMRV7hEHIoE1BXtgAONAhXx1X dl68kjzU0Kymk5uiZFMLwN+OA4PhhGshHjuzgj0Qow== X-Google-Smtp-Source: ABdhPJzLDo/2mteZepXTtQOjVhCHKhKZV79RV2P6nZNVUem4zZDXXzbBaPATBdtGn6W0mR/vmKjpj0htzgHQRqeYbUo= X-Received: by 2002:ac8:7512:: with SMTP id u18mr23187629qtq.300.1610975667584; Mon, 18 Jan 2021 05:14:27 -0800 (PST) MIME-Version: 1.0 References: <20210115130336.2520663-1-glider@google.com> <20210115130336.2520663-3-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Mon, 18 Jan 2021 14:14:16 +0100 Message-ID: Subject: Re: [PATCH v2 2/5] lib: add error_report_notify to collect debugging tools' reports To: Petr Mladek Cc: LKML , Andrew Morton , Andrey Konovalov , Dmitriy Vyukov , Ingo Molnar , Marco Elver , Steven Rostedt , Sergey Senozhatsky , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > + > > > + /* Pairs with acquire in last_report_show(). */ > > > + atomic_inc_return_release(&num_reports); > > > + schedule_delayed_work(&reporting_done, 0); > > > > Why delayed work when it gets queued immediately? > > Because error reports may be sent from a place where waiting is > forbidden (in the case of KFENCE that is the page fault handler). > A delayed work ensures the notification occurs in a wait-safe context. > Agreed, there's actually no point in calling schedule_delayed_work() instead of schedule_work() here.