From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BBDC636CC for ; Mon, 13 Feb 2023 13:28:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17E806B0075; Mon, 13 Feb 2023 08:28:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1082F6B0078; Mon, 13 Feb 2023 08:28:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F13846B007B; Mon, 13 Feb 2023 08:28:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E1FC06B0075 for ; Mon, 13 Feb 2023 08:28:04 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 985AE1407B2 for ; Mon, 13 Feb 2023 13:28:04 +0000 (UTC) X-FDA: 80462346888.06.680BA01 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf14.hostedemail.com (Postfix) with ESMTP id C3BF9100002 for ; Mon, 13 Feb 2023 13:28:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E1gJIgM6; spf=pass (imf14.hostedemail.com: domain of glider@google.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676294882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Gb42UgzE9IFoAhtdlpi/Pyg3SPeN3v0rXrGEsBRa7g=; b=gDA2R/0hZQivdpn5OhvPMP5kfou2X0Nnc+IQPKJUPqT2gNbAzipwhiVlea+jmIbVaMeYno 4952wI9pSc9jY3NOTW8b3CMd/2WUpTBneapHb062D/QTf6pz4oE5//TWc2OByI8tX6ivAU T355oR6I3O58s64c67lKIMvJ9qbL4oE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E1gJIgM6; spf=pass (imf14.hostedemail.com: domain of glider@google.com designates 209.85.166.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676294882; a=rsa-sha256; cv=none; b=VBwnjg9pWbLRfGC3/n9vJJpKxa03MzG8t+CaYoWEsAJ7KfPqXN7yEUf/aIw7G5va8s+jHe bAPnXkuROjXBjhBib30C2CJ+NCkQfY0wAjYUBbAsmp8e3GAbJv21/a8uzIfIbhQeWsptXF vfH8it2OrQHb9unZ/z4uZfrJwItBwWo= Received: by mail-io1-f50.google.com with SMTP id l128so4452081iof.2 for ; Mon, 13 Feb 2023 05:28:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8Gb42UgzE9IFoAhtdlpi/Pyg3SPeN3v0rXrGEsBRa7g=; b=E1gJIgM6i6uNiQH0mH5azStrG+CTBCFXiugvdVofaImLpgmmoQl25g07MB++1ebtKA O9rtt8vd8IgANh3/vKCJm/LuIZPCRs47liqNZBTb4EifwhmgLDz/TRm0e1O0ffP+0EQy H5O9Sz8Z832xb9P0EM8cVDKqQOvDGz7eIuUXnsa6bcb6QGZ017P+l1Cmh+KD3aBIY8hW KmLAJ+grPxdOYDye0pwQ3yeJkfwgD+wGMMDm/b49EGObdvOruBjs9KfuxJ43fo0A51fk QjMTPftW/hpR8L2j+oaMwetoZmKtqdWAj5LRBSybiH0p7iNWpUblEHod+C53kE+mQWHd WTIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Gb42UgzE9IFoAhtdlpi/Pyg3SPeN3v0rXrGEsBRa7g=; b=C4xiXX2qwK2+PbztGtbHLB4BVgGhxpom8q9ywK17CK2HMddsEfrQv0HcoJsi9Xh8FP KHQP1e6faq/pFtWMjabIPgfqYdxxsXZWekV5nWVHVBgfZLRJJiR4eHqtCx22NnJ7uS5O 1ziznPNTB9opFDksWPIE7q7i+IYpWau1OjtYECcoBRpBrjxBKaqYnFIyiIGe1lEsEJLB lLhNd+nlaFu16uNJhHHjz87j+nqAVI779TJiw3s81Q3JjNKG3gd41zR0iNsNkgHKKZmC 6zt4GyJpbPBk/N9O5pKShWkWhk/5asBjtZjiV41OE0WfM/tlxwwzu6+XQosKNDb/fUgP 3x3g== X-Gm-Message-State: AO0yUKUtOxPK+mosh5XuEStFzIMW1LgxULE0c5Cud9k90KF+hk9drnZ/ SMbhrb/C/kMrAeQcm8i5riuygfrzKWVKsG5Y22bnMQ== X-Google-Smtp-Source: AK7set/caV2aIlg9ftVuB/YHkIPLKFmE8k3eaOUWPmmRwFcqA2fyNdrM7os82ZP6zYAgzpZuJfPAc02pjSIi4nnjG9M= X-Received: by 2002:a02:a794:0:b0:3ad:3cae:6378 with SMTP id e20-20020a02a794000000b003ad3cae6378mr12315762jaj.16.1676294881849; Mon, 13 Feb 2023 05:28:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Mon, 13 Feb 2023 14:27:22 +0100 Message-ID: Subject: Re: [PATCH v2 18/18] lib/stackdepot: move documentation comments to stackdepot.h To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C3BF9100002 X-Stat-Signature: j71dgmndzj66qsm8umzjwitc5f5pimop X-Rspam-User: X-HE-Tag: 1676294882-752976 X-HE-Meta: U2FsdGVkX19CL7t1s+yN6NvsTgVZgVJ8hAxYuqOj70VWFZ9IGOKeh3V2tGWWt/3pm/RH894gvDxiXiuHY23KN6MHvrlqZF/z5gKi6AuxveLPq9LwxpFlG2OBpyGsdK8grfki96HgVaHtb5jslirkmjCVEz6GkN5MIl3sygIr77BPC1rzMGPDPtuM/NEneyK5RBig1JqQDdiLQF+xipFmPy3wuvjPHnAXwbXeqLf+kqmu7zPptPVM40IUrcEt66TbvRN1tQj5Mk7F0nwM92dOvqovOiuJj8TyNOHhUj/ROd5/kCpp2qshQo1USOoFgA8Y94ZmuT815LEbxPpBGdhKzNWHA4UiUVDVBXy3Fs3V+ppfrQ7ob3HgUfXEaXxvbgX9Po43qCFIp70g6G/qQ8nChPm+rJ0Qrej1RgGGcqQcVLMXKZm3pVIjyDCpaWVDo661X/ILNlXdiWSlLybTQLEPOJdRziJTMQoaYGRojjTllfGgjAwlQ7pkfxgLqTBvHGVtT+BxnQAoKlF08piiXmrMhF7jd3t608plsAyLSMyV6VuXnSaJfm0BzWXdX3+rbdHP2d+VB/g0FkFchA7BRslFkZJbxAPJHFvwMUd39lFkHieCbvWp9Ro+uXxsEuUc8n2fZXife8FrQ+DDawIb9qA7AqMJKSNxrI6T1/43W2PkSEeQEvu73ShVevbKQpt6kyYgyEQbpxx8IRozPj7MHDr9zi027I27zyrFgSqonvbHNAnJOmYDQVLbagyb5i0LundeROI/AgW08Gr4w14lpsP5DYwdyOdqfQOtMyXTIry7aNW05eMCINAh5nG1x73mmTanAn2UrexPwNkmoW01eNwCwVlWNxGIWzhmkDPCelHTPK0IGjTVWODqEZ6pB13w2bpxrDdrs4oXgHEPmsWsjKjDPmHwnByp1jY/kSsZaQ2NvA3H7BmfTLuFpeZ2N093y1PHpmbmO+2yK3mrgAmn9iM MBmMW7TN r2otj0/xUBYF+LTwRDxLbbyutfCwe8IXeed4XOLd4/yh2LE2V/zl9T3l2Yc5zPMdYs5N1cNpWApxajpEZt6hX3I9BDlj9/HA9aW2IVRsel/+MkoX3p1wDgP1bsJcuyL+dqJqC4FAK2V6+wbw+fCW9KyMMFIhpRwXPh7T5HgH01WG8AUhVxXPFgwFtKsSeD84DwRlImFPNSpZaOgE90AUvAinetBjLwL0wzUDxTexWyBM8IZmxlH4fmI93daODqX95vHwAuKnIQsWEXsNhlLOPIdymPSVcVmieKD2Az48EC90/ees= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001601, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 10:19 PM wrote: > > From: Andrey Konovalov > > Move all interface- and usage-related documentation comments to > include/linux/stackdepot.h. > > It makes sense to have them in the header where they are available to > the interface users. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko > + * For example, KASAN needs to save allocation and free stack traces for each > + * object. Storing two stack traces per object requires a lot of memory (e.g. > + * SLUB_DEBUG needs 256 bytes per object for that). Since allocation and free > + * stack traces often repeat, using stack depot allows to save about 100x space. > + * > + * Stack traces are never removed from stack depot. ... from the stack depot?