From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D58C0015E for ; Tue, 25 Jul 2023 16:22:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB0596B0071; Tue, 25 Jul 2023 12:22:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5F6E8D0001; Tue, 25 Jul 2023 12:22:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C27886B0075; Tue, 25 Jul 2023 12:22:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3EBA6B0071 for ; Tue, 25 Jul 2023 12:22:27 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 694C8140DF3 for ; Tue, 25 Jul 2023 16:22:27 +0000 (UTC) X-FDA: 81050651934.09.FEB6564 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 6AC5C180024 for ; Tue, 25 Jul 2023 16:22:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="ZEIR/WIc"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690302144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H9vvN3sNcffcksfgnufYY11b2qKQzqGSaRZnWO9AEUo=; b=sCOmIfx10vCtlvN5axtG+1tGG1OoNrX++QcHVGabSTCFIL6jchie4Bax3zF0+CXsnHnPbh xBk0Pb+M+F05YQg4QyDdCx7TLWu0WzVbV9p04s/5QiwUpUflLQCeevhFKX5OzYhhpIAxIc g9mGECL2bkrG92QFW3ZBW5gyvWSFYYs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="ZEIR/WIc"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690302144; a=rsa-sha256; cv=none; b=1k91AvcI0V8O7TyvuDUJ5pc9tfdR5XsIkTx1VjO++ZKT+drlXPxDy61JB1gWdRh9Arb19+ /CXnFwVGYcnfLNTcFZH9nyACX9mUGdtr/rfgxC1WCY1iE43PLTZw6yJ9xGzBjbUxuMJamU mcBnZqfhP/mjxmtcjOhl5vlvLm66bRU= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-785ccf19489so289652139f.3 for ; Tue, 25 Jul 2023 09:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690302143; x=1690906943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H9vvN3sNcffcksfgnufYY11b2qKQzqGSaRZnWO9AEUo=; b=ZEIR/WIc25/oaU7kag7hxkAVxhfjQTR3j1xC1e55yhYr1dHJ09Vl6F4tUqHUFGk8eJ iuebUMxTm7QJV/61fr1qqpU94SFB/cWp/I52sc79Dj71CA4sQ4BBOCPJ0sMCGnutQM++ mxOSGz7ppCE3N4FmasztSPRgKw9gxxI1zxDmbZvjMx/sRdmIsY8yAk+cfpboyMUSC3jy TDP+aaFv9jBYWIW/6E8DT0ado6XM2tzfR+uCbXWaaxWx4ooV3ufvTHyvZq2khVSR8sjV 2vmme6ySIeBQP9C5ewf6fIuXBJ1LMazn4i5QTrwka75LQHcb5UHSv0BYuuaAc3ptUzU1 joNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690302143; x=1690906943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H9vvN3sNcffcksfgnufYY11b2qKQzqGSaRZnWO9AEUo=; b=ASvgmJCJ4rj8vZqtkEc9jy/t/6/R0GOWwf5cLhF2usA3dGpwRH28neOSPbvV0S2me6 3iKn3zE6mZCOP8uiHK25oUCwUSJ/0buaIrPBO+skkYUoEFdMX2VK/7cVVOHHwOoAl8O0 IIY/5tbtaEkaXIB1mD0slW5hhsxO8ovoTfhU7BiinEAJGJj4X//xTnme7k1QkKeZKKjy 1BNN4VXOE+0SfriqhEefUsyuEf2AII0FHPxFKSre/wHELV+X8mSkzD9QKi8n/GFUBxMz gCAJ+v82jVC/1eHB1IRccY7lIzS1S6ceUM4x+tw3HKhIncLl02XrZOgtWNKCDjYWr75S styw== X-Gm-Message-State: ABy/qLYuOioQ3eBgPM1WsMhhUWtvZW9yozAHt2nwH0+A9eBhzP3oUWtm 5z6YK26X7gzLA5ugPjq4EPwtb+lys4SZd3V097HRyw== X-Google-Smtp-Source: APBJJlFGMQ+w6qfSLijgyzVMzAvdy5ZIpWwmeF+6QaXpAsIZ1MQGEZORaOKrL5cffKbQ0cPmRK8xDUU9dKBZ4FMVlK8= X-Received: by 2002:a05:6602:2152:b0:783:39e9:e05c with SMTP id y18-20020a056602215200b0078339e9e05cmr3766651ioy.19.1690302143511; Tue, 25 Jul 2023 09:22:23 -0700 (PDT) MIME-Version: 1.0 References: <20230721160528.800311148@linuxfoundation.org> In-Reply-To: From: Alexander Potapenko Date: Tue, 25 Jul 2023 18:21:46 +0200 Message-ID: Subject: Re: [PATCH 6.4 000/292] 6.4.5-rc1 review To: Muchun Song Cc: Linus Torvalds , Marco Elver , Roman Gushchin , Andrew Morton , Linux-MM , Naresh Kamboju Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6AC5C180024 X-Stat-Signature: g7b41o8g1icfhpgz1mj3tbnhji6wetkw X-Rspam-User: X-HE-Tag: 1690302144-410527 X-HE-Meta: U2FsdGVkX19COc18dUQi/8IBl2YcQ2sfVUDlxLOZFiXgabr5/8G2RIuANhmPqP4GN1ZX06HJrknxbaj5yv3MgE3ydXX9wGnMoCyRKDA151ZsiadhSgwAEL3E4nzWFpwsdOsRY6Uiffqiq0VuCWnLSfo2OD99VPQUYWENGDx5wxJFPYD5EO3BONU5iLM2x7PLa4WYoMVHEgDPVXpp08lr9Mbk8DZggUXo83BDBPz592sDkjriq6pvZqnwycX1axdmQKkSkrkudr31DTA29qaNYdyT35ZaB3oXRbl/5TneUDq0e5D7fXqzE8okjQdkuY1BhLtx6ts7ytBICy8TGD0LE0gJY8RQpqyTGZYCwuP1vWWIJxIATYetwVZKNsdnPtEmo2W24MURPj9nJdfge/KigZd4xWQ2dZbFugsTWsCXRgTSkqx9siN/ogB+oQMLaYE63xw+e8n/HMnO3dML5dRxV+ZG7F0qRgSL7rJumy/APsgvWOKTfX5ytFt65x57gPt4kGu8LihfqiFXW9fDB8QDKm6pCABjTpIDcy6/aRuIeEwV4p3wIfhzry+qS8/lj7/QXonh4WHJBFJUN5OOLvJ+vstVPYSfUHGbRroPC2ZtTJdipJSNm/TggQk6xBR0To/1ML96rjy0zS8hBnqgprAcihCi7Jp41/vcPaq40EIBNYYRxG69wwmkdV9DmlF/tch6/43OgJwipkeeaxQP8lyTd738QzE9AoGDEZb+yFHf6bpSrUMqsaKmhROZzyKb5+GUw7WrBiDkE90QKpY6g+jJyUJADbEtYhXFzclC55wVMVZhPMIEkoJoPj2dhHzfehElu6oCXWArU2a6qVFpnHJSqwYVyQX+y0lN878oahq7JKlIJ2fmsu0ArSvvHYCbfrk4rbk1uv0Jr92Q7CUXl/Q5f2AX0cIB7OEXfwLn3LW45TaSHPs/shD4D0BuUMWQGVVTOlLVs5ImtMR5U/45R+K 99Gc1YlH MPOgAzHcTdCXQhpkweKwulY2+yMkqcId4udWfeZrXFGgGVPXflHDWzA98n5b6NrLsfBegYpog+zs/HFO+4sEKo408ynWPa/v/naxvbTtahQSkJ6A1Jh3WWp9ogH0eoYvIuV6/Xt6j5UaYAFxCyqLnscajEQqQ/EwuYjClYZWUePgeVx+Qj38SS389ZhU0YCInOh00/QAfAwTdFF/jW7bffbOstTgzCie9ajAeo4RpzhnDgxSY0QRHFPEjKb80U3ze5Q5TPpPC9cv9YmvLJMiBEXnOW58u4qS1fb8fCY51VJSIePjbtlRCQF/iB+Bnu+MI4uM6U6Nc96w44LHgqAtOJQEfP099Y72SYFfCMgBYatt476isBRGUN2WsjhlEA0hhcHd20b5P7Pxd+/lXMdijHXjT0o6PQmNESY5nDurMrDzIVtDHahhkQOPo3QJYRvq9ZPoKAE1lmaJiT1leYRRLAAW+OmYxKhbrp7KGcW6wDBA21R9kTykqI8uyqzBuvWtKUH0H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 3:39=E2=80=AFPM Naresh Kamboju wrote: > > On Tue, 25 Jul 2023 at 17:22, Alexander Potapenko wro= te: > > > > On Tue, Jul 25, 2023 at 11:59=E2=80=AFAM Alexander Potapenko wrote: > > > > > > On Mon, Jul 24, 2023 at 2:10=E2=80=AFPM Naresh Kamboju > > > wrote: > > > > > > > > On Mon, 24 Jul 2023 at 15:50, Alexander Potapenko wrote: > > > > > > > > > > On Sat, Jul 22, 2023 at 6:37=E2=80=AFPM Linus Torvalds > > > > > wrote: > > > > > > > > > > > > [ Removed the stable reviewers, bringing in the kfence people ] > > > > > > > > > > > > See > > > > > > > > > > > > https://lore.kernel.org/lkml/CA+G9fYvgy22wiY=3Dc3wLOrCM6o3363= 6abhtEynXhJkqxJh4ca0A@mail.gmail.com/ > > > > > > > > > > > > for the original report. The warning was introduced in 8f0b3649= 7303 > > > > > > ("mm: kfence: fix objcgs vector allocation"), and Google doesn'= t find > > > > > > any other cases of this. > > > > > > > > > > > > Anybody? > > > > > > > > > > > > Linus > > > > > > > > > > > Muchun, any chance you know under what circumstances a KFENCE object has its meta->objcg set to a non-NULL value? It seems to be a quite rare case, and I've only seen it in live radix_tree_node objects. Since the check here: https://elixir.bootlin.com/linux/latest/source/mm/kfence/core.c#L1097 ensures that this value is NULL when the object is freed, where is the code that is supposed to zero it? Could there be a race somewhere?