From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC21FC433E0 for ; Mon, 22 Feb 2021 07:45:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E17264DDA for ; Mon, 22 Feb 2021 07:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E17264DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 732CB6B006E; Mon, 22 Feb 2021 02:45:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E2E26B0070; Mon, 22 Feb 2021 02:45:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D12B6B0071; Mon, 22 Feb 2021 02:45:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id 43F196B006E for ; Mon, 22 Feb 2021 02:45:29 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 04B60180ACEEB for ; Mon, 22 Feb 2021 07:45:29 +0000 (UTC) X-FDA: 77845118778.22.10A4867 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 7B196200038E for ; Mon, 22 Feb 2021 07:45:29 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id a2so3066948qtw.12 for ; Sun, 21 Feb 2021 23:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5i8Tn1SlVaWO4Nif6cMWUKjsN8bsR6wBD1bT+KmM76w=; b=DuMSarBrnx4B6AqWFhGoDdpcXJDyC3kVP+sWmN+7pTZPoRcEVLcFm7fGPFUAk/UC2d MzfIdD4DWvD81phjIs1yir/GWAliE/qd1fVNVMbKCgak+d8dGJ3c4dN0h98rVIFl3GG1 1SqYBQ6TQ8bfy7C+enpkUCEhfUZI1TenhQOhuq7R2k23uaHDQS+tRyKyZ3sNH4lBK1DS Z27+PpqNytAVgxD7N1MWzamCyZPIRTJlLQDo/bdwQU5o7jKf8+ifeXe2VH4IPEcfDuXZ 7mw9Oz9TKrBuk+IPwFPDJK1TQxDIea8GJhQf5hyPNTgz84C/YoY3aV/IXWDDOVPEunbm yT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5i8Tn1SlVaWO4Nif6cMWUKjsN8bsR6wBD1bT+KmM76w=; b=mJ2LkTtPaz2AdSh40PW43qIOylInq37nw0pwsrtgE/hQGZhgRzhkmqYblUFs/Y+meK R5JXxajY9uEuJj+XWWcBx3iC2fIqhBgtAEmft5EYrDULGSe9Y5AyHR8P08P6tNt8wz2c h0JgTYnowAdI/hEl4cQFLJcB8kh9crAO05ZZq9coMCddqNiUtZ8KQzm6/RWAuu3kHF1W Vg3P+mxHo3JyyXY+u2jrbl6SQnuJQTZwkJoMHUyHNhGeyGyzGsy1Sj9ZlbiIQxb99Vhf 7+dRJrLV9ABcUrfHNE/4xyBIwZqgYtgW2e9rFBNfX87OD6As0hBNQsfpSCgBy5UVY1Mw QqOQ== X-Gm-Message-State: AOAM530ySEzxFyft55SUQqq4DSQxMaK5GvUf+TXqr3v12xP3QK3Pj8wO wJqSccyxSc6EgSVMuyt7GOIhbhxmfeYxeCwy4638dw== X-Google-Smtp-Source: ABdhPJwO4Ki99L1sEVcKwWhaw/oUf4d+mZNVNa5xcQGmaM6uFuYo31RnwPH8F/uwUGT1xa4+hc3Nh3Ik+sgMP9MwPa0= X-Received: by 2002:ac8:6752:: with SMTP id n18mr4841157qtp.8.1613979927541; Sun, 21 Feb 2021 23:45:27 -0800 (PST) MIME-Version: 1.0 References: <1613970647-23272-1-git-send-email-daizhiyuan@phytium.com.cn> In-Reply-To: <1613970647-23272-1-git-send-email-daizhiyuan@phytium.com.cn> From: Alexander Potapenko Date: Mon, 22 Feb 2021 08:45:16 +0100 Message-ID: Subject: Re: [PATCH] mm/kasan: switch from strlcpy to strscpy To: Zhiyuan Dai Cc: Andrey Ryabinin , Andrey Konovalov , Dmitriy Vyukov , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: fnttahdps3d855h4hodg1h4peccnkir7 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7B196200038E Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-qt1-f171.google.com; client-ip=209.85.160.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613979929-896803 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 22, 2021 at 6:10 AM Zhiyuan Dai wro= te: > > strlcpy is marked as deprecated in Documentation/process/deprecated.rst, > and there is no functional difference when the caller expects truncation > (when not checking the return value). strscpy is relatively better as it > also avoids scanning the whole source string. Looks like a good thing to do. > Signed-off-by: Zhiyuan Dai Acked-by: Alexander Potapenko > --- > mm/kasan/report_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 8a9c889..fc7f7ad 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -148,7 +148,7 @@ static bool __must_check tokenize_frame_descr(const c= har **frame_descr, > } > > /* Copy token (+ 1 byte for '\0'). */ > - strlcpy(token, *frame_descr, tok_len + 1); > + strscpy(token, *frame_descr, tok_len + 1); > } > > /* Advance frame_descr past separator. */ > -- > 1.8.3.1 > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg