From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900B1C38142 for ; Tue, 31 Jan 2023 10:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12E306B0072; Tue, 31 Jan 2023 05:31:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DE596B0073; Tue, 31 Jan 2023 05:31:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F016B0078; Tue, 31 Jan 2023 05:31:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E0F5C6B0072 for ; Tue, 31 Jan 2023 05:31:05 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B60EA12054D for ; Tue, 31 Jan 2023 10:31:05 +0000 (UTC) X-FDA: 80414726490.20.C0938C8 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf12.hostedemail.com (Postfix) with ESMTP id B74E140012 for ; Tue, 31 Jan 2023 10:31:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N4W0VQzf; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675161063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=biRptAnS/23/d1sfZT7OvK0Nsb2kEXEG2iefSRQIeYE=; b=WTXNx7eifEQEn3FjEcbTPXAb9Cts/rxl6hPvj3FvbrAeHCdKBQTeW63tTxVPgbWUbg8PnB 7lDMnFVPBYSTHk4lcfv3UtZdmC/mibz7iPHpljXMCZ2OXu51AzH+5cqefAcGmiXdDi1H78 vR9d8cK6a3L67B3H1wwNxN0OKs6umLk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N4W0VQzf; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.221.177 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675161063; a=rsa-sha256; cv=none; b=GF+sKTJbobtfM4ZUQhdRlFuZY/Bxbn7o3Oex/OFA2r4YrHAGJDkYUgfM6tDvR0Ho+ECIbZ pqInaB19bCMFUSaiHzqUpEOEfV+gTpw9z8ecAnWyYZUdGxpajqIxTecKauXIFf7MzGN/zh +z/3U9SteDAvrgt6UwoeaA+HhuCl2l0= Received: by mail-vk1-f177.google.com with SMTP id l20so7122050vkm.11 for ; Tue, 31 Jan 2023 02:31:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=biRptAnS/23/d1sfZT7OvK0Nsb2kEXEG2iefSRQIeYE=; b=N4W0VQzf/QKJ6ONvniC2q/NvKJd+XXlmKEn46E/k278t7UNFa9Vcja4Q5Uoviduf1A 62OmwHUqF876n1Ml7aNMGN6Mkfys5arnC0CMD13LwK7oOglYKD9Rj9mphMsOQb5vNxHP XFvrqQxNYijZ6oupnsOE7wlEbT2FFAIVqjev1NxAlqah8Cg2rWi4ZrEVlBMbmRC7KyWM Mgth4/XThgiKdtx4/O+6GCQdWAuVPXDmGEk7I8xGUWQRUzKTNDG+0/r4uDidaxzIb98M pHRVCdCX6jxt9gu0a37ofWJRheHTQyts/ZBrtbXSZKiEe1fugC+AfJmNIxQzIum53dvQ K/cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=biRptAnS/23/d1sfZT7OvK0Nsb2kEXEG2iefSRQIeYE=; b=3GupEBsIDBSzMDpLP/aY6AN/jnVlTD1Kph69ZRSNYL3wQpoc2CnrwKDEIASt5nBqaB 6E1wOh87CM02W6aMaYekwk7O4Em2owjo2xH3iI1oKZ5o+KxYlt/n19M4q4D+P4Z2ff88 1ogZi0Qua3z1M3l0vAQfm5cJETatGjKHJfoHhq00Vg+MoisYn1FaxtB/BdRtaowDcsQh 6eOP8mNbWHd6Hw1HTdOXiiQy6SwU6t5y79nAKKIiebvNrBACh3jJKC4UMibPjqA02uDb xlFg9uI/I1/p60jvSuzGk20WbtnLVQfmyTo2pRnLpZblyFoptBlNfZ2qwuQfyw4fg1it RBxA== X-Gm-Message-State: AFqh2kpT3Brxio/0QkwGVT/LkuaGSwSwNyhDszupBza8xvfCwjN/2Ege WIjm+xuECL4rJ2M4OVrdcAtacWTUHCxmz034UGN8fg== X-Google-Smtp-Source: AMrXdXtA+nQqDbRIGryG5iub+Xzha80yKCFEITt1L/ujGSq+l3Ow5201zNt6pfcrxFe3paPOA51MxPiHEIgf1d0NJ7c= X-Received: by 2002:a1f:ac0a:0:b0:3d5:911f:daed with SMTP id v10-20020a1fac0a000000b003d5911fdaedmr7024011vke.39.1675161062850; Tue, 31 Jan 2023 02:31:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Tue, 31 Jan 2023 11:30:26 +0100 Message-ID: Subject: Re: [PATCH 06/18] lib/stackdepot: annotate init and early init functions To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: if79wqpz671bhqc5ix11q7y9kdiojabk X-Rspamd-Queue-Id: B74E140012 X-HE-Tag: 1675161063-532258 X-HE-Meta: U2FsdGVkX1+S92QSzLY84mMu7wvgWz0pug/LZy1W5fh3hqqB14JJeDQ6JAgMojsEIJyMFsM9wuvqDbthPvVrQX7L0s07g98vYBMGGqjqB0CBR0vylHMFdWqE8fhxdxu9TaQTQrSlYadwcio/2z1ZMECkHVu8bx26vUCToT8qkN8Xtm28yEns+n4FbIyoXJnf0EXjvQ/zxTSrXBJ6JvV4N1/vXHKpq3fmbtiIyCmqjuLcs7Qy3iG0LGb6F/WXWc5fVIFnrEdqDoJ2ye6uIiaVq6TCzvS75kmUQgQjPn0M+nJ+GFIKIQNe/twxIG3EAoTw8q8kPkT+3fAH+mmUprqw9Yhz5PvgjI3plOgbJnyKziIB4ZO9wfVabeHmRRvODVhCkRYgpl7s7tJzvUg1ynh+eVE6eLBoMe9oLZ35sqXDEby+5C9mA8M5jCR8Ro+b6v1Rq+IiPOdLiEXDNLxU6qy4riawjeayowVyI04XzzdMnzsYjigfLGmIMJ2yuSrbw7HchYiAl4CjmT56gWIdtZy0tDaKUeM14FtvKCxpNluUaG5unHNoABccChMzHZqJ/TPi9OAbTShR5Szb5dSNHd7GZezRcH6BPLP/UZI3aNc41r66n1RLALYxfZNgszpRihIpYGRtBjuJPBO2bb/S4nyKty4akPpI1C5Mrp3Qll5mF4E/Tlm7Psz6qyZuGprRzG1ENx9uUFu9iebluijQEnTj56DRWVVsirpo+qqve+eS7WIqVLwk01iCA6Mr27AQTeagsL7duJ5xgSkK3CTfXPIxUX6hcxP7Wlzln9q9wWekkLsOE6Tui2+HuUxcejD6kU6Pw3QeL9znFtnApca90+u1/mfeVooxasOk9qM8kH/GGMFMBRc9UaPpVSWz3RL+4PsKfizQNgiy0BFwycC892JeO78mqF2JC3AL/GPLBjoLdgyXxn4fMyxfr/cDxD45U4KS0BiGQ1Y9PgbvVTQgO9R xM0Jgky1 w2+W6ucEWDumXBKHTRcPOlRJGhUSssbCzd1paMDw6FvnmCia+q+2UxbWGaEM12eBf0O7oLe8PnhbKsnL3cB7Hi61cOulgWChUohYEF62/MvH1Xf/4LWzhT5hbnTmErNbJvb5ocZL8DGWQlTy5VTUPnCG/p5XmVhkKY7rXUeLnyFFpN8xpdA+hBA9r9JcgSnP5zOMeefCB3s9vQEiswcXXiddVTN3H8gi7IhEWqUszviR49PomopQxBPlVkq6CRd/5KUGFfgrBMBXrl/DPrtmDIh8Zq0CuqM01efeXebljY7Vt8BU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 9:50 PM wrote: > > From: Andrey Konovalov > > Add comments to stack_depot_early_init and stack_depot_init to explain > certain parts of their implementation. > > Also add a pr_info message to stack_depot_early_init similar to the one > in stack_depot_init. > > Also move the scale variable in stack_depot_init to the scope where it > is being used. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko ... > > +/* Allocates a hash table via kvmalloc. Can be used after boot. */ Nit: kvcalloc? (Doesn't really matter much)