From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00356EB64D7 for ; Wed, 28 Jun 2023 15:40:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94BFD8D0005; Wed, 28 Jun 2023 11:40:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FC2A8D0001; Wed, 28 Jun 2023 11:40:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C3E08D0005; Wed, 28 Jun 2023 11:40:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A1A98D0001 for ; Wed, 28 Jun 2023 11:40:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1A1791202B0 for ; Wed, 28 Jun 2023 15:40:07 +0000 (UTC) X-FDA: 80952567654.02.56A9C00 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 34EADA0022 for ; Wed, 28 Jun 2023 15:40:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=V8aAqZOo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of glider@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687966804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KOSO4zVpvAMwe82RSNidD+tbsLnsOaD0mj0C5Zdtr28=; b=3nviM571aKikmcJzYj6HL9/948UwBhmg5AXxw3vKFs2UimTEMJ1R7Yurs5NpkEZdLMlrE2 4m2H9XF2tlM9Ac1WeKzRURJBYQelvM0ZaBjYUd+vTKPRO3omTGj23vhrFdQbR3SaGd0GdU ETdxcjJn5vjWIZVyV2VRuB1rBla4PDw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=V8aAqZOo; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of glider@google.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687966804; a=rsa-sha256; cv=none; b=P/Sq479sWHtIVMmAnWmq1i2sP8SZ966xiGsqU9AV2DFmOBYPV7TwbFrkMxeS8EfNh8++X/ c6mwogNZ6J09xXYF9Fj3pS5fGeKH8S1D1GaWYpB6spF2ayq/ppTt0JE099GjmP9CJqkXVG vUK7hwwsTWv+4jxjm18NsohyPzN1VSQ= Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-785d738d3feso1598139f.0 for ; Wed, 28 Jun 2023 08:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687966803; x=1690558803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KOSO4zVpvAMwe82RSNidD+tbsLnsOaD0mj0C5Zdtr28=; b=V8aAqZOooDN/qnT93zZgeue1+ka0jZKguF1CMblSS+Ob7R90ZJ2oO9QLsjU5DolgKv lgEM7oF2Y97+R8wdWwV42Un6ICHi8ME3E5iE98imfoee/ENxe/t4VpypJWevrRzcvPd7 b284Dre7/54zfTZjwphANWhWIZy9K+DecNv7Nq7rzy8NnmXiO4W3hzf9XWspxaRfHz5q 2pPPCwa2PAvKT0DlNOQxVM/K5p+fIp/Bq4RqIQ5ov/U5U6d7poPZJ5OkqPy7U6e8NBZY 6vif8/TJubhGw1v6s/lwlxMJhrA7Y10rM6M9AHewEhRC7B+HNjvFwtyjp+JbnhiS2+zk GAqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687966803; x=1690558803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KOSO4zVpvAMwe82RSNidD+tbsLnsOaD0mj0C5Zdtr28=; b=eFg3Y0vmgl82MrFNb28FbZ2K/cUknCWEybUA97l9UEKGgTRqldBLPrVQtRZaTCCmKj gv6pUXGzPPCTix0HbMHB6lvLxim+iVl/FBBt3nbgobBeVYecxTUyUGsxx5xoZXi1Qlgp MNR+kEk5kJwrF9Mn6JXupj6g22AjSGvpDtMQVIfHYBlve77YZMwVkXe/Z7nqR5vxkLPo ah4iSLeJnGOrJuew0ClXDz+XNHuEmbpuPLy65gx8ajKa+YttIx+dmkhPkzkPnR56YUzs 1fXtmigM6dKq04OKde04zsEWzmte7jwAXHrk+6ET2iKmtp3w6cRgiAeTcAyrURq/iJXD yEKQ== X-Gm-Message-State: AC+VfDwScoetk8LdEnr+G7iyLhkm+L9trmVr3LCWqWO/31siIdWytWn3 SFrpl986nQtgjOKY3HBiaZfUh+H3DanLVNFvpIBmXw== X-Google-Smtp-Source: ACHHUZ5E3xJmaCI90D6A1BT+kRyBtFHgb/LjEfnKhF7Ss/PY2Su6NtI4BF50DUWovrNaAX2wnCRS55JeKY1oshzrTZg= X-Received: by 2002:a6b:7d06:0:b0:783:727a:8e15 with SMTP id c6-20020a6b7d06000000b00783727a8e15mr1146287ioq.6.1687966803127; Wed, 28 Jun 2023 08:40:03 -0700 (PDT) MIME-Version: 1.0 References: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230628153342.53406-1-andriy.shevchenko@linux.intel.com> From: Alexander Potapenko Date: Wed, 28 Jun 2023 17:39:26 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] kasan: Replace strreplace() with strchrnul() To: Andy Shevchenko Cc: Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 34EADA0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: x4qu7wn3ebk9cdu7tt6prxmgeuu7amkm X-HE-Tag: 1687966803-495439 X-HE-Meta: U2FsdGVkX1/+nZFza6GHew3jkMEBluTya9Qq0vVwuX6KsNLA+Kux5HwglnzBPLyvpKrZ5jDP5zGlF9Xul8m2Snkto1g9hHsz6n6M4F5SqOLMaKWdvA21OZTB6vr1lAlhvRP5dKCG7Aoff29SlqCPIU1esZrk3R7I84ZthO9sV3+yZ20ujFta4vOBkVDnKDIudLMgTgihxH3akAtkPuTypiFnMpW/FXqBnRerfetiei7+eX7sF7pgLuvcYdMHyrUvY49MHeW+rea4+ug3AfbVfS6tvd1h4W7iEC06kB4+PZ1PnrdYw5XkIp//ZOnzrVF9Dne+ECJUg3IKnhZmEkLwolbNiSZA33tbWAvHeNuZ3oFkNMuA8Ok80DO00XTbh7EfjiUnmG4Tq8RzVygRValfYt5T9pxVCFs32syyuoSXCJpjkLLH4rrIGqxERmzXSVXOLLgO6ND83dapTci5dmMKUaa2DC/3MhOO4F9ZwkCuE5EQv2n5sEPQE0Wd++AGQ/m0UsabgARQhgcoyL+3Whu9kuNeqhCsF2X8SGj9Im1YskTHkfGOGfmziYCUSh+YFLYeO/HkwxrQgDRDQDVIqhZdGCfp0eSfv98TLyKyNI0RxCRICj2qWsNQy58x6fY3Cgxr/tYQJLF9PDRH9mVPgJfPkFBDwMDhjmvYXRgoqBrcjru6C+YeEoUB8bZNmIgwZXVVnD6wv7cAVCWDPLwApqeLhHJ2uWrdWbAs9RFgZxj7Lj6i8uHVZEKtWow2kD3ubUUzz7pGrp87FEzPVoKMSlNbVPX/wzmvIByDKCtt8TT4njVCskWoK9HE9Bc7IWePT0LAfttbTgkUBg6TWjCIahBJb/NG4RcLHCSl+7WFxwvZEKZNA04e6pKWGv2jR+STOPdxO/HP799DM258dja84W2zH7N7NA2Tj1b6Ct2QNWwRBVLeAfaAFSz4pSye8WlGrVvD2VhUj4C+Im0v4T7DZvu J7GwNGQe XdVP/Bl8gvAgdkSB1j+9U98srFnd5wVgrvJ6rgRBGIi8Y8vObmEe+A/gvFfDRX+tBTDHEgLRH6+y+lcUA69W4gE2VUjmJthBQSM8PMt1FSBRBpKCD28r0JjzuOlqEsGqYjeCzeGwzty7wxPa09e82jTCqEQ69tJy3Xr8aSy9HuUqVk7PJ108/KOq7q0feXaau7kToItdJ7VH5VLSYbeXlB9wvvFTGbgvVHhmn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 28, 2023 at 5:34=E2=80=AFPM Andy Shevchenko wrote: > > We don't need to traverse over the entire string and replace > occurrences of a character with '\0'. The first match will > suffice. Hence, replace strreplace() with strchrnul(). > > Signed-off-by: Andy Shevchenko > --- > mm/kasan/report_generic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 51a1e8a8877f..63a34eac4a8c 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -264,6 +264,7 @@ static void print_decoded_frame_descr(const char *fra= me_descr) > while (num_objects--) { > unsigned long offset; > unsigned long size; > + char *p; > > /* access offset */ > if (!tokenize_frame_descr(&frame_descr, token, sizeof(tok= en), > @@ -282,7 +283,7 @@ static void print_decoded_frame_descr(const char *fra= me_descr) > return; > > /* Strip line number; without filename it's not very help= ful. */ > - strreplace(token, ':', '\0'); > + p[strchrnul(token, ':') - token] =3D '\0'; Why not just *(strchrnul(token, ':')) =3D '\0'; ?