From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C33C433EF for ; Mon, 16 May 2022 11:49:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D76C16B0071; Mon, 16 May 2022 07:49:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFF8F6B0072; Mon, 16 May 2022 07:49:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B79466B0073; Mon, 16 May 2022 07:49:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A169F6B0071 for ; Mon, 16 May 2022 07:49:53 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 62F95121167 for ; Mon, 16 May 2022 11:49:53 +0000 (UTC) X-FDA: 79471437066.26.A227C93 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf02.hostedemail.com (Postfix) with ESMTP id E4FC3800D8 for ; Mon, 16 May 2022 11:49:43 +0000 (UTC) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-2fee9fe48c2so27986017b3.3 for ; Mon, 16 May 2022 04:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4XtkkgDY70ODUGHGl87xJIvARSTddMeTRl5MzriSEag=; b=tR2WwLJQK3Xoss/NvMGDcRkuGYbpCWjlIeAtJ2fMqal3hOIOFZxrBYz4T3pkmi/5kT xOi7S5z5/vP/VDnpXIh/1M/WpZFpS7X0u2UxPcfYL1JNySJvNfEhgTBkhsB2nKlXP7Mk 5geihxNdDq6mP/nnE6vaApD43Vf6/weNRQ1fu0uahCM/tEdy6VtTQAZXmdjn/xwRRoYn edjtIBHuvBjPE8Y+in06a0p5q676OvBJrn+QyU/SAjN2GjXxa99D2NFhhgHWNuaIOzPz hFUT6cp0oaGBfZnXr2VMLvy5FGl1uepzcbU2YZFEotz2VOmdudnUBEfWuJUPTytfniQk /caw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4XtkkgDY70ODUGHGl87xJIvARSTddMeTRl5MzriSEag=; b=E8Oh8SG9vIMMCIwJw1/mz/OFLuebjG5wuC9v2g3QH8SHUlyOwSfcLz3uUj32ztLsKE 1dMnAuYYJ1UERG+dpjbfn6KNLnkC5cHbEh8BVKzBQ5CKeJHMAx+/BDOkk3xus4DG9uGe zB0+n7TR4oLGIBtjoQ/Sms3ROfcHg7kDqhLPqrQeI81OHZbiTq8IlWp3loNyLR0y4WSu qaDFXnwL+t5oBaCC/L/bASEUN5naboKtDkrb+lRDEsDzw/wDzRiIuyG4rXsLPFeWccZ2 gz5hZ42+ZbIOVgu2H73Zf7Nfm10kebCnTwUKilv8rHdqYZyWeLrsw5pMUcTffZr/K2cq sVtQ== X-Gm-Message-State: AOAM530LYzFv2J/kRJA4XlaZAYXbvgW6RrbPNvW0PDTQQc1PjZn1MruB 1QRF/IdgiwNfAYERaUfWdIKnLnR5B3AHoNjOAWeE+w== X-Google-Smtp-Source: ABdhPJx2Q9of50T64pn6+gSbgtYcKkZGPXW6zopRcYz9chzp4PzVO+UL/Je9mgpUQg0Ktv0NtxHiV3crHzWpPx9s5Gw= X-Received: by 2002:a0d:f0c3:0:b0:2f4:d291:9dde with SMTP id z186-20020a0df0c3000000b002f4d2919ddemr19141054ywe.437.1652701791936; Mon, 16 May 2022 04:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20220426164315.625149-1-glider@google.com> <20220426164315.625149-28-glider@google.com> <87bkwmy7t4.ffs@tglx> In-Reply-To: <87bkwmy7t4.ffs@tglx> From: Alexander Potapenko Date: Mon, 16 May 2022 13:49:16 +0200 Message-ID: Subject: Re: [PATCH v3 27/46] kmsan: instrumentation.h: add instrumentation_begin_with_regs() To: Thomas Gleixner Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E4FC3800D8 X-Stat-Signature: rq4ex88btzbnicmimcnc58fzj3ixm365 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tR2WwLJQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of glider@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=glider@google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652701783-324295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 3:28 PM Thomas Gleixner wrote: > > On Tue, Apr 26 2022 at 18:42, Alexander Potapenko wrote: > > +void kmsan_instrumentation_begin(struct pt_regs *regs) > > +{ > > + struct kmsan_context_state *state =3D &kmsan_get_context()->cstat= e; > > + > > + if (state) > > + __memset(state, 0, sizeof(struct kmsan_context_state)); > > sizeof(*state) please > > > + if (!kmsan_enabled || !regs) > > + return; > > Why has state to be cleared when kmsan is not enabled and how do you end = up > with regs =3D=3D NULL here? > > Thanks, > > tglx > > -- > You received this message because you are subscribed to the Google Groups= "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgi= d/kasan-dev/87bkwmy7t4.ffs%40tglx. As discussed in another thread, I'll be dropping this patch in favor of the new kmsan_unpoison_entry_regs(). I'll also ensure I consistently use sizeof(*pointer) where applicable. Regarding regs=3D=3DNULL, this is actually not a thing. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie = mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.