From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85884C4361B for ; Thu, 17 Dec 2020 15:57:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2FEBD23975 for ; Thu, 17 Dec 2020 15:57:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FEBD23975 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C21976B0070; Thu, 17 Dec 2020 10:57:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF8356B0071; Thu, 17 Dec 2020 10:57:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7836B0072; Thu, 17 Dec 2020 10:57:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 940F76B0070 for ; Thu, 17 Dec 2020 10:57:18 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5757A8249980 for ; Thu, 17 Dec 2020 15:57:18 +0000 (UTC) X-FDA: 77603228556.08.able59_090987c27436 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 323C41819E764 for ; Thu, 17 Dec 2020 15:57:18 +0000 (UTC) X-HE-Tag: able59_090987c27436 X-Filterd-Recvd-Size: 4590 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Dec 2020 15:57:17 +0000 (UTC) Received: by mail-qv1-f52.google.com with SMTP id l7so13502136qvt.4 for ; Thu, 17 Dec 2020 07:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=T7Af0WGDzuMPlnkW0mmNLYKjVtF8jTxv62OsHLUaGj4=; b=WAINATTepcPgPrSyn0yPP9zTBQEdvwKM5k1moOzHpik9Ufa5/mpKQazFKRjM8Z49t2 4AUZHXR8qrDmskILAHqq74ibIBH95H3FD/mKDaXeQlhQM+xrjeO5ovhHZRVMcaaI38PP sS5P6AjhzL2+EIvDTyXdfL9fGAkUJxsSaqpdTM5udPUsrnUFpDfz60kmB/6EsjtN2yRU XKaqt9xIPQvK3qrTCbR+l5yFPBBgdnCOmUt9rJFZL3FiBws0a6NSC2lx4yrhmzZBaScg a4VuLLRvb+puX3E5R+aPLQn8uyE7ggWCXC3uwa1iMakkRPdkE3DwQV2jI+FP1ZQmOavQ AJ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=T7Af0WGDzuMPlnkW0mmNLYKjVtF8jTxv62OsHLUaGj4=; b=Lc7/zWLAonsV0YHgS2Y4WtJ8sCc3GcOeaA89kKIZb+Es7+MJ/XZSOAnB/zU3F4HjIk 80HKEgkj3eXRrp0ZzQc5wthmDzW2OKmFjCx6FWHfUWzNYvfGzXJa0mjRBhXFbpko99Eb 7RFQNMnyLr7oHdG9cm3wX9Mv/KH1CigfqGxqAlfYLgI5KtiHepBjH4IeYWq4bk9O6Gwc FFiV5xw1LR7+PC3h19UkXKEnF2QwsrNgBw6Tt8Op+Wq7ADouPVOMW983B7O8aO9tQQqd NwSFo5liK2j0LJThiuF+4pWFinKNK+27Pk086gVo7gCcXkPW4PapcA0T8n4XjmA+YHTd V9XA== X-Gm-Message-State: AOAM5304LyrBfXPx3N6tgSHPXQlWaMSTtK7NkOxYF2OCbbSYKlZMe23n L2j4BFPK/kDZ51bJWKOLicjlew5Ea+jL6luWmYf2HA== X-Google-Smtp-Source: ABdhPJwqF37+SawHs9+yv9V81dXgoeJN1J6Mw4jypPTzJMQPrRvuj2RwIW3uSkjiMTJCkM0lOQ3KsiIGGARlcy/U1+U= X-Received: by 2002:a0c:e90a:: with SMTP id a10mr41908062qvo.38.1608220636994; Thu, 17 Dec 2020 07:57:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Thu, 17 Dec 2020 16:57:05 +0100 Message-ID: Subject: Re: [PATCH] kfence: fix typo in test To: Marco Elver Cc: Andrew Morton , kbuild-all@lists.01.org, Linux Memory Management List , Dmitry Vyukov , Jann Horn , kernel test robot , kasan-dev , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 16, 2020 at 12:44 AM Marco Elver wrote: > > On Wed, 16 Dec 2020 at 00:31, Marco Elver wrote: > > Fix a typo/accidental copy-paste that resulted in the obviously > > incorrect 'GFP_KERNEL * 2' expression. > > > > Reported-by: kernel test robot > > Signed-off-by: Marco Elver Acked-by: Alexander Potapenko > > --- > > mm/kfence/kfence_test.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > > index 1433a35a1644..f57c61c833e6 100644 > > --- a/mm/kfence/kfence_test.c > > +++ b/mm/kfence/kfence_test.c > > @@ -665,7 +665,7 @@ static void test_krealloc(struct kunit *test) > > for (; i < size * 3; i++) /* Fill to extra bytes. */ > > buf[i] =3D i + 1; > > > > - buf =3D krealloc(buf, size * 2, GFP_KERNEL * 2); /* Shrink. */ > > + buf =3D krealloc(buf, size * 2, GFP_KERNEL); /* Shrink. */ > > KUNIT_EXPECT_GE(test, ksize(buf), size * 2); > > for (i =3D 0; i < size * 2; i++) > > KUNIT_EXPECT_EQ(test, buf[i], (char)(i + 1)); > > -- > > 2.29.2.684.gfbc64c5ab5-goog > > > > This patch could, if appropriate, be squashed into "kfence: add test suit= e". > > Thanks, > -- Marco --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg