From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48107FA3741 for ; Thu, 27 Oct 2022 16:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF4F26B0071; Thu, 27 Oct 2022 12:42:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA26F6B0072; Thu, 27 Oct 2022 12:42:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 991296B0073; Thu, 27 Oct 2022 12:42:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8C5CF6B0071 for ; Thu, 27 Oct 2022 12:42:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 21555120775 for ; Thu, 27 Oct 2022 16:42:34 +0000 (UTC) X-FDA: 80067297828.25.807079F Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf20.hostedemail.com (Postfix) with ESMTP id A7EB91C0011 for ; Thu, 27 Oct 2022 16:42:32 +0000 (UTC) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-3691e040abaso20858847b3.9 for ; Thu, 27 Oct 2022 09:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FrpT7jDzvIdd9Y+I9KcU+R/FrIS418eDQ+csIqtnsLY=; b=bCUbZ0x6v07vNmPZXYNcBG5Ey/ryv5OToKooQuXyplODjf24p5tWQ75jkhjBZV7gT3 oEsD+bBMYkbuXg+M/p6MAapBGs3r/Rv0wzvDTNq9Bn4+xNbDhY8Px2jjU0edEBq+nvST x6BxxX1ldzDvoynXqS/GXEnx2xgZbkC/ItOOUZTXPwE4M0X5LFkw02oW2vsxWgjrnVoq Tx4W7yBmJ5iJmJvREIW10dyHlLQBy6BZEYS3ZAm8QLKkvwtyUhONMH++0PRzFF+0ENdo b0cU2ASNHKh1+zWAMkz396EQEz8QufIJTCgaOF7SOhfzH9SSkxcjCXYR+oiS5AzSJI9U QBcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FrpT7jDzvIdd9Y+I9KcU+R/FrIS418eDQ+csIqtnsLY=; b=5DAgWq8RQn29f0JscEbuDfmVcjsHSF/NMZEVBp1C+K7qZICHqzPBuo5jzF5ExofPuK k8XcLQzfWkcRxc6vqyey/ARELiLN1u0La2NkDQa21SZ5KWTr/7mSMLAjhM1vJWMoD5Uu 8d1di4C6iVaRPnbVmiMGKqcHTK0BUSzbAeL/cpggTPCXmsX0uWQ+sa0tte+eCoivu4Pb ozJGIbr/j87u1w8+lKhMREb8/wZcRp8rDGTjQwO7kC+/sLVRwx1H14T4c6SiKpFPPYuD Ypsh51iXX7drgxUM7nNUVbu8TVLhu2W2DfaDamWBIOwbqTTlzCAQ4VXiXvnzlAvLNXHp LQ4Q== X-Gm-Message-State: ACrzQf3kGbvIiejyo0V7an7H6HJmiTmfovv0t0CN3PAQvDAuIKzoIekq wEaAsg1DXk5T8LWQw7LoaX+4dK9fviaSRKmbiHX1kg== X-Google-Smtp-Source: AMsMyM4nDk2ORHx8hkcRQTC3kyPEB7IQDB/Q/0FuOAjTdfivEShbqfFkgF/S7EodPoMvamKbzlOi/TcLzOmgp2Y17zk= X-Received: by 2002:a0d:c901:0:b0:351:b348:542f with SMTP id l1-20020a0dc901000000b00351b348542fmr45367421ywd.144.1666888951720; Thu, 27 Oct 2022 09:42:31 -0700 (PDT) MIME-Version: 1.0 References: <20221024212144.2852069-1-glider@google.com> <20221024212144.2852069-3-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 27 Oct 2022 09:41:54 -0700 Message-ID: Subject: Re: [PATCH 3/5] Kconfig.debug: disable CONFIG_FRAME_WARN for KMSAN by default To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Kees Cook , Nick Desaulniers , linux-kbuild@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666888952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FrpT7jDzvIdd9Y+I9KcU+R/FrIS418eDQ+csIqtnsLY=; b=twbLsNv0pD8fBS8KCasn+ItIwChmM1vXpXsZvs/K72VJSIDepV0pCsMoFI/ZPGaY8L8lpX IrNml1Q82hj0pfVnXquFa+5ykMSkGlkubOg7gthmAq8hTQuZotvgeLmdQQT9b4l0OVmJAf 9KdXR54jCeha/nV/otUpllPIWZHF8cQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bCUbZ0x6; spf=pass (imf20.hostedemail.com: domain of glider@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666888952; a=rsa-sha256; cv=none; b=OX9wEnPt/l/hhUFihrALgO6n55txKCFUjOIdVszsmLzCiPFgQcpjzzdtalB4eL5ExNTaoz HV4n411UXhT0QwYEnZugoyNlOMzxv3Kipj4oizxjARCpnSDrkeOLoI7NaZb4C9oxmcwYjZ o8PRV5nxDaWecM/m8rc1kW+Jhd6SKzQ= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=bCUbZ0x6; spf=pass (imf20.hostedemail.com: domain of glider@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Queue-Id: A7EB91C0011 X-Rspamd-Server: rspam03 X-Stat-Signature: rsh8so8kfpjf4nzdsxfmh3rssz966mpa X-HE-Tag: 1666888952-903939 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 27, 2022 at 7:33 AM Masahiro Yamada wrot= e: > > On Tue, Oct 25, 2022 at 6:22 AM Alexander Potapenko w= rote: > > > > KMSAN adds a lot of instrumentation to the code, which results in > > increased stack usage (up to 2048 bytes and more in some cases). > > It's hard to predict how big the stack frames can be, so we disable > > the warnings for KMSAN instead. > > > > Cc: Andrew Morton > > Cc: Kees Cook > > Cc: Masahiro Yamada > > Cc: Nick Desaulniers > > Cc: linux-kbuild@vger.kernel.org > > Link: https://github.com/google/kmsan/issues/89 > > Signed-off-by: Alexander Potapenko > > --- > > lib/Kconfig.debug | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 3fc7abffc7aa2..29280072dc0e4 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -400,8 +400,9 @@ config FRAME_WARN > > default 1536 if (!64BIT && XTENSA) > > default 1024 if !64BIT > > default 2048 if 64BIT > > + default 0 if KMSAN > > > > This is wrong. > > Kconfig picks up the first default entry which has > true 'if' condition. > > > Since (!64BIT || 64BIT) covers all the possible cases, > this patch is just adding dead code. > Thanks for clarifying! What we actually need is to forcefully disable CONFIG_FRAME_WARN under KMSAN, but adding constructs like "select FRAME_WARN 0" or "select FRAME_WARN=3D0" doesn't work, right? I'll move "default 0 if KMSAN" to the beginning of FRAME_WARN declaration t= hen. > > > > > > > help > > - Tell gcc to warn at build time for stack frames larger than t= his. > > + Tell the compiler to warn at build time for stack frames larg= er than this. > > Setting this too low will cause a lot of warnings. > > Setting it to 0 disables the warning. > > > > -- > > 2.38.0.135.g90850a2211-goog > > > > > -- > Best Regards > Masahiro Yamada --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg