From: Alexander Potapenko <glider@google.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Andrey Konovalov <adech.fo@gmail.com>,
Christoph Lameter <cl@linux.com>,
Dmitriy Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Joonsoo Kim <js1304@gmail.com>,
Kostya Serebryany <kcc@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kuthonuzo Luruo <kuthonuzo.luruo@hpe.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] mm, kasan: switch SLUB to stackdepot, enable memory quarantine for SLUB
Date: Thu, 7 Jul 2016 12:01:17 +0200 [thread overview]
Message-ID: <CAG_fn=WWWbeGkcxCnn37OBNjJiwVp=BHUeVX6T_5XACQQdJT5g@mail.gmail.com> (raw)
In-Reply-To: <577AF45A.5080503@oracle.com>
Any idea which config option triggers this code path?
I don't see it with my config, and the config from kbuild doesn't boot for me.
(I'm trying to bisect the diff between them now)
On Tue, Jul 5, 2016 at 1:42 AM, Sasha Levin <sasha.levin@oracle.com> wrote:
> On 06/22/2016 01:43 PM, Alexander Potapenko wrote:
>> For KASAN builds:
>> - switch SLUB allocator to using stackdepot instead of storing the
>> allocation/deallocation stacks in the objects;
>> - change the freelist hook so that parts of the freelist can be put
>> into the quarantine.
>
> This commit seems to be causing the following on boot (bisected):
>
> [ 0.000000] =============================================================================
>
> [ 0.000000] BUG radix_tree_node (Not tainted): Object padding overwritten
>
> [ 0.000000] -----------------------------------------------------------------------------
>
> [ 0.000000]
>
> [ 0.000000] Disabling lock debugging due to kernel taint
>
> [ 0.000000] INFO: 0xffff88004fc01600-0xffff88004fc01600. First byte 0x58 instead of 0x5a
>
> [ 0.000000] INFO: Slab 0xffffea00013f0000 objects=34 used=34 fp=0x (null) flags=0x1fffff80004080
>
> [ 0.000000] INFO: Object 0xffff88004fc01278 @offset=4728 fp=0xffff88004fc033a8
>
> [ 0.000000]
>
> [ 0.000000] Redzone ffff88004fc01270: bb bb bb bb bb bb bb bb ........
>
> [ 0.000000] Object ffff88004fc01278: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01288: 00 00 00 00 00 00 00 00 90 12 c0 4f 00 88 ff ff ...........O....
>
> [ 0.000000] Object ffff88004fc01298: 90 12 c0 4f 00 88 ff ff 00 00 00 00 00 00 00 00 ...O............
>
> [ 0.000000] Object ffff88004fc012a8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc012b8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc012c8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc012d8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc012e8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc012f8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01308: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01318: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01328: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01338: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01348: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01358: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01368: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01378: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01388: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01398: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013a8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013b8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013c8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013d8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013e8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc013f8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01408: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01418: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01428: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01438: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01448: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01458: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01468: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01478: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01488: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc01498: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Object ffff88004fc014a8: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>
> [ 0.000000] Redzone ffff88004fc014b8: bb bb bb bb bb bb bb bb ........
>
> [ 0.000000] Padding ffff88004fc015f8: 5a 5a 5a 5a 5a 5a 5a 5a 58 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZXZZZZZZZ
>
> [ 0.000000] Padding ffff88004fc01608: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZZZZZ
>
> [ 0.000000] Padding ffff88004fc01618: 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ
>
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G B 4.7.0-rc5-next-20160704-sasha-00024-ge77e3f3 #3135
>
> [ 0.000000] 1ffffffff4c40f12 9d094fbe896d693a ffffffffa6207918 ffffffff9b06d567
>
> [ 0.000000] ffffffff00000000 fffffbfff4cb1f60 0000000041b58ab3 ffffffffa5d082b8
>
> [ 0.000000] ffffffff9b06d3f8 9d094fbe896d693a ffffffffa6238040 ffffffffa5d26f04
>
> [ 0.000000] Call Trace:
>
> [ 0.000000] dump_stack (lib/dump_stack.c:53)
> [ 0.000000] ? arch_local_irq_restore (./arch/x86/include/asm/paravirt.h:134)
> [ 0.000000] ? print_section (./arch/x86/include/asm/current.h:14 include/linux/kasan.h:35 mm/slub.c:481 mm/slub.c:512)
> [ 0.000000] print_trailer (mm/slub.c:670)
> [ 0.000000] check_bytes_and_report (mm/slub.c:712 mm/slub.c:738)
> [ 0.000000] check_object (mm/slub.c:868)
> [ 0.000000] ? radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] alloc_debug_processing (mm/slub.c:1068 mm/slub.c:1079)
> [ 0.000000] ___slab_alloc (mm/slub.c:2571 (discriminator 1))
> [ 0.000000] ? radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] ? radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] ? check_preemption_disabled (lib/smp_processor_id.c:52)
> [ 0.000000] ? radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] __slab_alloc.isra.23 (./arch/x86/include/asm/paravirt.h:789 mm/slub.c:2602)
> [ 0.000000] ? radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] kmem_cache_alloc (mm/slub.c:2664 mm/slub.c:2706 mm/slub.c:2711)
> [ 0.000000] ? deactivate_slab (mm/slub.c:2129)
> [ 0.000000] radix_tree_node_alloc (lib/radix-tree.c:306)
> [ 0.000000] __radix_tree_create (lib/radix-tree.c:505 lib/radix-tree.c:561)
> [ 0.000000] ? radix_tree_maybe_preload_order (lib/radix-tree.c:550)
> [ 0.000000] ? alloc_cpumask_var_node (lib/cpumask.c:64)
> [ 0.000000] ? kasan_unpoison_shadow (mm/kasan/kasan.c:59)
> [ 0.000000] ? kasan_kmalloc (mm/kasan/kasan.c:498 mm/kasan/kasan.c:592)
> [ 0.000000] __radix_tree_insert (lib/radix-tree.c:637)
> [ 0.000000] ? __radix_tree_create (lib/radix-tree.c:629)
> [ 0.000000] ? _find_next_bit (lib/find_bit.c:54)
> [ 0.000000] ? alloc_desc (kernel/irq/irqdesc.c:190)
> [ 0.000000] early_irq_init (kernel/irq/irqdesc.c:279 (discriminator 1))
> [ 0.000000] start_kernel (init/main.c:563)
> [ 0.000000] ? thread_stack_cache_init (??:?)
> [ 0.000000] ? memblock_reserve (mm/memblock.c:737)
> [ 0.000000] ? early_idt_handler_array (arch/x86/kernel/head_64.S:361)
> [ 0.000000] x86_64_start_reservations (arch/x86/kernel/head64.c:196)
> [ 0.000000] x86_64_start_kernel (arch/x86/kernel/head64.c:176)
> [ 0.000000] FIX radix_tree_node: Restoring 0xffff88004fc01600-0xffff88004fc01600=0x5a
>
>
> Thanks,
> Sasha
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-07-07 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 17:43 Alexander Potapenko
2016-06-28 16:51 ` Andrey Ryabinin
2016-07-08 10:36 ` Alexander Potapenko
2016-07-08 15:31 ` Andrey Ryabinin
2016-07-12 10:17 ` Alexander Potapenko
2016-07-04 23:42 ` Sasha Levin
2016-07-07 10:01 ` Alexander Potapenko [this message]
2016-07-07 10:23 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=WWWbeGkcxCnn37OBNjJiwVp=BHUeVX6T_5XACQQdJT5g@mail.gmail.com' \
--to=glider@google.com \
--cc=adech.fo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=kuthonuzo.luruo@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox