From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292BCC77B61 for ; Thu, 13 Apr 2023 09:42:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83C006B0075; Thu, 13 Apr 2023 05:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EC326B0078; Thu, 13 Apr 2023 05:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DC16900002; Thu, 13 Apr 2023 05:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 602D36B0075 for ; Thu, 13 Apr 2023 05:42:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2832E1202EF for ; Thu, 13 Apr 2023 09:42:41 +0000 (UTC) X-FDA: 80675878122.08.054EC01 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 6E61618001D for ; Thu, 13 Apr 2023 09:42:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=p5qruo+v; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681378959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FXuvR6IorGk+vc4Sbx2+ljSRa/GREptQBSmjgKoDNBQ=; b=QriWwFvZTYEeO/ulsDtcU5sJoK0HNnsyXo4cef92XAruhL26n+M2M9g6PEjpQeYUYs3vNr E/r6iqOhMWdxMZckKWsntPZhmWqg78i3JfYnfxZdKn9inOobWMYaogPPa0cg+B1SiNn+Su RmAX6R8qV9UovdGWFGyU1Vj4FsqZHz4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=p5qruo+v; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681378959; a=rsa-sha256; cv=none; b=TN27/I6JbMGJKmnI1O4DglUDRWRR1jKqzHiqUvk9goDgr6Z9C2DPGGYZgYv6ueLJBhk1l2 2xuvsd2DnIwr4shcUCOBKrmNn3Xm9olGAd/72cHjXqPif2o9CqCR/6p/vz81PDM/o+xDSi jW4lMyp+skt+nK4KH1NzKdbAzMrEqVk= Received: by mail-yb1-f175.google.com with SMTP id i20so18356046ybg.10 for ; Thu, 13 Apr 2023 02:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681378958; x=1683970958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FXuvR6IorGk+vc4Sbx2+ljSRa/GREptQBSmjgKoDNBQ=; b=p5qruo+vwLOmiKdo9zfjlw8oOGsiW3ZhyU3s5t1eTAZWl1pBeBkTL6t40YHwQn3GFI NI2QEtrQ6G8kh5BFWJMngPiODpBFNej8mvd08VDINHZXAboshyC0dYi1xCG71aNdWeOA 5MnmtW90zfH0DuhAQS2cJmGWyzQBx9Q+MkqvLvGxJ7jH+UwoAW89+VS2PcKvui2PvGn2 Q+JKo81qMBYyAgUglWmMWLpwyByA/OgQQOUdHZir1BQHuF8oyUwcII7JzB3oyXxNkHOf AMSZYJ2XapdoXefH7JHc+a/P1YL5WtIb8e4TeAMQj45qzAbP8ApdjZDDLJJOo4FWnMC8 8nlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681378958; x=1683970958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FXuvR6IorGk+vc4Sbx2+ljSRa/GREptQBSmjgKoDNBQ=; b=CvwGbxaNchYCULr2snycmEYDOy2AqP7ZoKTNXd6RAWKZDmorOYSUmiNsti83zb5o/f ckdOZnFH+EM0dnLEj/gcyGN+jc7pWBixxa4PMCJ4nFkFRr0ZEmbE9yScDFG2Jk4HL2yO 59RMRZ8ZTXX7e/qbZonDdsyxFE2l+TKf5mJwlNwdb7comqtLly2n4AXFqOQFBOoemuqi dP6jqiPmJFBpBnE4da0ht8kXcGK2EO2yyl313Azqfa8HHhuzOFF2QpKo29MgLa52/66V Vthz4DRse02G9JbqjkSsmJkIg7Fgv0N7neTZRxexDR+S3qyiwKU+fmTC2Tyci2St96Fa 2fNA== X-Gm-Message-State: AAQBX9eC+GLJizcr/nbcei77B+lb2unjVqrdz34of8U3YeyGx8wOgaBV 7U1SE2dnBL1Iyq7XKi5nqYeUNExKwbRh34tVF1rTzg== X-Google-Smtp-Source: AKy350aIn2eg4lF1zv8Kw+eVubZMSxHczXifNKoJzcDAryVU6K0a4Ip63GAMTioeux0MH1upuKU6C7L4gGonN+vmr4I= X-Received: by 2002:a25:ae45:0:b0:b8f:62b7:e03c with SMTP id g5-20020a25ae45000000b00b8f62b7e03cmr190745ybe.1.1681378958351; Thu, 13 Apr 2023 02:42:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Thu, 13 Apr 2023 11:42:01 +0200 Message-ID: Subject: Re: Possible incorrect handling of fault injection inside KMSAN instrumentation To: Dipanjan Das Cc: Marco Elver , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, Linux Kernel Mailing List , syzkaller , Marius Fleischer , Priyanka Bose Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6E61618001D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 1r7sq4f15k1tygpqy9tq3bydyd5n4tok X-HE-Tag: 1681378959-693282 X-HE-Meta: U2FsdGVkX19C/AlHh50MmJM7AZpMd7+VyjB2GXqu/2b5tgQcQsFqY9BIMN7BcVf+8avBPQE8zeVBzubsK5Q6QLRmpE1143Sx7ABPP9jQZ+srx0wco5mB2yemRpp+gLy8PNnortms1MudtBUgWaqrWOgb1r60MC28H5LwxztDjrpqtEA8UlS0K4KbLZdJNSihuMZanWqL7WV2mxNxOFxZGjcHL7nfKTYswuiqTJdf99PWVWuFCML8latyqVrpAyKTziuSJeQwxOAOeWX1A0JR6xxvANZPddxwg7UNAECxPUtpEsYJAbIJuWkErENcooeqkgbgVz0Wo582VqolMVsBnsLC2YYPKycqsnyKzfsVD5iJjwKJ7HZijSRfBQZVQZwx8Nz8yTD4iL6DawyjzNFl0AC9/JsM9YurPTC4VdDf8ZtLh8Rou4GVzaah8XVRljjlZTd83V++macag5cqKlTwboJSgm/GgRzT9Qn2WoHln9wWEYVN97QL84Ie4cN451IPx5vfx1i6MQakkDuAGHHprjrj8XXeLQtrhUs56/spkvG6ZMZCfi3F0ShbF5glQpqDEuXQS9rQXpWqzsZrontoOFWzlgVHBjo4X/UnE+30D2xeotdFGqV5LLWUYLDvATSH6H9oIk10kduVGLJlT3ofbfJ1M4suWTsUY2QS1LCbpkzT521I4JLc2kFkNuw1PoEhSB68qG8ojJ8TNLL/+Ssk86YCH1rp0cHRSypprdYKOHG7kSYTsh7ALwbpvqY36cZ3EYshbk8QJlqOWJ6mgnHV1Zp+Po4It0skgc9i9Yemm9+NHl+aT92zwXO0AxWTAk8C/u87lpowG7l0ZjRJt3XpH9drLLFvtNnhcmGrxTvQTNA4zdoKigJ94K/JRRgcBtLyCyinqYuctYs8BBJc03lq2CRKACq/ndEb35lkoHhF4R0rOHfoty9vDmdgJwuR0Qpgdnz0mpj8rru/gPJ/cxD mjN+T7O4 AjklJV/yacIdkDBJ4nV0gy6GylzbVqQKdgPmmlsPs9LTnaI0prSqQJoA3ZEmsSRjsJxq4RG/my4+a3PqPaeblM+boOFQu8Znbgz1Ul8DZF60YPY0D6Ude2P1r05VaDiRwrG7jxGKwC+MEz3UPYplDy6+lPyWCV/1SP2v8w6gSt1bzn0Ow2rhpC+y1oWcDvEbII1Zb4lMyTZtTLVmtPCgJE8/8Ds+LVLXM0+mX397HBokwaulOlTqeIgCEdJYqVvgvyG6ni1svGjgYOgkDVgGibF0G/C5fHJXP1PFpvEGN/sjLaUUo/meXCd2rW4z//pRHHOo2sOCRVn6c7Meg0I2fR4V8LEU7u82DUKPG9P0q+nrkiXifKfYfj0jEn8qhNieUkM2e X-Bogosity: Ham, tests=bogofilter, spamicity=0.002307, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 12, 2023 at 8:24=E2=80=AFPM Dipanjan Das wrote: > > On Wed, Apr 12, 2023 at 7:39=E2=80=AFAM Alexander Potapenko wrote: > > > Here are two patches that fix the problem: > > - https://github.com/google/kmsan/commit/b793a6d5a1c1258326b0f53d6e3ac= 8aa3eeb3499 > > - for kmsan_vmap_pages_range_noflush(); > > - https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c022= 74f24060cff > > - for kmsan_ioremap_page_range() > > > > Can you please try them out? > > The second patch needs a small modification. > > The return value of `__vmap_pages_range_noflush` at Line 181 > (https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f2= 4060cff#diff-6c23520766ef70571c16b74ed93474716645c7ba81dc07028c076b6fd5ad27= 31R181) > should also be assigned to `mapped`. With this modification, the patch > works. Good catch, thanks! I'll send an updated version.