From: Alexander Potapenko <glider@google.com>
To: Dipanjan Das <mail.dipanjan.das@gmail.com>
Cc: Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
Marius Fleischer <fleischermarius@googlemail.com>,
Priyanka Bose <its.priyanka.bose@gmail.com>
Subject: Re: Possible incorrect handling of fault injection inside KMSAN instrumentation
Date: Thu, 13 Apr 2023 11:42:01 +0200 [thread overview]
Message-ID: <CAG_fn=WOZ2RTyTYrgV3JhsqESf-YCmj_FmbzJZdJogpZk8SnOw@mail.gmail.com> (raw)
In-Reply-To: <CANX2M5bWPMDJGgD=xq33A3p96ii3wBOuy9UKYAstX4psdAGrrA@mail.gmail.com>
On Wed, Apr 12, 2023 at 8:24 PM Dipanjan Das
<mail.dipanjan.das@gmail.com> wrote:
>
> On Wed, Apr 12, 2023 at 7:39 AM Alexander Potapenko <glider@google.com> wrote:
>
> > Here are two patches that fix the problem:
> > - https://github.com/google/kmsan/commit/b793a6d5a1c1258326b0f53d6e3ac8aa3eeb3499
> > - for kmsan_vmap_pages_range_noflush();
> > - https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff
> > - for kmsan_ioremap_page_range()
> >
> > Can you please try them out?
>
> The second patch needs a small modification.
>
> The return value of `__vmap_pages_range_noflush` at Line 181
> (https://github.com/google/kmsan/commit/cb9e33e0cd7ff735bc302ff69c02274f24060cff#diff-6c23520766ef70571c16b74ed93474716645c7ba81dc07028c076b6fd5ad2731R181)
> should also be assigned to `mapped`. With this modification, the patch
> works.
Good catch, thanks!
I'll send an updated version.
prev parent reply other threads:[~2023-04-13 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 15:51 Dipanjan Das
2023-04-12 14:39 ` Alexander Potapenko
2023-04-12 18:24 ` Dipanjan Das
2023-04-13 9:42 ` Alexander Potapenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=WOZ2RTyTYrgV3JhsqESf-YCmj_FmbzJZdJogpZk8SnOw@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=fleischermarius@googlemail.com \
--cc=its.priyanka.bose@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mail.dipanjan.das@gmail.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox