linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Potapenko <glider@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
	kbuild-all@01.org, kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [linux-next:master 11691/11963] mm/kasan/kasan.c:429:12: error: dereferencing pointer to incomplete type 'struct stack_trace'
Date: Fri, 11 Mar 2016 21:26:28 +0100	[thread overview]
Message-ID: <CAG_fn=WN0hT3DPSXGr3OD8uLRD5kXxbDgKY=zedOXvktfYwfVw@mail.gmail.com> (raw)
In-Reply-To: <20160311121923.656fbcc79b5490109573c65a@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

On Mar 11, 2016 9:19 PM, "Andrew Morton" <akpm@linux-foundation.org> wrote:
>
> On Fri, 11 Mar 2016 18:38:47 +0800 kbuild test robot <
fengguang.wu@intel.com> wrote:
>
> > tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   bb17bf337db5c5af7e75ec5916772c9bffcaf981
> > commit: d5e0cb037c3f7a9cc54b9427e0281c7877d62ff3 [11691/11963] mm,
kasan: stackdepot implementation. Enable stackdepot for SLAB
> > config: x86_64-randconfig-v0-03111742 (attached as .config)
> > reproduce:
> >         git checkout d5e0cb037c3f7a9cc54b9427e0281c7877d62ff3
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64
> >
> > All error/warnings (new ones prefixed by >>):
> >
> >    mm/kasan/kasan.c: In function 'filter_irq_stacks':
> > >> mm/kasan/kasan.c:429:12: error: dereferencing pointer to incomplete
type 'struct stack_trace'
> >      if (!trace->nr_entries)
>
> Yeah, that's a bit screwed up.  The code needs CONFIG_STACKTRACE but this:
>
> ---
a/lib/Kconfig.kasan~mm-kasan-stackdepot-implementation-enable-stackdepot-for-slab-fix-fix
> +++ a/lib/Kconfig.kasan
> @@ -8,6 +8,7 @@ config KASAN
>         depends on SLUB_DEBUG || (SLAB && !DEBUG_SLAB)
>         select CONSTRUCTORS
>         select STACKDEPOT if SLAB
> +       select STACKTRACE if SLAB
>         help
>           Enables kernel address sanitizer - runtime memory debugger,
>           designed to find out-of-bounds accesses and use-after-free bugs.
>
> doesn't work because CONFIG_SLAB=n.  And I don't think we want to
> enable all this extra stuff for slub/slob/etc.
>
> Over to you, Alexander.
Um, perhaps the code in question should be SLAB-only. I'll send the fix on
Monday.

[-- Attachment #2: Type: text/html, Size: 2373 bytes --]

      reply	other threads:[~2016-03-11 20:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 10:38 kbuild test robot
2016-03-11 20:19 ` Andrew Morton
2016-03-11 20:26   ` Alexander Potapenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAG_fn=WN0hT3DPSXGr3OD8uLRD5kXxbDgKY=zedOXvktfYwfVw@mail.gmail.com' \
    --to=glider@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox