From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9A6EB64DC for ; Wed, 21 Jun 2023 15:38:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A05DB8D0006; Wed, 21 Jun 2023 11:38:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6CE8D0002; Wed, 21 Jun 2023 11:38:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A3EF8D0006; Wed, 21 Jun 2023 11:38:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B7518D0002 for ; Wed, 21 Jun 2023 11:38:19 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4C4131608FE for ; Wed, 21 Jun 2023 15:38:19 +0000 (UTC) X-FDA: 80927161518.25.1F623AE Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf05.hostedemail.com (Postfix) with ESMTP id 5E1DC100009 for ; Wed, 21 Jun 2023 15:38:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=NlxpJTc9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of glider@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687361896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y5kxm8AmUyv0LNgmCEGT8IbGfv7bD38A6oy8gwVbxdo=; b=DQ2zt8r40Y0LonfubLpbCQQG8EsAmVt00xohr2VDghJXNAWes59oRIKYmhgwTBlcXfl+Nr xIwvatrnSGhlTzJhxffwqYFFWApU8FTL1JfSt7I0l7ahsolWuvVYhtTJh0e7eNlCGLCYmn MzNnHS1jCf9NLr5hNsB9Ep5H2Bn6TkY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=NlxpJTc9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of glider@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687361896; a=rsa-sha256; cv=none; b=HxpKuZ4ctGwK/TOeBC08M/Ofea/hWvrInhMIHFExfbfrssrX9RWHkOOFo1YOqy/hcklVUN t8zHqAilXX9wvkz4VmTdHI7qpF6Xpq0OXLmDDapcORLx1FvJEev+v/WQJ+ag5TifWwuPw9 t4sNSkImINYm1ejPOlR9rvj97PbBqMM= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-62fe6773c4fso44540016d6.2 for ; Wed, 21 Jun 2023 08:38:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687361895; x=1689953895; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y5kxm8AmUyv0LNgmCEGT8IbGfv7bD38A6oy8gwVbxdo=; b=NlxpJTc9GIJoKzNqQYdKAMdkhxB10lnlVUHvO5ZC2mTd+NK85xZ518bDL3fD62rh6a 39QIIEI8GmcsGXK3jkWPO+vJpw/E5ZKtkS0bXzTWwfkQ8MlUq61fulpegsKGXxts8mBq SrSGV6emIYSzitqRIHOG4FUhnK9fzPDEqgptvwNCatPZu/dz6uC3l7FZP80sloBwOQbj sGIO7F0JqN1/H71HDV7Kv05aSK4UhXWp9F3zQ5N12reBx0vY9cOUAxqJE2FZsinO+U8+ P8tpstOtQYrfGQj4pL0wsPLoz8gIv7/nAuJRYqY568qg099Rg0YGZaRbDs9omjtRArZb VS4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687361895; x=1689953895; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y5kxm8AmUyv0LNgmCEGT8IbGfv7bD38A6oy8gwVbxdo=; b=JUOQZ/lyyOEb5ZMaMrJZknYMbxI3ttlKepySxE89Ss0Aoajx/BPOrPlPjjpCyHOCTJ VtbXg89yyyuINl216Z+HRpkSCDYNgEqBbx9b1N8HZ4qJEwD6m0CMRdTYqkljjOc0w2+K b/2cbpE+R35G3vt9hQkXox+FewTX6GD9q9dsjX1p0ms9O+y3aivGBr0oUuNI0ZAeRRDT zdsFzj78fC/3ux8Zaxbf3ZXpbhmfTXYEA1JgwwU2P1+t7DZVg6ssFSubTGaYAKkY6v2S LbRwAfSDNwu68zgDruE263YGw6IlBb9QgVoLyM7XCI7vD+OD7tJCG9lLSelpfwwzW9WW Naow== X-Gm-Message-State: AC+VfDwsLkEhRgAfvIhnfS/klYXAQHgL75LNo4x8RZU+lVPyt/ivRGZ4 tlEuhdKKoAwPUakoPcCgdmjisEskiakQAmVLJDYFYQbZ9HF0wr0+JJ4= X-Google-Smtp-Source: ACHHUZ7sHw/PfL/r8vVeQZ6cuDxpUvq5Z+IiFaMq+NXRJQk5uvMf6BAqHqgmLXOj16GFAeHsROdu6JlCX5+4nKr9gW0= X-Received: by 2002:a5d:9404:0:b0:774:8b28:6c34 with SMTP id v4-20020a5d9404000000b007748b286c34mr16293533ion.8.1687361881753; Wed, 21 Jun 2023 08:38:01 -0700 (PDT) MIME-Version: 1.0 References: <000000000000cef3a005fc1bcc80@google.com> <656cb4f5-998b-c8d7-3c61-c2d37aa90f9a@I-love.SAKURA.ne.jp> <87353gx7wd.fsf@yhuang6-desk2.ccr.corp.intel.com> <20230609153124.11905393c03660369f4f5997@linux-foundation.org> In-Reply-To: <20230609153124.11905393c03660369f4f5997@linux-foundation.org> From: Alexander Potapenko Date: Wed, 21 Jun 2023 17:37:09 +0200 Message-ID: Subject: Re: [PATCH] kasan,kmsan: remove __GFP_KSWAPD_RECLAIM usage from kasan/kmsan To: Andrew Morton Cc: "Huang, Ying" , Tetsuo Handa , syzbot , syzkaller-bugs@googlegroups.com, Mel Gorman , Vlastimil Babka , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Vincenzo Frascino , Marco Elver , kasan-dev , linux-mm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5E1DC100009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: uc7j8p19irm9ku8wib197rz4ib1dksrz X-HE-Tag: 1687361896-64884 X-HE-Meta: U2FsdGVkX19cgOtaGMmm+HBAPAw/Io1yfojhVUTJbK/AyuhZzgo6OYFbR8/JbixpIf5Z7zDJLlNu1NpkCYeNEDSpaIb4iO4eT40iZuUiwLANKHZGhrTNkskBE1WSqA4y8tyAj5fA7fevs5do6eJrA/VxkliKzX9RI9dyhSrXdZ5RiNfFYc+U4un6wHawQqPDEsOpnhTrlL+z9EYC+C0VT0moo/+o77TZdw2Zpn2FlfIyWA68sn7Rb4hZsw6VkSb8qfRrxst8toLVYHedHMrb8CV/ewkJZE1e7IYGe0QIcIyVLWfIyn9uFNeWcH5uT6HParRHv+TaLrZtxQ6/ylkfuqDQ0cQJO8iY8bl8zk053A2b3GP6XO1wtKojxgLLBtUkDTsDSnxIh6DrNojbPvFIXcrox6fOsjhBXFdC4dU3PnRx/YV2h4vOgYfgLmUqcB3qCcAPQmPsr5GwyRKIeD8ARFEb07XsTJgU2OvfKYzpRH3kpkaaXdpm7vL0GAU1za9Mu/OrsKXOsB7+m+hOuFCrIXvdrIzEh/28WpzkD6xbzJnFeHZUlMk3vIx8gH70duwEg5jEWtS5ZGZ1Yctk4W+PN8XSKOxw7dhGSQhzCf0ry0/W+JQbeAXOS5DhJ3/RhXP7s4eLqixCHO17JUps6vt+EVoNtdfIfxtWdMkFOXAOePAlerMyXLZEmG0ozd9miMkQ0z4ZK4KmUGAe1eSclPdCQw77+uunkcEx3M89YYfHK4XSkQ8ncA9ZJSWYTBMVSRqJey75X5gcaK+WpZgKmuLJA8hJS9UpLrE3IqGW7d8JWcYut90U2hM3vH40T0dxYOXo9RMGft8TVw0+kOx/oNpKzmTQ52J6Kd9v+GAffWZ7MCtiWe8NGFkpMSYCUsc+Ck1peNoHKS49WkZlWhDRdlgLRDsMc8D1ohBkWFInyAkzJ/Gg73SbaRp4pG+1s5jnCj2XoYsYj82O/cL+ZXt5ePh ay3mXppV S+1Cb2rKScsOnEJNiG2SAzIJ7PsgchKyFr5AT8dICRDBWGgxQCAOTVIhKSJz7/wFYpL7X5uYl1xEfnGD0OQUQD8MkoLFJ6UIZnKeiqq2bvB4geGrzCh4eKLQFtijy5yTW8ANKcnLhGHlMdwkaAM4z3m81+b++rDJBoSF/+FRmEIcP/WSkKht8kGoYG1P8wUccK2uESRVnjGxRSTAT4w+L838s4eRCEZc19kpQWgCBX0zHAngECi1AYEkbMpm0BuFP5+vYKmjVSP2sFsaqQ6El82FOVY/Vs/wC5BEvExDxuIPlVU66osRU98Geiw5AahrhjP8KHQoAQj2VvY2dxDndRcJnqji8WvDvLpa33BSDH40ckmR7asye+Rav6pvty2BvnntdKC5JeLXPedOsEr9607YqGG6B1grh1jca4eZd2w9X3kdDDREFxobR/lR16HGNJNufOEkmNjZAgFZVlJp8/X89JsU3REXqogsFywcJoqyPKY2BUJsXAKZ4leqF5c8NSYLn9DvmRwT2dw+dESQFjDzQnzH6frpAyswQb8jHjNTxcfXSAwHzsMbL7niH00i8ir8cPMj6NqXeTdPNNarlR9mPAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 10, 2023 at 12:31=E2=80=AFAM Andrew Morton wrote: > > On Wed, 31 May 2023 15:31:53 +0200 Alexander Potapenko wrote: > > > On Mon, May 29, 2023 at 3:08=E2=80=AFAM Huang, Ying wrote: > > > > > > ? Handa writes: > > > > > > > syzbot is reporting lockdep warning in __stack_depot_save(), for > > > > the caller of __stack_depot_save() (i.e. __kasan_record_aux_stack()= in > > > > this report) is responsible for masking __GFP_KSWAPD_RECLAIM flag i= n > > > > order not to wake kswapd which in turn wakes kcompactd. > > > > > > > > Since kasan/kmsan functions might be called with arbitrary locks he= ld, > > > > mask __GFP_KSWAPD_RECLAIM flag from all GFP_NOWAIT/GFP_ATOMIC alloc= ations > > > > in kasan/kmsan. > > > > > > > > Note that kmsan_save_stack_with_flags() is changed to mask both > > > > __GFP_DIRECT_RECLAIM flag and __GFP_KSWAPD_RECLAIM flag, for > > > > wakeup_kswapd() from wake_all_kswapds() from __alloc_pages_slowpath= () > > > > calls wakeup_kcompactd() if __GFP_KSWAPD_RECLAIM flag is set and > > > > __GFP_DIRECT_RECLAIM flag is not set. > > > > > > > > Reported-by: syzbot > > > > Closes: https://syzkaller.appspot.com/bug?extid=3Dece2915262061d6e0= ac1 > > > > Signed-off-by: Tetsuo Handa > > > > > > This looks good to me. Thanks! > > > > > > Reviewed-by: "Huang, Ying" > > > > Sorry for the late reply, but maybe it would be better to mask this > > flag in __stack_depot_save() (lib/stackdepot.c) instead? > > We are already masking out a number of flags there, and the problem > > seems quite generic. > > > Tetsuo? Reviewed-by: Alexander Potapenko Andrew, please accept this patch. As noted in the other thread, no changes to stackdepot are needed. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg