From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82305C55186 for ; Sat, 25 Apr 2020 09:46:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4043C2064C for ; Sat, 25 Apr 2020 09:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EZjWpBgr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4043C2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D80B98E0006; Sat, 25 Apr 2020 05:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D093F8E0003; Sat, 25 Apr 2020 05:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF8888E0006; Sat, 25 Apr 2020 05:46:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id A38DF8E0003 for ; Sat, 25 Apr 2020 05:46:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6453B181AC9B6 for ; Sat, 25 Apr 2020 09:46:14 +0000 (UTC) X-FDA: 76745896668.25.book52_8dbb2a1100423 X-HE-Tag: book52_8dbb2a1100423 X-Filterd-Recvd-Size: 5365 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sat, 25 Apr 2020 09:46:13 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id r26so14497760wmh.0 for ; Sat, 25 Apr 2020 02:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2iaivncLsEUns/Baq4Do1hLy+CwEfNazpNO/+x+vUuA=; b=EZjWpBgrHvoJllioaqTvz8VYrDHr7fWJ+zGlxT1XRTK0pMk3C7uESfZtEhBrVuQsuB mAtdDW5ermGx6O8y81QqwQu8YNOIXeawPYcqorOHSqtFLFvEk5Lky3TgI+ayjdM38wXd 2lMb+fx9z05zm7GF3+q2ASnhLZuZLU3Gm+Op2bj/0+gIkSFITw5aZ7EyZw9g/p0Wr5vX p/wsC8gI43H62neMsskUC/ty0fkA3h+RrVWpmpcdx5BRcFn7kwAKF0RNHB20y60x0G3c MQd7LwQ5oh3vbYMEXzfesKvsyaXsXrjcMW9ad46iCrJSH0UAlko9G9q1DhMfv+7jUcFw bx7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2iaivncLsEUns/Baq4Do1hLy+CwEfNazpNO/+x+vUuA=; b=CHmWIn1aDaoYBYqX3zrjgoSiQK0BvKG2tTmgGIT/8knkY7mWBg0zDr5i5vWXTMeWtb CJEpiFbVPIAYiCp7EOr+fll9eSnnD/cB/+EA8A28XDltdTW2OqfJZXzUrPBRTWbryzca Zr0I5iLLE8oCAHE5wv4grT7VAQYOY/+Zf3ajdb4wsS+nD4UVZPbCjrzRI2LPyVGaZDqZ Y3qjeoeaKU1N/5L7p8YvXHwNvUE0HkFo03LJnFdqieR7h9csZZZ1/dqkL59/d2LubYaF KmfaBI3h0lOKkAhBtSN02cR4/V1TnFOYLqHy5VCZZXt/z7LLsIY2Cvx+gPZ1ra3TiPMx ZVWg== X-Gm-Message-State: AGi0PubZ17R8owfHmUU04KHZBeN+JfFLRhPWvnf1QZ/iONs0vatsTTzH SXNhqo6uHHN0U3713a3cQEhVM9Rnq3GtYWWPaDuHWw== X-Google-Smtp-Source: APiQypIssHJJdDypENA00WXPCmISYA2uy60OOIipQpwfyFImKTo5SOpiTl0gb+u28DMnk0JH4ONQJumbJwyXwtK5q7Y= X-Received: by 2002:a1c:6787:: with SMTP id b129mr15847657wmc.165.1587807972578; Sat, 25 Apr 2020 02:46:12 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-10-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Sat, 25 Apr 2020 11:46:01 +0200 Message-ID: Subject: Re: [PATCH v5 09/38] kmsan: stackdepot: don't allocate KMSAN metadata for stackdepot To: Andrey Konovalov Cc: Andrey Ryabinin , Jens Axboe , Andy Lutomirski , Vegard Nossum , Dmitry Vyukov , Marco Elver , Christoph Hellwig , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrew Morton , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Petr Mladek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik , Wolfram Sang Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 23, 2020 at 9:22 PM Andrey Konovalov wrote: > > On Wed, Mar 25, 2020 at 5:13 PM wrote: > > > > We assume an uninitialized value couldn't come from stackdepot, so > > we don't track stackdepot allocations with KMSAN. > > > > Signed-off-by: Alexander Potapenko > > Cc: Andrey Ryabinin > > Cc: Jens Axboe > > Cc: Andy Lutomirski > > Cc: Vegard Nossum > > Cc: Dmitry Vyukov > > Cc: Marco Elver > > Cc: Andrey Konovalov > > Cc: Christoph Hellwig > > Cc: linux-mm@kvack.org > > Reviewed-by: Andrey Konovalov Thanks for the review! I figured out we don't need __GFP_NO_KMSAN_SHADOW anymore, so I won't include this patch in v6.