From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBDF9C4727D for ; Thu, 24 Sep 2020 11:47:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38BB7238D6 for ; Thu, 24 Sep 2020 11:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TqfH7ms/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38BB7238D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8097C90001F; Thu, 24 Sep 2020 07:47:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BB5C900017; Thu, 24 Sep 2020 07:47:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6817B90001F; Thu, 24 Sep 2020 07:47:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 5202E900017 for ; Thu, 24 Sep 2020 07:47:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7D502180AD802 for ; Thu, 24 Sep 2020 11:47:41 +0000 (UTC) X-FDA: 77297780322.01.grip55_44010d12715e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 53C2C1004DAB5 for ; Thu, 24 Sep 2020 11:47:41 +0000 (UTC) X-HE-Tag: grip55_44010d12715e X-Filterd-Recvd-Size: 4597 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 11:47:40 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id x23so3204043wmi.3 for ; Thu, 24 Sep 2020 04:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gen+1cfeiOVlze5PT7LGWC4Io/Jy9zJpWLjYnIvdBUo=; b=TqfH7ms/kwOFy3YTgEn6UqG4brHkQnjy8aBZKTbxHkbSxe6JG6g0MkBGQNhA+tdZvR Wc4gr8CVvLBkf87fYMzPxzVW/UgWr6VgBNCsZbtokIx8fjt8Kwqczd5qf1YvYamucjuQ NlDP42JVeL/9yurovMfouUcI0uZsKT1jrxk1HunQohITz+j9mwWPDqtzAqnHQxQSuctr 0Na+JMknAlwuJsSpsZEnLUSHrVBSuPv674aqJdq20IKnA7rd7fMFdvLqmRfsBq2deV0m 3kY2VwGlM6yZ+VeZoYDSeETpKInsKH9X+S7dgsDGIETRa0fgU+JKButY361X6OTV/S+0 R6sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gen+1cfeiOVlze5PT7LGWC4Io/Jy9zJpWLjYnIvdBUo=; b=kfW7gr5yTFUQ+i7aS4MzUZNcvv6w7eaq0NKsdD69zncRwevwgxxwfZ+3JRt/q5n15o UW6eEiVaNCXOmSV/UkbD4c/Y7p5cAv/b5KYJY28M4oLwZm4jjFkJRuNAifDJ5/Hj11Ye Y5vdp47qt6hTIuF4W1RS5KpLMoaY9blcCdW4SgF1ZhkO1nCgfHiq4evmurwGwzf2byNQ L6S69CoIyBQKpJ6iTLTSeqvKUMpA1KpJxoahrfMpA+DqBfPTHYuGCCx0g6MWjRyfHbXK xZlJrQOk36UPudm/IzSAhJ58VDMDcVwH15pzSjnKWpS5FWmmAWlZ6eN9vCRY0tpNZy97 1+4w== X-Gm-Message-State: AOAM531DZt0A+oHqO+hzIGR+BLPBjxzjZ9Ry7/l6o5eYOxg++r7deZfi /fW7ktqv11VV4t1TVXhBWl676CXUuXXH6n/rMDqqPQ== X-Google-Smtp-Source: ABdhPJzlAB1LaKS3vVnOhteN+LKInSJ3iqRi3Bi3sbvOZu3M59dlgKL3UiNjzSfzCIOJabK/i1UMh2XSl+c0rvu4m3o= X-Received: by 2002:a7b:c749:: with SMTP id w9mr4067938wmk.29.1600948059478; Thu, 24 Sep 2020 04:47:39 -0700 (PDT) MIME-Version: 1.0 References: <20200924040513.31051-1-walter-zh.wu@mediatek.com> In-Reply-To: <20200924040513.31051-1-walter-zh.wu@mediatek.com> From: Alexander Potapenko Date: Thu, 24 Sep 2020 13:47:27 +0200 Message-ID: Subject: Re: [PATCH v4 3/6] kasan: print timer and workqueue stack To: Walter Wu Cc: Andrew Morton , Marco Elver , Andrey Ryabinin , Dmitry Vyukov , Andrey Konovalov , Matthias Brugger , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 24, 2020 at 6:05 AM Walter Wu wrote: > > The aux_stack[2] is reused to record the call_rcu() call stack, > timer init call stack, and enqueuing work call stacks. So that > we need to change the auxiliary stack title for common title, > print them in KASAN report. > > Signed-off-by: Walter Wu > Suggested-by: Marco Elver > Acked-by: Marco Elver > Reviewed-by: Dmitry Vyukov > Reviewed-by: Andrey Konovalov > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > --- > > v2: > - Thanks for Marco suggestion. > - We modify aux stack title name in KASAN report > in order to print call_rcu()/timer/workqueue stack. > > --- > mm/kasan/report.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 4f49fa6cd1aa..886809d0a8dd 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -183,12 +183,12 @@ static void describe_object(struct kmem_cache *cache, void *object, > > #ifdef CONFIG_KASAN_GENERIC > if (alloc_info->aux_stack[0]) { > - pr_err("Last call_rcu():\n"); > + pr_err("Last potentially related work creation:\n"); This doesn't have to be a work creation (expect more callers of kasan_record_aux_stack() in the future), so maybe change the wording here to "Last potentially related auxiliary stack"?