From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1404EC19F28 for ; Wed, 3 Aug 2022 09:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A30528E0001; Wed, 3 Aug 2022 05:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E7916B0072; Wed, 3 Aug 2022 05:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A67A8E0001; Wed, 3 Aug 2022 05:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7ABCA6B0071 for ; Wed, 3 Aug 2022 05:44:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4140B1A146A for ; Wed, 3 Aug 2022 09:44:56 +0000 (UTC) X-FDA: 79757797392.11.1F5B41D Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf28.hostedemail.com (Postfix) with ESMTP id 7DFEEC010A for ; Wed, 3 Aug 2022 09:44:55 +0000 (UTC) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-322b5199358so163376407b3.6 for ; Wed, 03 Aug 2022 02:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=Y5TvyICc8d9t41nnsu7puTvMuWTSp2+6bN2hR6XdoD8=; b=FPrKKTFmIIrhXCK1a8bx0Gn0ZQdsswBQaJ6AcU4bdHhAv3FjPdWHeD6gFyulCFqoQf 8Ev6qu/iHol/CbvKBcjHgoIJRJzq3MUTFoZsXmwDMcsi+Qzb+ioohmiHkQMiO584Xqcm 3ufSvymy+GTp+Z/M7xxzl41Pr+8hzIqnNyWpVZwIQQnS8NGGru1KNkQquKQ9DH8ODztz nLkMaxwXBlaAiLiX+04wqiuxR8hikX1dzbdwP4lQQX314JMeqfcI9MDPPXug+QfyppfG a6grl/lOUGAxn6LNav8AW61Kc4S7JUpJqkDasX1rVL7l1cRykE+XrDWarl+uwQVvWPrv xvlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=Y5TvyICc8d9t41nnsu7puTvMuWTSp2+6bN2hR6XdoD8=; b=lb7bRZP8U4i/0gG0OUvv0dNC9KEct/lwFniVFc4yMa8bcnicMsI3f01fClj+ElIx0l 1DMvtyEEcLBkdNf9nHxvn/99zrsoBenPFM9VxCqiLodOE58i/rA/qRF2qrF+LfAkRx5o Nylklm8GxDrf133eI9YUDt88iWX+DUScpxzdr3UR18zfdI9ZKAc3QKdbRCiAwHirzNcG vOuC9FKB9D4Drx+UB1VGNy8QTYmwfyZiW+x7yBk9W+p2NTaGe0SUXOIN4XX5RwZdi6Fx vrL66qEPyLLxsRLXDTpBEGUFtwrWkxAyVMcs+ESD6T6bBU9fCgDHvdwg1lnDN9kWDt4k TeSg== X-Gm-Message-State: ACgBeo3goexo2kuXfOPYCqM7nzY/510QURBI4vR/qR1SXU8P48tnXMPN MBr/UXgzdqHQQqNkFPFI+YYRiLmoD0QfVEiLykmrjA== X-Google-Smtp-Source: AA6agR5d01Pm6wu3vbijZCaWwzO5G1sfm5AIHiHcJvlQ6r93IvYqNVc/zAhJ9di6/dSYm6ZI88xapY6TE2XXsAWQ/Ms= X-Received: by 2002:a0d:d40d:0:b0:322:d4c0:c6f6 with SMTP id w13-20020a0dd40d000000b00322d4c0c6f6mr23100302ywd.428.1659519894650; Wed, 03 Aug 2022 02:44:54 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-11-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 3 Aug 2022 11:44:18 +0200 Message-ID: Subject: Re: [PATCH v4 10/45] libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE To: Marco Elver , Dan Williams Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659519895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y5TvyICc8d9t41nnsu7puTvMuWTSp2+6bN2hR6XdoD8=; b=5MSxVdM/tfWRcushg6E3CcImk1cURZNzDxuE58S8woXJ7Qxgw+wzWL/g5UA5iLl2BBv02E QGHusKNzy60GlxwNauUOdDqirQkW+eAxg6VFB4CVVPnEP7nRbw3el6uQNTshq0dgbiqKkY UjFj2+NpH6kCX+eZjikRxn6vbuVfwBk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FPrKKTFm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of glider@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659519895; a=rsa-sha256; cv=none; b=QgANnhb6ELwODGTz73t4Vk822um7drBpK1Wb0maXxXmnQVQHPYeqzthI51gjKyCnoAOCer fcp5TG8HM3s8rQ94XevgNoYrFjt+MCsptPlFHJenFlh2KelAuiFwQLnptrqMSkgR3wKvdx K7amKp9Vi3QdzEqN38e/vvraePU1pDk= X-Stat-Signature: g8x4ic5awccmditax9m79dyfrxp4p6kk X-Rspamd-Queue-Id: 7DFEEC010A X-Rspamd-Server: rspam01 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FPrKKTFm; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of glider@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=glider@google.com X-Rspam-User: X-HE-Tag: 1659519895-46100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (+ Dan Williams) (resending with patch context included) On Mon, Jul 11, 2022 at 6:27 PM Marco Elver wrote: > > On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrot= e: > > > > KMSAN adds extra metadata fields to struct page, so it does not fit int= o > > 64 bytes anymore. > > Does this somehow cause extra space being used in all kernel configs? > If not, it would be good to note this in the commit message. > I actually couldn't verify this on QEMU, because the driver never got loade= d. Looks like this increases the amount of memory used by the nvdimm driver in all kernel configs that enable it (including those that don't use KMSAN), but I am not sure how much is that. Dan, do you know how bad increasing MAX_STRUCT_PAGE_SIZE can be? > > > Signed-off-by: Alexander Potapenko > > Reviewed-by: Marco Elver > > > --- > > Link: https://linux-review.googlesource.com/id/I353796acc6a850bfd7bb342= aa1b63e616fc614f1 > > --- > > drivers/nvdimm/nd.h | 2 +- > > drivers/nvdimm/pfn_devs.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h > > index ec5219680092d..85ca5b4da3cf3 100644 > > --- a/drivers/nvdimm/nd.h > > +++ b/drivers/nvdimm/nd.h > > @@ -652,7 +652,7 @@ void devm_namespace_disable(struct device *dev, > > struct nd_namespace_common *ndns); > > #if IS_ENABLED(CONFIG_ND_CLAIM) > > /* max struct page size independent of kernel config */ > > -#define MAX_STRUCT_PAGE_SIZE 64 > > +#define MAX_STRUCT_PAGE_SIZE 128 > > int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, struct dev_pagemap *pgmap)= ; > > #else > > static inline int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, > > diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > > index 0e92ab4b32833..61af072ac98f9 100644 > > --- a/drivers/nvdimm/pfn_devs.c > > +++ b/drivers/nvdimm/pfn_devs.c > > @@ -787,7 +787,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) > > * when populating the vmemmap. This *should* be equal = to > > * PMD_SIZE for most architectures. > > * > > - * Also make sure size of struct page is less than 64. = We > > + * Also make sure size of struct page is less than 128.= We > > * want to make sure we use large enough size here so t= hat > > * we don't have a dynamic reserve space depending on > > * struct page size. But we also want to make sure we n= otice > > -- > > 2.37.0.rc0.161.g10f37bed90-goog > > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg