From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F04C43461 for ; Thu, 17 Sep 2020 09:51:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4524020770 for ; Thu, 17 Sep 2020 09:51:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G2R7ulBT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4524020770 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9255F6B0062; Thu, 17 Sep 2020 05:51:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FBE16B0068; Thu, 17 Sep 2020 05:51:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EB4A6B006C; Thu, 17 Sep 2020 05:51:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 69C5A6B0062 for ; Thu, 17 Sep 2020 05:51:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2AC74181AEF23 for ; Thu, 17 Sep 2020 09:51:33 +0000 (UTC) X-FDA: 77272086066.19.pull70_020ee2c27121 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id F36F71AD1B2 for ; Thu, 17 Sep 2020 09:51:32 +0000 (UTC) X-HE-Tag: pull70_020ee2c27121 X-Filterd-Recvd-Size: 4972 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 09:51:32 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id z4so1353772wrr.4 for ; Thu, 17 Sep 2020 02:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1z0Dzoz+hRHyGT5fLUrVWCjo5PxPXHMObR+QlG59yhI=; b=G2R7ulBTU9c5dYXtC3MYccrDA+Ffcx8heJQxw6ZGWY0f4Jf/wKoCDPwFEJdPQjqJY7 3hJgJ6hVTXPVmQENRP7Sd81Q78EXP1mZlytu3a3+Sdl1VZr7D5mqqfDcRbWRhKlZhjaM 1/lUceDIrEzfG75yh9QwFu3x24GH6fu1csNQboGJ8TZc7Onv6MTafL682UNedHWLHoPb loIDKYpSlWYPPDFE6D0n89acqNQtqzDkJSfX3uDPdeO9OgG1J5VUGDLsei4BTMfN8UVW bBuNjg0zDtYDRoDh3jrGHaRvvAyW64d3s/v/NGlSIid8oAAthGBjywiebwB0Nbn4Xz17 3udQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1z0Dzoz+hRHyGT5fLUrVWCjo5PxPXHMObR+QlG59yhI=; b=dDLTBTpPv3eJU2ismzNwN9EtZBSCN9ecTTXFvfZKurDxA2zAApmUexRjBoMEFDcCu9 TVnXs8+VaoaHAb1q9ufHV2RKShubnmc8q//m88FjXHuvzBInH0/oiL/BTfwKkW/6a5z6 biCL/slFEgf6wbCpwmdFoKBVQobCVJ+vP7EVvNnKvlVS3eS4hjBAB3LStxHVAwtqnT5m Wkk39JKOHwPAlj1RVuuIwEbFZQC5b0gGlh/8OkepP3+CC1UMSzFd1zP4pgibAXPNmV/K YdvjVf+iN5Km0pV99P60WCHhLe0S1TGoE3maZhWi7oI2JL8Xd1DR4Ucg+daZmTg5k1m2 NJlw== X-Gm-Message-State: AOAM5325NfAAILaz2tgp0Wbe1EXJkIEWQmuoO6Ip4x2rCTOrbiB2q1g3 gNpaqf9xWjwG/zMSvpmlsyF3ni95SPsXE8QQiaLG7Q== X-Google-Smtp-Source: ABdhPJxp3caZkciDO+kZlUmnf4BVgA4nM2LwzCMfmtO8IXe8l0MGsqh3S+LXbtGEI7UMy2c4M0H9WHgAwQUzzWRYWQQ= X-Received: by 2002:adf:e312:: with SMTP id b18mr8525505wrj.372.1600336291198; Thu, 17 Sep 2020 02:51:31 -0700 (PDT) MIME-Version: 1.0 References: <20200915132046.3332537-1-elver@google.com> <20200915132046.3332537-6-elver@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 17 Sep 2020 11:51:19 +0200 Message-ID: Subject: Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB To: Christopher Lameter Cc: Marco Elver , Andrew Morton , "H. Peter Anvin" , "Paul E. McKenney" , Andrey Konovalov , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Dave Hansen , David Rientjes , Dmitriy Vyukov , Eric Dumazet , Greg Kroah-Hartman , Ingo Molnar , Jann Horn , Jonathan.Cameron@huawei.com, Jonathan Corbet , Joonsoo Kim , Kees Cook , Mark Rutland , Pekka Enberg , Peter Zijlstra , Qian Cai , Thomas Gleixner , Vlastimil Babka , Will Deacon , "the arch/x86 maintainers" , "open list:DOCUMENTATION" , LKML , kasan-dev , Linux ARM , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F36F71AD1B2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 17, 2020 at 11:40 AM Christopher Lameter wrote: > > On Tue, 15 Sep 2020, Marco Elver wrote: > > > void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags) > > { > > - void *ret =3D slab_alloc(s, gfpflags, _RET_IP_); > > + void *ret =3D slab_alloc(s, gfpflags, _RET_IP_, s->object_size); > > The additional size parameter is a part of a struct kmem_cache that is > already passed to the function. Why does the parameter list need to be > expanded? See my response to the similar question about the SLAB allocator: https://lore.kernel.org/linux-arm-kernel/CAG_fn=3DXMc8NPZPFtUE=3DrdoR=3DXJH= 4F+TxZs-w5n4VuaWKTjcasw@mail.gmail.com/ --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg