From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67069E95A8E for ; Mon, 9 Oct 2023 12:16:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 082818D0074; Mon, 9 Oct 2023 08:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00B948D0031; Mon, 9 Oct 2023 08:16:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15188D0074; Mon, 9 Oct 2023 08:16:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D069D8D0031 for ; Mon, 9 Oct 2023 08:16:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADC74B48CF for ; Mon, 9 Oct 2023 12:16:04 +0000 (UTC) X-FDA: 81325819848.07.7EEA809 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf16.hostedemail.com (Postfix) with ESMTP id D8F93180026 for ; Mon, 9 Oct 2023 12:16:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="y080/5hI"; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696853763; a=rsa-sha256; cv=none; b=GQVUUN9G+RnCsARNbR/nDYSr+83fddhvPgU4r+qCujnP10hOXQlHdnsxfEnAaklGQXJinY osOJA+zIL8aXbRQscFSQvabGnuiOwrlcoFrLzsx0UusoC5xHAFTrUmSUm2uMiCebm/qgQA kxZJgj1ZcH2eMXwqO6eFaKX0fa/gcpg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="y080/5hI"; spf=pass (imf16.hostedemail.com: domain of glider@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696853763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iw95tEeWB9saYTjeuqfwDCk67AfASMwamONQ4Q2lXGY=; b=nWCkeTmIuqgG2XvDozfJFxcpwLy5pL1KVmxfFPsx/SYze01Y5mpaDRTKHHqThIcW2FY8yY 3OJVHjIwZ7WB+l1ZWsWyP0UtsjzewCJoEtJJ+X3jb4Nl/aFClRWSQACrz81FdArBcWoyYf pzxL+KeMHPJskE1lPSFUO6RHGXTuof4= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-65afd746330so27322956d6.3 for ; Mon, 09 Oct 2023 05:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696853762; x=1697458562; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iw95tEeWB9saYTjeuqfwDCk67AfASMwamONQ4Q2lXGY=; b=y080/5hIcG2U8E9DrAVZqcct8VTbRohgUDGT9ZIZatcagyp0VuQ8ejI1eX+Dp7jaYE UHyoMmuHcKwR4Q4nsaoO2MZ3dMD3DHHhP0YPL19OMI3qZLJtGtHC3hkp0m6mAMWfgfKN w31I3NIBLiFlYuye8aQwdOsTLfDOv8+H9qLOT8XZ37aYzRfudYJkglEWkgFNnJPPF1bu jqggjcR2iZU2RJLOecke0y7m7zyfgt9hVNBpvmbar8r/lsIOv+P1yn95SEEBjbz/MgJp SinBX5i+KuPC2Llc5RkztYksEytInJD7hmPVdvpxFsRolCMC8DqjYfqQWnR2G8IC5Sqq 7X5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696853762; x=1697458562; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iw95tEeWB9saYTjeuqfwDCk67AfASMwamONQ4Q2lXGY=; b=i2xv5xrWK+eSAAvtu8l/JzI9WLsKMCNwAlPQ5g/GVTlyKJzjIj6G9uQaB38EUON0mt TJZ4sjD+lmI4g1k64KFr1H+Y2Ih9h2mdetsk1B/c0lJHjGioox9oZgjnH8wsPcJztNoL 5N7tqkxK1t3OSsem4biq2O1flxbnpm5LN6nMh/wz8pPbq/agtl6sNo9G5Q9KokU0ePuc LUXp0P/hW/A95FB2vtlj6R7HOMnZXXu9y9dmozjSzKP5tR88EVgRTkcJ3cMwFjhDIWGg 31xwTpfem8xOopPrq1x4kiewBGsYbyYxPYu8RjRR2QoLmQhNr+AdTNS69oj8nRs0PjK7 ZVbg== X-Gm-Message-State: AOJu0YzSQ847wl6bZy8urIy0Xri6CHFa7smXb9lFInLpI5h3fjH/JQUh 8pUmhWDRZRZR4eGbKO6eaFOw7y0TQfHWjh6r8GqygA== X-Google-Smtp-Source: AGHT+IEJxXM/xTsmEX/IkrwKYO8Wl9OBkKBFQveDekw2SADwckQ7HwXu/jVY1YyfS4fU9QTcerTLDfajbJ4m3cRb/AQ= X-Received: by 2002:ad4:55d3:0:b0:641:8b09:98ac with SMTP id bt19-20020ad455d3000000b006418b0998acmr13512054qvb.37.1696853761812; Mon, 09 Oct 2023 05:16:01 -0700 (PDT) MIME-Version: 1.0 References: <20230916174334.GA1030024@mutt> <20230916130412.bdd04e5344f80af583332e9d@linux-foundation.org> In-Reply-To: <20230916130412.bdd04e5344f80af583332e9d@linux-foundation.org> From: Alexander Potapenko Date: Mon, 9 Oct 2023 14:15:25 +0200 Message-ID: Subject: Re: [PATCH v2 12/19] lib/stackdepot: use list_head for stack record links To: Andrew Morton , andrey.konovalov@linux.dev Cc: Anders Roxell , Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , arnd@arndb.de, sfr@canb.auug.org.au Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D8F93180026 X-Stat-Signature: z3pxar3s5oywgxtt4g5p66h91hstt9bk X-Rspam-User: X-HE-Tag: 1696853762-35480 X-HE-Meta: U2FsdGVkX18Cj5JVE5bPBMb3zskRG5+CmAaPj8OOUt4+ln8cUwnPoe4SA7okI7uc1KHw+j1OHgpbYvL4wJjwVCU0ajeltO8Spi+Zy4kcoR169Dh0DDDDXnRFyPgm9fdEmcnQ0TJNi/XhKvyd07MPQQE2Z5R9Z6JjCN3ByMjVwG+H4p1Ho600l6KLW1Mo1ZDfNqh4uYW27yvuQqDKH8fzmlA09iWMG9PjPl0rE5eLAC2oV3YSBd+jv7xdZhBB4kf5Shpy83trV2a88Nk12nVbrYLvRtUIkfZPNBVFNGjQ+x1V5MGOU28VU+VYX4saLdC44F32HKmj3EonYJbwVO7Iktbjs39AtHltS9RAw/HAmCEyFAduRTnn19YRQiHsxSZp/SYOOLxaXO0unfpFXJMvS4nlFtUfK12g+iKtej8GUXAwzz+ItRR7aFF56unFkj5y2yB754aGWRY/1MWrGResrqRdVQDfXdVZZGQ9sxP1W167D4B3A2BAOvHT6UGrB7quRx0gMZPOR8hOL6VKUhqEQCh4NZBAnzRS0g3Zn9AXGgRWCL0h++Qbf+ya/N7MVnaIcazQHbrswR57Y8zmy0wM5OsezF/Rf0FaEopemsikvuZ76czZLBlEKVa5o3mMdC93KJ5ZBO5nwtmPdG6DP4+ZyXWqOVdsOexq+3vApP2jljIFuC7G9whk12Ur9WLFjwI3x4Or9vc+bz8jHVWo4wVIPgfI6QdxXe4O3mFyWpKOy2ya8vRhpNBOgoXVwGDtM+Fr37vRIVzp9ZcR0o1bpPoqFcik0vanmcHyywobJY/Hrq7jTGOBuO1Bo+HMqj2gBa2oqBZIoZp8rJIxqS/iO8daIyxxUrYlIw57v5VwX0r8EPq4Ti4LN4OZYU5AocIc53gwNxClmI7kALORj6mMd7U8ncDQEuNlxkCLyRGmJRYcARIhtukD38Rlnt1xII3KgSncyofF5klUOivy3Rw13LP VpCBfDBM dHNJIQhvjYI3MYLILBzEEwRtVYbvgT22o6/uKWiUAxafXT0AV5y4t+PellTc71313Uf8N8RmeM23kzbIfOehRLuHI2VrWybTQUkBeZX7D5xu55OBegNhfNbMk6DjUmabwdoX4eIPJVgb94FSiVhYbDRYCpkIoRfkWjuxusQy6sSziGo/ypCAtrvSdIUVcGjQJS6CJoO5G8hB0cIqhl16OFr4gUvyPDzYBg2NvOLokaUBbk9tQvi800sZ6MapKU+rOkMBhhudoisZQWvX4mSyEMVzAuDO+ZM+vLN1BaO2V1wYNJSoIzk8ptG2teQxRcJRntBPEgXLiHGjNPie/3J/UFDdXqVOETlEop871f8yq16q0oAwXsOT3wZ4V77ll6hd8lqx8to3hJiGUUqGAhx3XA4B13THBgXqTcvcM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 16, 2023 at 10:04=E2=80=AFPM Andrew Morton wrote: > > On Sat, 16 Sep 2023 19:43:35 +0200 Anders Roxell wrote: > > > On 2023-09-13 19:14, andrey.konovalov@linux.dev wrote: > > > From: Andrey Konovalov > > > > > > Switch stack_record to use list_head for links in the hash table > > > and in the freelist. > > > > > > This will allow removing entries from the hash table buckets. > > > > > > This is preparatory patch for implementing the eviction of stack reco= rds > > > from the stack depot. > > > > > > Signed-off-by: Andrey Konovalov > > > > > > > Building on an arm64 kernel from linux-next tag next-20230915, and boot > > that in QEMU. I see the following kernel panic. > > > > ... > > > > The full log can be found [1] and the .config file [2]. I bisected down > > to this commit, see the bisect log [3]. I am also seeing similar crashes on an x86 KMSAN build. They are happening when in the following code: list_for_each(pos, bucket) { found =3D list_entry(pos, struct stack_record, list); if (found->hash =3D=3D hash && found->size =3D=3D size && !stackdepot_memcmp(entries, found->entries, size)) return found; } `found` is NULL @Andrey, could you please take a look?