From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A743C636CC for ; Mon, 13 Feb 2023 11:40:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF27E6B0073; Mon, 13 Feb 2023 06:40:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2346B0074; Mon, 13 Feb 2023 06:40:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6A406B0075; Mon, 13 Feb 2023 06:40:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A75216B0073 for ; Mon, 13 Feb 2023 06:40:52 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6C0B716036F for ; Mon, 13 Feb 2023 11:40:52 +0000 (UTC) X-FDA: 80462076744.05.3049975 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf29.hostedemail.com (Postfix) with ESMTP id B6B73120019 for ; Mon, 13 Feb 2023 11:40:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="gjzq7/aq"; spf=pass (imf29.hostedemail.com: domain of glider@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676288449; a=rsa-sha256; cv=none; b=ORxLHGODdgxusYfpe4stkirOSnc8MaIBGe6VIx+6015a+k63GOm0BUDSSYC5vyyreF4uUB DqSvXtQyLVGSy8n0OInQR2QHtTI1FbLOahawMBfWbVZJctsry8ZhYpfnEP4RjvbG26RRBm +NRsby/Ujj6GYQI+XaPbbodjv20/rSY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="gjzq7/aq"; spf=pass (imf29.hostedemail.com: domain of glider@google.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676288449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qNo1hAJNIesNvAPFE4VcY9SxxfJ87Kojc4RqWUh0cGc=; b=zBk520d37w+Vl/Sq36lWcVO6TTU//G12qJN405eV4POu2gCvTlSVwlFA6/tAGCnGj3e0Vk sugsHLFC99E7aj7XHkNROJvSDm74VPcXiRPzlDPUbTiz0MvzuCxg2g010f7/ZuKzUNhHDX fuRiugLlhmg1t+UComU1IXpUfUHQb18= Received: by mail-il1-f169.google.com with SMTP id k14so783196ilo.9 for ; Mon, 13 Feb 2023 03:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qNo1hAJNIesNvAPFE4VcY9SxxfJ87Kojc4RqWUh0cGc=; b=gjzq7/aqmFScogW1z3sM+ubzYuBzmPb/CIwZFAnBLdoiB/u1NdufEuhb22tHljQVtQ RDAu/3vsouQRLl4FGGx25O6B8RpKUHV///uMqKKN0boRauftljBnedZOlbfrqxdJwxWw RrBCawHWdLMG2h+ir0rVA/0Edy5D0nk0j/9BZ3GFo4H/fUDxO7K9ilS/qXGxdwvJW5pg BT1jROmbXmkgNduMIu9kMDkIMr7M0Zt9F/9AFa/H0apzxwYB4VFtZAYZC6+5Whyra1MP ivSHXywm935Ma4LuxPdUgs8S6FH2qTMJaA7DQOoGutmM06pbQUywydhfXnPvKdO7rHJ7 LFRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qNo1hAJNIesNvAPFE4VcY9SxxfJ87Kojc4RqWUh0cGc=; b=kA0R/3+ALRs7KHGUvCDyQzZ9vxu4fEFgak6VFW+YmLkCMMglVcbV2IvzSDALNzhIeK dpWWL4dwFM0Qa7/X1FVPNuiMyHirSynEhXSPpr6VrAa3Ec41Pvu9EDravfcedy1wmtuN JHAHhMmJQufrlpTFbHk8g0B37ycw44Wewi7IxPfs01H7k+GC2u3WnmZDh9KoTPddzv5X HOjJTsYfE+Wfqaqe2VzQtoZlYCx+xEuU38dVRzCuduESICASfwnzFTGS7xvYObqzDSQE bSoqZSm/IVdMcQqsfiiQ5nKUQdw9RsV84BkhCEfEwz4yZstD3/RKDGWAZDpufDrQzhFf PSBg== X-Gm-Message-State: AO0yUKVevfVTNrNG/dqiETfQZ3W5MTjEFe/RJcX4xFQ/AF7OXr5sXQrl Bi5C1UP/9INd+DottprRtO/Vn6QlP54SOrT72oPBVg== X-Google-Smtp-Source: AK7set8V6mp8FME9QH/RzAyHSBACV/s/IPVMAFS6yBVqeS0BoFmBk9j6XtDVeToerNuRrE3+u8HD1A2PwltwVeJFlJU= X-Received: by 2002:a92:8e43:0:b0:30f:5797:2c71 with SMTP id k3-20020a928e43000000b0030f57972c71mr13112784ilh.51.1676288448825; Mon, 13 Feb 2023 03:40:48 -0800 (PST) MIME-Version: 1.0 References: <317123b5c05e2f82854fc55d8b285e0869d3cb77.1676063693.git.andreyknvl@google.com> In-Reply-To: <317123b5c05e2f82854fc55d8b285e0869d3cb77.1676063693.git.andreyknvl@google.com> From: Alexander Potapenko Date: Mon, 13 Feb 2023 12:40:10 +0100 Message-ID: Subject: Re: [PATCH v2 15/18] lib/stacktrace, kasan, kmsan: rework extra_bits interface To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: B6B73120019 X-Rspamd-Server: rspam01 X-Stat-Signature: 3dsau8hn7ygsgmqigswotbcq3fy6tjyp X-HE-Tag: 1676288449-585293 X-HE-Meta: U2FsdGVkX1/7lXA/LYl6HwDIQ9PQUGphAyEPiGgJD+2KMoXniR5N67baUMDhlhOBc+/cfLkjSBL6/XcsSZMLN8ZqMBHeLCqdRCRGMkHkXT9SJ9yLS4miK/azjIwgRvVVoL0cvNBYJR6H5/AsT6VdSMjVoXNEz79Bg/QppuYymA49u+8G9ox5sfv6WAemoIeRxWcSyc+LAZL7MkQ3mt7l2vK8iRf6PGyNHQ5gMghouoKNxYRu2D4yYFi/q8KgYpxtyNdZWuvhPHa0vlW/yIu9tX2TLJqhXou5awzF7GUnYDubGwtvvl4goH2sj8pk9L7VDSR0DVA0e5NswhiKhGcHfR09iy2/FP/a/alT9lgIeh/gjqkGca3ITc/P7v9EnxWJ8EHFicSpNPUu6dOBxj9O+JErIoyIMZoL6LpSKr7a7ev6BvDvwodgk1SjPojtd9RbklHtjJxXLExO/MuDBBDNiF+Y2sI6O+CZxgrkW7lAxHSBSxOkKPJeqE18rZrQY1JBJJ5he4vU2TNW/k77Lg/2OeD+sQsnymcMOFhKDCYyWlwYq3LmdGlJkTVFoIaZRJCwXegXpD4/Ac7SkQR73Q1r7GmlBS1js1ZB543NTnTWj6aqwmORCvYbblMcKzT9tuXuTU37xTzgUfhxpuzBgCi0GLKw7THyYoEPR8CJ/n+2Hq+wGj3Hq+7hsmPkIrQBChGUBsvpPadaA+4prb5gkbHKfvnrqwcaK8g8DqrdjjCOlE+dGfI3ZZkZ89MW5oQZZyRZ4N9ioBscidtKjcfdvKpJJkAnar/HP8wzAopJbGYgqOTQnvb4rdK5vArfCJF5/Wd4Y0osZt+d1RG0yOjf08Dc1P42Pa9HLaOeMRXDOBWoO3QzoHWhHxi0uUPXCSsawPmkRZjg1s0pxEoV6+23zk/f6OsI1ij3OakQBeeKZy62nZ3x+n2VGTE1akgkr7GpYWXw0+DJLMINEuTg9yTIhch VGkAHhz0 p5Zq3ut5BcWr87JJ9PDXOeKibvaFOUD/HFum3cTw9kX7kLlTgo9oFTMCAe35i0S40GSvK3zCqDK/yu5l10qpV2ztbGzez/D+CwxZ590Zl13Sa4u6eW4tDAwe8szypIlaalmJeBkDWYFYyygKK43FlVoGFXILL/S9YZBB3G+PbU9bEry7/CcsW2kNRtlkpu+hGyh2EsZv5f3qqtyqcAANnrcOiE/puu/VSvvBytEALdEoC01H9hAfNaMUXVNaU2tPSiqsmlQydo6ZGXcqoJCFc5cczwBVkGPOSv+ZbawpycpLtVD3ShmV54osGoH+Ia3GUN3dssOKgVIe4U8uHZ8xPdFjOxzwerZF6Iqz3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 10:18 PM wrote: > > From: Andrey Konovalov > > The current implementation of the extra_bits interface is confusing: > passing extra_bits to __stack_depot_save makes it seem that the extra > bits are somehow stored in stack depot. In reality, they are only > embedded into a stack depot handle and are not used within stack depot. > > Drop the extra_bits argument from __stack_depot_save and instead provide > a new stack_depot_set_extra_bits function (similar to the exsiting > stack_depot_get_extra_bits) that saves extra bits into a stack depot > handle. > > Update the callers of __stack_depot_save to use the new interace. > > This change also fixes a minor issue in the old code: __stack_depot_save > does not return NULL if saving stack trace fails and extra_bits is used. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko