From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D621C636D4 for ; Mon, 13 Feb 2023 11:26:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A16FE6B0073; Mon, 13 Feb 2023 06:26:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A0736B0074; Mon, 13 Feb 2023 06:26:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8675C6B0075; Mon, 13 Feb 2023 06:26:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 738B56B0073 for ; Mon, 13 Feb 2023 06:26:55 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3DEE11A0CD7 for ; Mon, 13 Feb 2023 11:26:55 +0000 (UTC) X-FDA: 80462041590.08.73CBD8B Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 92747140005 for ; Mon, 13 Feb 2023 11:26:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=VptsRcKp; spf=pass (imf23.hostedemail.com: domain of glider@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676287612; a=rsa-sha256; cv=none; b=vWLCWRO8IJU3NzRrCnFc0PcNk2wxY8PrkACjh5k4IzQuMlRa9Dzyw0pX2dTBuB9oZrnblB QVcTTbzoqvkdoOykdrCTWYVjH8E4aoeqk2yATK0lgTOcckD31JPpZf2ECWz8TactN4rNOv K2F8gms+1/b8wjafcyLiUf+zGM4Z2+8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=VptsRcKp; spf=pass (imf23.hostedemail.com: domain of glider@google.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676287612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AMZ+dV1nC8MEbsqkMnbGLqJoVdn1vA5Cn4dTYfSbU0w=; b=zpFzxObKZ2vJ6V1OLuYTJBpo26JZ6t8wxacuxIKWcPtZgEJAve4uO0TqzaJq3hB0RB+t0X ZO00J8UcvGtS8lo78IypRUKjyXfbzM49ADYgYn1ypLot25jL1Cx2f2kfbDC7juDGzKMmVU toQA/xn3IEifDrpiM+oC9g/HL/FY1Pg= Received: by mail-io1-f48.google.com with SMTP id r6so4344219ioj.5 for ; Mon, 13 Feb 2023 03:26:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AMZ+dV1nC8MEbsqkMnbGLqJoVdn1vA5Cn4dTYfSbU0w=; b=VptsRcKp7YGcyynq1dr4wTNyQ7lCtzL2KOtVfQkXsoFea9+hzXJh3tRWkM/nTRvPn3 9nGJcEEXGKs6t4JC1qxCOArfYqI0KMQZ2O1XNBe1xv7T6/Kk1EV9GSAz7QcGRGRXkIV8 8U9sqsY+0uQhHZuuZ2CQmFw7I9uxjIGZrjWdYqPPwbbja1b8+6Dl68mgCSY+DqZp0FnF xXB8vFhOvmW9z668O+0CgxwF625fZUq4ouHw5hD4aZBNmDT35zMELg3TrHj1MCz4NTZx Q1vV692bdLOMr7CmsEXmzgrMM1+Zu0+ZX3E+rBdRdbO3FpgakaJWxR9XJ8XYSvmWoK1Z C/eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AMZ+dV1nC8MEbsqkMnbGLqJoVdn1vA5Cn4dTYfSbU0w=; b=V3GzgZunDt9gA+spBwYLFnNzMfic2i6ZyshxNRlWAiNOF8AKBhNTKn0F6phkd1GngX RpS4TSplv1YWK94axtj+SReqNyWSi7T8zbAzrQn5aYdcYAj330znLJl63/6Wa/OlaWyY AW24HLq7WXMPQLw/Uz+3qzUnHXapKor6njNFufGzrHYYWVBL/5WsQIbZEyJRuFSzVBcr jSf/ru1hoZD9fk28GbDgN4i9/DfCVAhbTTItoBIumOEX8ml8P5nIrgfskEFvokyV5g0B ryYTi/ZRb+MeRSCuZuaiG/lpUj/eswgxFCYxtsjQqGdzgpouSyVjVYMv5w/52xBcc9MW IK5Q== X-Gm-Message-State: AO0yUKWihALDkC6dGDWmgjWASt8vJVk3J5zejvwXfTAbhwZtNLcjRC1S WRf0BRSVZYZRuPbBbUzBpqAueySc3IDN0UTH/Jervw== X-Google-Smtp-Source: AK7set8zW9LvRliK051KK5j6srceN0dT5sB7oJKViCxiJBQFHh70oldULOIIUHbsspwfnwBThg0SXTm9jwqXex580X8= X-Received: by 2002:a05:6602:3155:b0:732:9e46:de04 with SMTP id m21-20020a056602315500b007329e46de04mr11828525ioy.65.1676287611687; Mon, 13 Feb 2023 03:26:51 -0800 (PST) MIME-Version: 1.0 References: <484fd2695dff7a9bdc437a32f8a6ee228535aa02.1676063693.git.andreyknvl@google.com> In-Reply-To: <484fd2695dff7a9bdc437a32f8a6ee228535aa02.1676063693.git.andreyknvl@google.com> From: Alexander Potapenko Date: Mon, 13 Feb 2023 12:26:11 +0100 Message-ID: Subject: Re: [PATCH v2 14/18] lib/stackdepot: rename next_pool_inited to next_pool_required To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 92747140005 X-Rspamd-Server: rspam01 X-Stat-Signature: yisj35bsz4ef6gw6rpqxrx3bmn9mgu4j X-HE-Tag: 1676287612-114257 X-HE-Meta: U2FsdGVkX1/sYATcSDodAF4lScqABhxsg8pO/8Z/7LcK5XSJg6oxcEEMuPsJtBXMpKjnV0yviUp3LbsP/5qSE7DDWjqIFystKk4iOD41dKhw8VGXrSKlvvuutJMyqR9ci5R9gcCo2vtRCqNyQbROsy7bMiDzzHGAgrh+clQ263g0DRcNnUF5yc5q0rzD8Ob0YQfX7hBha2IMw0QP8e9H1BSZz6Fozr0nOp/wvTHTwTRgBM3AWOZtkUVXnPpFuSSDEbFyo9SWRHtNC4aqGRkS7JtqhMRvoSeKXoukitBOEHif9g2mNtm07als2bl50jgficIwK4VM9ppycB9Kk+ni4sz2j/Q8HCiMChIL87bUhU3+aS+LMG8/Mzs5bEPzDacHrTau6/g7ryq1C1SnSKdQlzfpu5bcZR/xbF4QveALhmoTnpeWHQTCMLyyZiQY+TUs1HTS/MC09K5Ylb3GJlV8HPxCGOBNBDZed9eJJUXJPx0do9UQfxP0eiX1JfZj2Apd/X2npFTox+0fAfgWHKkN1kqTow7uRmibzJi8PBteBx722Kgrh87dI/mHNSvesPu9iXezoLzyF0TPPa6eECU2ss5lDmJQuGUUChwCl/M5Weg96rttEBxpGN9x35Q4Y9u/ZUGtyuKeuns1XQtFo8ugiTVsPverglfniCIYmKAlzYUf4zD8Rgxl+S70gGT4/TI2sgxMYE+9+SwVU9VscBLCU8FVflNbItA2YdY8Y26Uv9qvUOuTCdF8adI5j9ys0AiE3DOGgWBYg0rBP4YdpLpDWznXanApDcOwlqM6Z/qs6ZqKB6Sf5imhAIRMHZ+CjW4iIhoWHdhovG7hl60yAtgeptsnDtqhnl1KIJCZCPAbiTER91b5wlcwgVvosUj2v5PevwVg2/TQrtjIhsLHwh+U00dac+yvlflgqLSGW+ZcZUg5Vga8oZs4ljV7cXyiV4AOSl3Gr3JyU8BoZ1ihEp+ NTfGdzSP wjjIxbkxWqBbJihBvKrGdH9FgCKqoMsX2jxSageIIMk/LebHWQjRQ7y+D/XPVhh6efILP0RALcO3P7yXpnbOGjdMMUMwEClsfkTU8jasnpzN4oAh72j3/uua3BTaolAx+Znk7AHxaD0qaIAZSBdVX77wE5OFkDNfcvxWf3b5STIWcmn1rUNUj07qgGEsTbcK0mXFgXby1BHELQtvYahvCdPlqo+eeI6elcy7jEEqDQaYMTf/+Pfw9IAiSv0ZtS6Hk1LZKeNJGYLSSJIrmrgot2cNs5YCDTNM+f6t2W/lVLyxE9Kmk1DwUht1UOL9qc+KJo9FSYbKI1jvK0HovLzNWmd1ZQUzTS2j4oQ2T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 10:18 PM wrote: > > From: Andrey Konovalov > > Stack depot uses next_pool_inited to mark that either the next pool is > initialized or the limit on the number of pools is reached. However, > the flag name only reflects the former part of its purpose, which is > confusing. > > Rename next_pool_inited to next_pool_required and invert its value. > > Also annotate usages of next_pool_required with comments. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko