From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4DDC433F5 for ; Wed, 2 Mar 2022 17:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CBF98D000A; Wed, 2 Mar 2022 12:32:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5541D8D0007; Wed, 2 Mar 2022 12:32:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CF038D000A; Wed, 2 Mar 2022 12:32:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 26B948D0007 for ; Wed, 2 Mar 2022 12:32:17 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DC9259F301 for ; Wed, 2 Mar 2022 17:32:16 +0000 (UTC) X-FDA: 79200139872.23.9F5BEAA Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C20C1A001B for ; Wed, 2 Mar 2022 17:32:16 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id q4so1851833qki.11 for ; Wed, 02 Mar 2022 09:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pIaLDYhEVyUGyAhkP9rhY6u4SsthLEVULPqNPjpQ14g=; b=rnKI3HVRytWNrxG5YfXu6VmE2U5BO1U9FZuwdbkSmYp5nhxvdOMAkMyG5eqXPMfO2Z GDE4XPBF0quUlX8Zo3utV/rCEV11FQipYylM5ZSbIaJfh/CbJGizalhyrvmCCsm9BYwT 1HM0I9tOh2X8GStzgOlpUoYuQQryoA9c1spB5gFWXwsUFhmMoA6wZOr8aI+PLVR4D1p6 5RSz4wkcjvRkTl1FR7Ov7nfybb/nO2LXwmtCN5AJnx+xK+j9OjvK65rXf/Q3Lx95jsq1 dXEGiHLz6iPKUq46kjOlr4hDa03NAZQ10fmKT8FDlfm3oAbtrGkPrmQQBuQ7I2OqZZoE DxNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pIaLDYhEVyUGyAhkP9rhY6u4SsthLEVULPqNPjpQ14g=; b=z1a0kvutqU3VFcP4S9b4y0zKtCC0SOh7KPLxE6XPv41WZdHlUfCoU08U1AM1FcofIb +3S8/2rW1fKsl/l4j8zHwx741OuwJ3bbWS4RSbRiFhFhmxX9oiAjWAH4F6xRnYrpgG7n 1PUkY0YJ+TG0uJa9hDakpG3fQupMKsD4wVTpkHaYnWHdksq826un+xxopfGVKXTj7Zdv gFl82sdc4PoAcYrKYp1szC+ltoxjPoIq35sbXNGfI+yOTH6xFA6vVOTUhGw93ezQy+E7 xBbNElLP+UWj5sjcmFhEp3oTrbaRlgeT5zk5yJ1QZduKOQAvAZ2IlSquLbtM1LTOu5/S cv3Q== X-Gm-Message-State: AOAM532ZXy9gnM1WqJXMqK1EZ5ULKz0+4th2ZYxQ1TVstH7gZzTzdSs3 /BqHf0NoVSY6/TnY9ciOik/Cnl83atXiy56kBfEF7g== X-Google-Smtp-Source: ABdhPJzLxIVj2Z/fb1ynTBlQw7+rxj5rehLaQqdT+VcBaW8n3A3PW2/jxdkHBOAj/SeZjNmkCRLoAFCDro6PkLHOY8E= X-Received: by 2002:a37:a505:0:b0:60d:df5e:16c7 with SMTP id o5-20020a37a505000000b0060ddf5e16c7mr17131417qke.448.1646242335286; Wed, 02 Mar 2022 09:32:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Wed, 2 Mar 2022 18:31:39 +0100 Message-ID: Subject: Re: [PATCH mm 04/22] kasan: improve stack frame info in reports To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: multipart/alternative; boundary="0000000000009c7f1705d93fa9f5" X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5C20C1A001B X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rnKI3HVR; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of glider@google.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=glider@google.com X-Stat-Signature: fodfjunb9nk41do5utjintmjbofqygw7 X-HE-Tag: 1646242336-196509 X-Bogosity: Ham, tests=bogofilter, spamicity=0.023078, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000009c7f1705d93fa9f5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 2, 2022 at 5:36 PM wrote: > From: Andrey Konovalov > > - Print at least task name and id for reports affecting allocas > (get_address_stack_frame_info() does not support them). > > - Capitalize first letter of each sentence. > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > --- > mm/kasan/report_generic.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 3751391ff11a..7e03cca569a7 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -180,7 +180,7 @@ static void print_decoded_frame_descr(const char > *frame_descr) > return; > > pr_err("\n"); > - pr_err("this frame has %lu %s:\n", num_objects, > + pr_err("This frame has %lu %s:\n", num_objects, > num_objects =3D=3D 1 ? "object" : "objects"); > > while (num_objects--) { > @@ -266,13 +266,14 @@ void kasan_print_address_stack_frame(const void > *addr) > if (WARN_ON(!object_is_on_stack(addr))) > return; > > + pr_err("The buggy address belongs to stack of task %s/%d\n", > + current->comm, task_pid_nr(current)); > + > if (!get_address_stack_frame_info(addr, &offset, &frame_descr, > &frame_pc)) > return; > > - pr_err("\n"); > - pr_err("addr %px is located in stack of task %s/%d at offset %lu > in frame:\n", > - addr, current->comm, task_pid_nr(current), offset); > + pr_err(" and is located at offset %lu in frame:\n", offset); > pr_err(" %pS\n", frame_pc); > > if (!frame_descr) > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups > "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/kasan-dev/aa613f097c12f7b75efb17f2618ae= 00480fb4bc3.1646237226.git.andreyknvl%40google.com > . > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhalt= en haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bit= te wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --0000000000009c7f1705d93fa9f5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Mar 2, 2022 at 5:36 PM <andrey.konovalov@linux.dev&= gt; wrote:
From:= Andrey Konovalov <andreyknvl@google.com>

- Print at least task name and id for reports affecting allocas
=C2=A0 (get_address_stack_frame_info() does not support them).

- Capitalize first letter of each sentence.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Revi= ewed-by: Alexander Potapenko <glide= r@google.com>=C2=A0
---
=C2=A0mm/kasan/report_generic.c | 9 +++++----
=C2=A01 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c
index 3751391ff11a..7e03cca569a7 100644
--- a/mm/kasan/report_generic.c
+++ b/mm/kasan/report_generic.c
@@ -180,7 +180,7 @@ static void print_decoded_frame_descr(const char *frame= _descr)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("\n");
-=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("this frame has %lu %s:\n", nu= m_objects,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("This frame has %lu %s:\n", nu= m_objects,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0num_objects =3D=3D 1= ? "object" : "objects");

=C2=A0 =C2=A0 =C2=A0 =C2=A0 while (num_objects--) {
@@ -266,13 +266,14 @@ void kasan_print_address_stack_frame(const void *addr= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (WARN_ON(!object_is_on_stack(addr)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return;

+=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("The buggy address belongs to stack= of task %s/%d\n",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 current->comm, task_pi= d_nr(current));
+
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!get_address_stack_frame_info(addr, &of= fset, &frame_descr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &= amp;frame_pc))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return;

-=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("\n");
-=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("addr %px is located in stack of ta= sk %s/%d at offset %lu in frame:\n",
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 addr, current->comm, t= ask_pid_nr(current), offset);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err(" and is located at offset %lu in f= rame:\n", offset);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err(" %pS\n", frame_pc);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!frame_descr)
--
2.25.1

--
You received this message because you are subscribed to the Google Groups &= quot;kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to kasan-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://gro= ups.google.com/d/msgid/kasan-dev/aa613f097c12f7b75efb17f2618ae00480fb4bc3.1= 646237226.git.andreyknvl%40google.com.


--
Alexander Potapenko
Software= Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636= M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebasti= an
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellsch= aft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4ls= chlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jeman= d anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und l= assen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet= wurde.

=C2=A0 =C2=A0 =C2=A0

This e-mail is confidential. If= you received this communication by mistake, please don't forward it to= anyone else, please erase all copies and attachments, and please let me kn= ow that it has gone to the wrong person.
--0000000000009c7f1705d93fa9f5--