From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 529CCC43464 for ; Fri, 18 Sep 2020 08:17:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B1D32072E for ; Fri, 18 Sep 2020 08:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="P6hxU2ON" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B1D32072E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C70CC6B0003; Fri, 18 Sep 2020 04:17:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C20366B0055; Fri, 18 Sep 2020 04:17:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC0B36B005A; Fri, 18 Sep 2020 04:17:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 9455C6B0003 for ; Fri, 18 Sep 2020 04:17:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6056A180AD80F for ; Fri, 18 Sep 2020 08:17:55 +0000 (UTC) X-FDA: 77275478910.26.town86_570d32c27129 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 3D4B01804B647 for ; Fri, 18 Sep 2020 08:17:55 +0000 (UTC) X-HE-Tag: town86_570d32c27129 X-Filterd-Recvd-Size: 4201 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 08:17:54 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id m6so4697104wrn.0 for ; Fri, 18 Sep 2020 01:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=336DK+gr8bWeArYbXXeTUATGYeu4M+ZLn03audwBSjI=; b=P6hxU2ONsTj0tWsHoNwvfnSTvSCvHbA8sFwBTqHKDj+/wnfCSR6f37OyiP9P/BGuiY YlR7GkEXKyvELr7ERB7LBUyiwHh12AxmKVKClz5RGWfRg2BXjgtk7XgJq0LRwWJP1DkZ K0mU2vYlc5nfpqFT0BRlX9husFktvYox9/03lY6KbV/CEl7TMnZYCjhQaAh/xhvLqNGA s7vPhWrevFlzWBNBZZmdwJgACoQ7VicfnJrXHzhayBxqnqV9P+hVc2lICKhGOMD0RATj qR9Boez3eP+M1mNPpWfZx1CdNlAtvpyZWFdVQ2ZMmjJexuymGOT8bnRZOmn2BAwIfKto 8EhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=336DK+gr8bWeArYbXXeTUATGYeu4M+ZLn03audwBSjI=; b=IJ4eGN8iGuJUsjOcOBwup0nlMcPi8NUrX14ODcqGTrhQcNfLaWVRXN7/hrvkWWtyn7 XrS2DxJt8/g4aXH0WjjozSmeQLesQHH224dYLir1oixPJJs6JFLu2Fl5EUUXFdJFzvzb gzWFvqaDoz5OS8mpQ6NMsVR+Mt83OtbzWgJogJ41zS8pcfu6MCiCkzyV1bVVZYmRouXf yVhB/ph5vNFS1mMoWLlFOnjJGZJAirPQHVLOo+JG1F33aztbb6mQ/9ympPe2tAxbQ1fT H5a9EydGGsiDZoA34NHMJKEiKZDBn+4tMwbIULSqPVH0KmOIr5EpOwAVs+EXz+/09yXB D2HQ== X-Gm-Message-State: AOAM532fvDj9VqjF1rkAlMg6IiA15OjPH56uMn9l9WxA9Ea6QK2zG41h xIHnW+WHgmo/UH8KnCUUPQ62x+sTp1QKP6bOmGYvaQ== X-Google-Smtp-Source: ABdhPJwVuS5KBOyJsrvk5LUfGguAb+QpQ29tKswCawYdjjDY7nZkbxoog228YB/l/wtYWXDOlxUMcvjxCKk4qsa8ecw= X-Received: by 2002:a5d:60d0:: with SMTP id x16mr35980678wrt.196.1600417073613; Fri, 18 Sep 2020 01:17:53 -0700 (PDT) MIME-Version: 1.0 References: <88c275dc4eef13c8bcbe74ecec661733dcbc67b8.1600204505.git.andreyknvl@google.com> In-Reply-To: <88c275dc4eef13c8bcbe74ecec661733dcbc67b8.1600204505.git.andreyknvl@google.com> From: Alexander Potapenko Date: Fri, 18 Sep 2020 10:17:42 +0200 Message-ID: Subject: Re: [PATCH v2 07/37] kasan: split out shadow.c from common.c To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > new file mode 100644 > index 000000000000..4888084ecdfc > --- /dev/null > +++ b/mm/kasan/shadow.c > @@ -0,0 +1,509 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * This file contains KASAN shadow runtime code. I think it will be nice to mention here which KASAN modes are going to use this file. > +#undef memset > +void *memset(void *addr, int c, size_t len) > +{ > + if (!check_memory_region((unsigned long)addr, len, true, _RET_IP_)) > + return NULL; > + > + return __memset(addr, c, len); > +} > + OOC, don't we need memset and memmove implementations in the hardware-based mode as well? > + region_start = ALIGN(start, PAGE_SIZE * KASAN_GRANULE_SIZE); > + region_end = ALIGN_DOWN(end, PAGE_SIZE * KASAN_GRANULE_SIZE); "PAGE_SIZE * KASAN_GRANULE_SIZE" seems to be a common thing, can we give it a name?