From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A999BE95A96 for ; Mon, 9 Oct 2023 09:00:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4352C8D0022; Mon, 9 Oct 2023 05:00:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E53A8D0001; Mon, 9 Oct 2023 05:00:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF7D8D0022; Mon, 9 Oct 2023 05:00:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1D7948D0001 for ; Mon, 9 Oct 2023 05:00:13 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D9A7D1A018A for ; Mon, 9 Oct 2023 09:00:12 +0000 (UTC) X-FDA: 81325326264.08.E3E9546 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 196C240014 for ; Mon, 9 Oct 2023 09:00:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nZaLy1in; spf=pass (imf17.hostedemail.com: domain of glider@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696842011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8StrU8p4Asv0JzFS3HoyE3rwHET/Hez/P+/rBmMaFtk=; b=myOfsnOPqz6pHltfQGRHldhwzUjEL5mc42Y0XY/dfHDtYjp5k3CwHCPs+7MpIywW7A2zKD pvBi9iRETPapxLt8zxfKYEqOMoaVmKQ5kxIqSj3qmqfFBZy/LE0OlbU7i1OistkySbZM8h 4LqUTC/TEZj5Ze6Lgb7z5hM6l+mEWdw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696842011; a=rsa-sha256; cv=none; b=Whc6b9BfO21TZkWG8w+ReMokoCMw+u1FlbU68D+gogasUa3bGH1l33Xq3Rr8+VCte8r+b9 /OS8M0riOJqBJUIh+VrIoC0s+9dgKMSWNZfoW+/0N+zCZfkWXZf5MB3mXTvvQuBPVOfCRr Lxs4GPODsBb98GWH7/nKWyHwcKJGQnU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=nZaLy1in; spf=pass (imf17.hostedemail.com: domain of glider@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-41954a3e282so24940881cf.2 for ; Mon, 09 Oct 2023 02:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696842010; x=1697446810; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8StrU8p4Asv0JzFS3HoyE3rwHET/Hez/P+/rBmMaFtk=; b=nZaLy1innp86que9ZhSwqQFvrzN7PafI4YKhbWrbb/n2QUGLPMzg6s0RTaiECVqC0p aSzmJ7Zm1z4pYC4FIyVYZzYt5Bu21meCtVVFL20JH+xSdeB4SXgPNeMk09UIbnjPJWe+ Y7pwfGoEwAoepDbscpg20r0/kM6btgI822BxxWYiXfVvR2KFy2l8hDg0mbX0GtlXW6WF vp5+dJL8SG5+uKunUcATyObmNB5SQkpOPMpt+NPzt2vKnjU5i7bW3/828Z9OyFea0/bI JG+s4GksbIxs8qHXcfbdZ/ydAXgvzIsl8MXTiNUdCHxtiFM0tplo6hFDDKvJ4N89UXHl Ua/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696842010; x=1697446810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8StrU8p4Asv0JzFS3HoyE3rwHET/Hez/P+/rBmMaFtk=; b=ZdZJaYnZLqZdHw/B8haq6+eZfrnATei3CEXHsXnn6I+KL5P7uryyCOYWhr2Zbf+tfh HzogFiqcr0ESImlWNY+EZ2EltNnQ0ZtvFL8EbXmb4MW5wQS/FXo3PSo7vwre9RPf7bJP m7O7QkS4UZWRjvD+14/bk3N13Xupu1VXhaZztrlUKL4pjW5u0IR2/fYiYptIiHX5KmPY u3fz6iJPyO3L6yKH8DxqPYt9wuDPoE0zb5trz6FGqdbTI6NC6E2Kuo2qVy4W+f4QZc2S 0JIFXRNMBS9o0aQuzeSfBz0UEtBQwZypZ/7eQyYtqciPIppj+XKthdPgXIcwb3k4e4wj BF/Q== X-Gm-Message-State: AOJu0YxqZSPMNTTvYnfQpWKlTM+uDLzXrZcl2EmdYG5Eiuvt2YKum20J OwyKgC3RBCMUjU9n5g+2snJ9SV4gl6zdTDqx1hP3+A== X-Google-Smtp-Source: AGHT+IEO9YnlbbIOqdKwEE3OmWo5jLqeq552UXapo4KtEfjHfM7n8GwW5EcKPHdmAbvoEv0At44Ln7MPZiLs8ylQ8BI= X-Received: by 2002:ad4:4450:0:b0:65d:56c:5177 with SMTP id l16-20020ad44450000000b0065d056c5177mr13158908qvt.57.1696842010047; Mon, 09 Oct 2023 02:00:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Mon, 9 Oct 2023 10:59:30 +0200 Message-ID: Subject: Re: [PATCH v2 07/19] lib/stackdepot: rework helpers for depot_alloc_stack To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 196C240014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: w5cm6rspjtp3bw63er1t3cpp34kgbnea X-HE-Tag: 1696842010-383353 X-HE-Meta: U2FsdGVkX18VL17ttvEVCBGUqPUTft6rssYpZ+fkeTjpS1BZLKzEC8XochovPjXTGZH6eAfjk95S3a4WaIDZxJEhEzCyac8mnos2VFVTsa6aAWix/Ln36NOyrsiTMF3XnpO0zq5Nd3s8sLGorbzxiV0iNT683BrH0MVi2V1zP74UyNupao2MRge6/QIz6QJqLN6yp4KIzfg/XoqcCPlFBzxM5WhlI6SwNmLphOlEh/uyT5mow7Qr6MEW66PiPpwsLwgxNgb87hQcNRF5MbX/ZaJdftF/xR+AL1C1vs+dHCWGKbfix/HqEYULB1/NHVh3jePz/i6+Pf4NcrGafjebFRkFoBOIfW9L3OMkvAE9rz12qN02sXI7MM/L3iPCek9q/jV8gTt1iOcMdAFMNvcf7Or49lqHLLakHPJ5NtyzGtQqRTF1s5GmYfN0SVZzSqQTk07/oYTTAWj8wC7yk0jH6Tg2kvLdTLD1EmWeFZL0W8oGBmza3DtxuZJBkTJBfoBm4ZcvSyoi4lYEqXvGzGkhBPGyEF/OXtCcTNidtihfjwkPOuJVUuJYwyvOxOE8S/JRKToNLZfZKhoHcEr6iTPbZcD9162NRE0K3KaiejzTy2jFHa0ykwIpKrfa4ovToLIC0r+0OPVoMUP/uOzvI+m81DraeOTUTxHecMrkAy6ex38Vp/rv1s6IoQiSzO78m781qHhmylr4IT3AnzAJhdCUYybPtKC5tO8Eo3Q0R6ifgWjgVqpdqPl2SbGL/QVJlywOKGWoTNkcDarT7oIhRuk29ZAGo4gqv2mBbxYZDAT2un3iYzfyMe+fcGEJTZ+05x3xBjp+y5Lbk98IUw7o6yD1i+EP2JqQ/4sINIsv9o5iq61Y3ZZlfudUrp6gFO6a6TzvyHIcr9C+mSKDAkmNzwvl62mnBqDY1HL7SJCpQU3izaXPHTktA4qXeUtedHppdEcFTgfRK71HxBDR5R6d4N7 FrKlQasL 4PyvOo0xvkQBzPYEBU4yT4XJcex+H5q5warsAag6oUqoZ4+9/BQgZv4JCwJybRYfumSVJXz6jRSBQ/vtUa4FknOuFm3FPEIRr4/OKtEDf6Gy6rbk+s84zVXR8BahCaoOUovRTZuP5BJTUs1ltWujrDu36Kl8ymepnef1OF3QOvIQx1dYzKUQB9gYCzRXA92nwyOaoTOw8ELPJOAto1Y3CuBy8uNNiKZpJzP+0+5ffnm+LjIx+3pNja1vVaTNob5b4DtpKT9xDR8ObnINQb1QbOLH7zl4rcZ5YKRXuJJQkd41NWaogUDwg2mBG+KGMq6L85ULVwS+Wbl1sfGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:15=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Split code in depot_alloc_stack and depot_init_pool into 3 functions: > > 1. depot_keep_next_pool that keeps preallocated memory for the next pool > if required. > > 2. depot_update_pools that moves on to the next pool if there's no space > left in the current pool, uses preallocated memory for the new current > pool if required, and calls depot_keep_next_pool otherwise. > > 3. depot_alloc_stack that calls depot_update_pools and then allocates > a stack record as before. > > This makes it somewhat easier to follow the logic of depot_alloc_stack > and also serves as a preparation for implementing the eviction of stack > records from the stack depot. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko > +static void depot_keep_next_pool(void **prealloc) > { > /* > - * If the next pool is already initialized or the maximum number = of > + * If the next pool is already saved or the maximum number of > * pools is reached, do not use the preallocated memory. > */ > if (!next_pool_required) It's not mentioned at the top of the file that next_pool_required is protected by pool_lock, but it is, correct? Can you please update the comment to reflect that? > + > + /* > + * At this point, either the next pool is kept or the maximum > + * number of pools is reached. In either case, take note that > + * keeping another pool is not required. > + * smp_store_release pairs with smp_load_acquire in stack_depot_s= ave. As I wrote in the other patch review, I think we'd better keep parentheses at the end of the function names in the comments (unless there's a style guide telling us not to).