From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B9BC6FA8E for ; Thu, 2 Mar 2023 14:14:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 835DA6B0074; Thu, 2 Mar 2023 09:14:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E7ED6B0075; Thu, 2 Mar 2023 09:14:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE006B0078; Thu, 2 Mar 2023 09:14:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5CDBC6B0074 for ; Thu, 2 Mar 2023 09:14:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3093BAB2DD for ; Thu, 2 Mar 2023 14:14:47 +0000 (UTC) X-FDA: 80524154214.21.6E66B57 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf06.hostedemail.com (Postfix) with ESMTP id 4F44D180027 for ; Thu, 2 Mar 2023 14:14:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BD98Pver; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677766485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=732b5wP+BowSmRkkbJVoygYQGzzLcyCOL0CaRiRQkbI=; b=hqCi3LyVfChUxxVjXQqoPEKAH+CxvoG3Lca0RpZS4zftxJuX0+boF1XE1jwM643GtS8vzg 6DQxTNSGy7BD1X9rjY5NJ6hLzCx3Kr+bo4GFkiyTrt5EdjyUp9/qTuO/8/Zeabp95bEpcE /nvl6paP64T9uTAlyvmvrMtwO+KvcFM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=BD98Pver; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677766485; a=rsa-sha256; cv=none; b=JkYxN84qpE3H5+CbRFW14FI7Y717p93hoi3ToZffHfpXVhVvZ9oLrDRcs4TUKIXFDKzl+U VE2gLXHaCdbo099lZt88wAUUgg2gQZY4CEa7RlQaEzilGiu1OMqve1durp4lwXFcN+5IfT S50GiICPuj2ILIVH7OYBW5BCoZoXm54= Received: by mail-io1-f42.google.com with SMTP id m22so6382531ioy.4 for ; Thu, 02 Mar 2023 06:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=732b5wP+BowSmRkkbJVoygYQGzzLcyCOL0CaRiRQkbI=; b=BD98PveroswgOLELzmE6VIl8n5CeYoqZMduPI7QJjqPZcji78t1C+pPl48AT3pxbwQ 9YFmNgz7El1VQScoFHzJ/svLim3JH8+fNMBeIIF55REHFVhILd9TYSE1mbWUrmzDjdQX JhCPLu0x1Y4hZ08/PIDJLAdpOulYuSVSbM2l6mrBF+jh3dNYXdwXuyOraXslQv8GB3/U m8YSl6J32I7O/gC5LP8m67dzVO53BpkcVNJtsJ9OEJC80r/DJBvPKmn/0te+GaxLspBC XwAThV+qvJH4tBxFu9ez6RFGYc6hVFwMX9eE5KSnNkwkOqVU1vzNjKS4gJxnZxAhFFCJ zFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=732b5wP+BowSmRkkbJVoygYQGzzLcyCOL0CaRiRQkbI=; b=GtjumcyCPoOSBWvqJxbMGSWYbYgpJ5CvFINWPVCfQpCxfTJTv0KY34KBNhU3KdD3Cc 7Ps5RMWibGPK/e/0AAl1273EukZeppemNz0GVFRhscHtwNss3SKA7FTyGsKpK9in7eoz fsNBlFm8QoqxzVqF1mL3tRzWJixn39df8ZW+K7vnke9bMXlnEFkgkbYGIrkHgUSu+4bG 7rbKG8YwACO/8KpXmpyikT0l29fUzhutziyWWC5BO4qdckTqosBsTzRxJigkdIfWffJO A7u9wSjJtMZVnKQMfKBkEWl6oOopuFd40psfbUI8E1q2qX9kwQW50yWwMhiC3RB/U0HI fuMg== X-Gm-Message-State: AO0yUKVy3iD1Iv0xqlrzKjmVIZVh+kWcms7pnuCNGERqn/EOURCuHfO2 DgJjwpEhcgMzaQom9FuFzHJGs+64Wz+VyB9eEOw7XQ== X-Google-Smtp-Source: AK7set8+wlmmGu++ONW5xj7HgngOtl9j0r1Dk7jOzX6yp6wc8kOvY/ReR7vw83x0DvUspbDl2cFQU9++XrxQ5wokKbY= X-Received: by 2002:a5e:c243:0:b0:745:70d7:4962 with SMTP id w3-20020a5ec243000000b0074570d74962mr4904464iop.0.1677766484171; Thu, 02 Mar 2023 06:14:44 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> <20230301143933.2374658-4-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Mar 2023 15:14:07 +0100 Message-ID: Subject: Re: [PATCH 4/4] kmsan: add memsetXX tests To: Marco Elver Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4F44D180027 X-Stat-Signature: 48gdxwzkq76q7npip4rpsoccquu3thqo X-HE-Tag: 1677766484-707404 X-HE-Meta: U2FsdGVkX18ONR6brjIPG6JG8JtZh8X7wAJDS3iEm8k6j+489pOPBndo8x+PtiVsjIF5ePMIE0WPmOp8aRBmzZ9sdLznNJOYqsSVOLKuiOzrXFjNvgS4r6ZzenGHQM3v6O4y6BJFiuTTrQZDAKB0m/GhwVjmk7B0IB4DExLD3mx7wmrx+23q04rVnhSvU8g+tr/DruHrX7kJbjzDZHBgb3Z+MKezO8m4p2Sii9Y5D/PsGeukRCuzo0lW2oNWaHgA8ktDMv5/DreO06eAzFxBJejGFLq5LfApgYVf7Qsuc1U+xgVYQICXtHTjweCDsdgQ3jJ+lBvT4EwLKAWzB0cy8p664e2DpNurCNLiEsWXbKv8kzRT0Sh8Moq8XG3pQpEVZ4VezhJGwhFqZoQmj97BD0Yj9jXWdakTeHJDSVp26xSIWDOYZZtCh0g9U1LzDDniX0nVT90A6ZE5BuSLrtEG5q/wj53JQeRNoM1C6Q2gStasUvoEBgBzJUwg2KVH25cV+cHK6TwIFIzgO2jfCFVLD3c5UV9oAvdGqfbiIin/SXcgfL00cNm/USvAYEyGwTVDQVN+9bom2W21PAcjThdSN3+hKKGFkbuf4u1LLHuwYOtu9H4bm4E/jnQ2LnAGNYzbgLRlhFIeybdVZ3lnqAPC5i7OBL7Xq/edvRs0cdfaGvPwdWn8qrZER4MTbqC8/I5I16p7+HaYuNvB4l3u/cpsBBY/KX7XDFTsJfdEgt/eOqmECov0+rCm55qHRGTlvTW/mrqy/itMIusgRdScXIv2mbi/LKroibHAj/uxyIPW8TFAjUqRJbgY20LWLwk67tCdT+RsjHKhQ4sqYTZu2/QGDKhSFYqSQ+XG8orI36kuNIhnOXypW8iM+KtD1IEzIKhdwIJrMHjiSCdu2LgOV+FKpH1QmVjchviLCELK8euZ7zUCkxif1LJIFMdCLcleEaRoLY+uuZs6HC6BXwYURMd +yHCM/8Y q0WMmZd2FHD8R4LfhdQZcHkYsASWpbM0FQ8w4BAQUqPLUcSF8StSk7PKR/dp5zgo1LM17Ie1TPcgqd2SydR0UMYiP7CapZTQKTJ1gtZIbFVfwxQZvempaCZCNAz4jWMput658CxiLZ6dbTkWXmC5+VgzZXlPG9s5JfhFVpZgsPr7zoccC7Munb2Jju0Eo0lSr7pHlZNr2IJfoWaqE9KI5mf+HZT59lDGdQFJQ+toen3Yj9SD1SgqCGs5JVvWn41SOM5w8fD7RM/ADkTc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 2, 2023 at 12:23=E2=80=AFPM Marco Elver wrot= e: > > On Wed, 1 Mar 2023 at 15:39, Alexander Potapenko wrot= e: > > > > Add tests ensuring that memset16()/memset32()/memset64() are > > instrumented by KMSAN and correctly initialize the memory. > > > > Signed-off-by: Alexander Potapenko > > --- > > mm/kmsan/kmsan_test.c | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c > > index cc98a3f4e0899..e450a000441fb 100644 > > --- a/mm/kmsan/kmsan_test.c > > +++ b/mm/kmsan/kmsan_test.c > > @@ -503,6 +503,25 @@ static void test_memcpy_aligned_to_unaligned2(stru= ct kunit *test) > > KUNIT_EXPECT_TRUE(test, report_matches(&expect)); > > } > > > > +/* Generate test cases for memset16(), memset32(), memset64(). */ > > +#define DEFINE_TEST_MEMSETXX(size, var_ty) = \ > > + static void test_memset##size(struct kunit *test) = \ > > + { = \ > > + EXPECTATION_NO_REPORT(expect); = \ > > + volatile var_ty uninit; = \ > > This could just be 'uint##size##_t' and you can drop 'var_ty'. Indeed, thanks!