From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F19CEB64D9 for ; Wed, 12 Jul 2023 09:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8103B6B0071; Wed, 12 Jul 2023 05:30:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C0806B0072; Wed, 12 Jul 2023 05:30:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 688166B0075; Wed, 12 Jul 2023 05:30:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 555056B0071 for ; Wed, 12 Jul 2023 05:30:51 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2C59E401CB for ; Wed, 12 Jul 2023 09:30:51 +0000 (UTC) X-FDA: 81002440302.30.A8263A7 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf07.hostedemail.com (Postfix) with ESMTP id 533D740003 for ; Wed, 12 Jul 2023 09:30:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JiHaHowj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689154249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AtYtKFoXSNaR0HimX7VOb+3+TUw1E5irFW1i/Ff7fdo=; b=MqACbyfYXCXguzMKOOMnyib4JZFqVfNU/pz344MAfvA7cH3CkH0GCNhBKEnWH3mjCny7q0 4pbF7Jfmoeg0eh9gi+lKcmd7A8clPxcfxWEE8skm0R2citzJ/kfzjg+Sn3nIVHEuH+qxM/ hQNfUbXO+rlsBKdiA1KHr9hK0syVxhM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=JiHaHowj; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689154249; a=rsa-sha256; cv=none; b=d9EUrnxkVYOSFA3uc9Iep17wHYzPFdxnkfUpxLKiHEcI5/4J98VeXcRiSTTpZcdVTp53si 1hPQAZzGjR6kPzQuqrHhIlYbSUQvSRg24jeksWUIPK+ptsPJPmyeUy7ayH45bb5+T/1Cyn 0pnMbbEkCT+948GYaqBB6qlWFfGMeCI= Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-78654448524so212933639f.2 for ; Wed, 12 Jul 2023 02:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689154248; x=1691746248; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AtYtKFoXSNaR0HimX7VOb+3+TUw1E5irFW1i/Ff7fdo=; b=JiHaHowj0OR8KwgXRnSt+L69TkR1RoU8hgZP5ne/AABbP9RXRzfG9ZSAx0MAeVhVqZ RuJx/lQyMwgysM2NJJZoGKqSiN+WMv6gWAnXqOgWSf39ZVAdpNGkMwf0z6pgOK53tZuA nZHHD6009dX+C5GhWf1qYTFnrjMxXZkyN4CdO8MGWcgcWBxbLFUneXMMFHq6kXNET2dH oGHEe5b9x5GgGfutXNttjbwXHcMkXsMperI26dRitbb5OFBOJ6YL0HyVS4MyAEzpmCk1 t/vxsrrakkSOfL3iplAd/KFb7WowFeadG8xtEht7siYoPYqUghzRkUEoi4NBlW5Y0EGe SN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689154248; x=1691746248; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AtYtKFoXSNaR0HimX7VOb+3+TUw1E5irFW1i/Ff7fdo=; b=bxq17KfY2M0EXX+XCzqx5GHCWsfpCLThK3tdLsCN+ORq1oFrxCXZLcUoJ9q5nJyuAC CXOgWP5J+a7VoHhQrvKe+foaV+wIdB4Bb8lbAlGnO3uWRgTnIMj6FK201CoPohOr5Nv4 AuIfxxIigzea9wl2z0KZh+L4VIodzcZMkAEo3EWG0t+W+QQKFiU3vY3XRK+ZK7ke5Vc8 CRN8ub/r4qF/d7Nf9dtC6wii0BZqZ+MGuKN/TbgvEn7rHte9VK5gI/fKQh2mTX+IK9lL RV5et2nfV0szn0ADM9XR/gTZVUTGnb0NrP+IiI0UrPHDpeW55tGd68Q067BaxDswgrsb xi4g== X-Gm-Message-State: ABy/qLYbLxN9VV6V53AjvpjP20K5zuyjXmm1v8vcWW4GOL4Hh44zsbIU k5fewfy2LYIz9AeG5tx7fwvvo/v9J4r1BHH//7or7Q== X-Google-Smtp-Source: APBJJlHlumhEigpYsGGvupqXZVMHwmq5rfVisQzfEtUqsBWOohrJU8W/yjpSj7l2e4UcAkLLYOQHsAPeiX/obZxeJqU= X-Received: by 2002:a5e:dd0c:0:b0:786:ea57:22e2 with SMTP id t12-20020a5edd0c000000b00786ea5722e2mr14334765iop.20.1689154248240; Wed, 12 Jul 2023 02:30:48 -0700 (PDT) MIME-Version: 1.0 References: <20230712081616.45177-1-zhangpeng.00@bytedance.com> In-Reply-To: <20230712081616.45177-1-zhangpeng.00@bytedance.com> From: Alexander Potapenko Date: Wed, 12 Jul 2023 11:30:11 +0200 Message-ID: Subject: Re: [PATCH v2] mm: kfence: allocate kfence_metadata at runtime To: Peng Zhang Cc: elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: teatsio1wdf9upiz3t77nbai7c8kjsfn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 533D740003 X-HE-Tag: 1689154248-587542 X-HE-Meta: U2FsdGVkX1+PomO2qqfpYi2ZomVd9x+4b8zxldHfNYeKEYTcbPpqFdbdiSvvFl3fJBjPc9qjGVJtZlOYy4d0YbPqzlupKPphrUrrpDF7xis5bHNzD4ToYCZRyBzoUuRc11VAdpX0gwFeNEV12sCCa3JJ0PhXFozTiscbL/IUIJxwIw0Xiiw3K6r8FXosyzFB6wRay941CNnShfHYhGR+OeCU6Pfb13TxsZjveKSY0OEjEk33tF5/XqxwSmrSHQo4ZlJeeGrl2l94hOc9KCAwqbef3oS99B+4i04kWjx0JrOh0e81Oh8DG/a6jv1Jf5MBKD05Wr+6agTLoNBP6hGGQoHW7/MRKk2lotoacsXGVrOucc6f9PQWKAZVHc7DjL3HYMfHFNANDATD2/pM956kzI0s537CJVJ3DJwVwQmD6o+NVYifmcRH5l3AyZbBCNShJnZuDKSpx3yRll1Q9SvGIz1bM1RLUB7eMcI75EOXNvl2PMUse9bAsRaTQvhHBTHgFa1TEXSTPMGx+KHxYVbaf4AzKU18SDtPW/Krb3uzd+Hle/5AdkpWRItl2xjs1f3UzByBci8NQ14u0dLhhtGflGvh58lwi52TMgQQ60yKOfMDYwjHhFBZPISpGNGQ2fZ63O2LPe+c7szRZ9g1YrnSrLySt7SNwtw+rQtSnTVQOXmv5bTzk3GWMa2rXCXSP1jccwnb+aLyrSa+6fGQ6E9noJvt4cihgHh9WPkcNpDrdes2r2jU1MICq9gMkCgta0zASNktbhqIhPCuuHS1MCzGlmFrjnsZEhqPc2V5cOTBDqd2AL/fl3DSmH9libFXt54SOq38WwUBzypB4UK++LBClJT+3i2BdQr0s55UAylSiAyVeJ6enTl1Kp203ajnhtZveaTiXhf6BKJ6ubntCRuiE58ere7FJY8WxZ7+lIkj5LVIfb24m/1ypb4hZmFh87ceI+Ztcd53GclxvNfB7dj bkNiOJnk +MDEp4fWBEa1YoWXKz7t0irIVqy9mxEBEFtVPYtfX5b6eXmu4H8xV6LXQiG3rhC7JvWzFgG4etsT/L4ev5/EhwIeLC9evJCWUQ91djR8FCnIM8DUiDQAQyCPhs/xpKjUH0RBkKQb6zYgpmVI9hJm1DIlAavYG23V3seLMHK4iAFghtV2QKuS67fxHorPeDOu00mf0UZpya6Ys5yHb3lT2oJqBRPCOi2DqaUQeF/aeS1QuIfxrxrOJiuL4UfE7Fe4lYzATK5y6HAJZm+M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.017572, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Below is the numbers obtained in qemu (with default 256 objects). > before: Memory: 8134692K/8388080K available (3668K bss) > after: Memory: 8136740K/8388080K available (1620K bss) > More than expected, it saves 2MB memory. It can be seen that the size > of the .bss section has changed, possibly because it affects the linker. The size of .bss should only change by ~288K. Perhaps it has crossed the alignment boundary for .bss, but this effect cannot be guaranteed and does not depend exclusively on this patch. I suggest that you omit these lines from the patch description, as they may confuse the readers.