From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81AFFC00140 for ; Tue, 2 Aug 2022 20:08:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8883C8E0002; Tue, 2 Aug 2022 16:08:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 837908E0001; Tue, 2 Aug 2022 16:08:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7748E0002; Tue, 2 Aug 2022 16:08:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5BFA08E0001 for ; Tue, 2 Aug 2022 16:08:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1214B1608D6 for ; Tue, 2 Aug 2022 20:08:20 +0000 (UTC) X-FDA: 79755739560.29.856F14E Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf24.hostedemail.com (Postfix) with ESMTP id B69B5180119 for ; Tue, 2 Aug 2022 20:08:19 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id 123so25268370ybv.7 for ; Tue, 02 Aug 2022 13:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=0+45JLGnZfMHQQnDGOsiLF2twVwamYBrdFCbJu2NgIA=; b=jpPabckjsg0UsINT16ut9CdYerI58dLxrYvNEnswsOppm4SLNq927fz87yfpCaH5ax KCdBZVYZC28pn0Xy8fByE9dMhE8wzQotEbagoddzKwnhmnvTYqWbLwoaqdiRvLKYznys CDLFtlDEGzvhUJHY3YQ4kD6DifvKKLm9tOWmjDF+AGteoYwqr8Gj9xSmKj0lQf94Dano Puw4nNrcbkvpOKbaNJx5xdJXYf8omQ37KoH6c170mgLLZqbp5mz0WBiwi4EYEeWreMm1 OZXxLAx2HCduvRAgAu+IL/1sB/WSkbDh8Yb6i+wC9qhoOFawUusYA9OF2v2VSChbKYhR WwWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=0+45JLGnZfMHQQnDGOsiLF2twVwamYBrdFCbJu2NgIA=; b=W3aIt5KCO9OK4ujvm4j3z0k8uzySOVlMDGWtVO0lGjXCHtbX5Cix9XKr77SUHnl+4E ZHBq53KBgNWX53jlMSYnaHkSdljfF+agGMA/SwiRH+J5hTfYKTr5QXSDMNJwYvZuI6cD wfF1pOa9jGk150cAXjBURxpYP4owZKM25JzPfVYjPTOoIoq8QWZqjR4+BK78Ft74f/PR SMuODNfXRUucvaAmH7ewQ30YfkXMQJU3kVfuPubOaiYU1BGwQqFiFPThJGN56h3U7nbG iLuiUfqtzDaGKhhCSwJhJn7QfQnnUMeZA1QtO92ZA79Foxb/W8Y1LupNtI1T0Lgze7D5 79DA== X-Gm-Message-State: ACgBeo2GofHSdBDLrtZl+jYbYNEuOf0ucNagq33h14Ay/f+fM/7HrGEr HuZVCUgCCa+OkJR5X1xsottbTZYBO2OuTVo1eWB8hA== X-Google-Smtp-Source: AA6agR6Xa8GLqLWKTmOgcXYKSoHfDZeq+GqS1CWYb5caYG2+9D4u6ak/0xp4JW7TREtw//VymY38BERkomb7kpPmXOI= X-Received: by 2002:a25:bc3:0:b0:673:bc78:c095 with SMTP id 186-20020a250bc3000000b00673bc78c095mr16344277ybl.376.1659470898706; Tue, 02 Aug 2022 13:08:18 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-18-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 2 Aug 2022 22:07:42 +0200 Message-ID: Subject: Re: [PATCH v4 17/45] init: kmsan: call KMSAN initialization routines To: Marco Elver Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jpPabckj; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659470899; a=rsa-sha256; cv=none; b=aRmtf+b/6Fw/Q1YhpLB2i3l53r5A4Se64VEQRcJz8hg2TUrtYMrk8Wj6LNatG5jb08Lc/O XIBg0HUco8xGriqhKBCsi9PPo6lAkHDdmlV8eE1ClJ1muPwxMVfyR5o5SCBuBO9KSm3a4a Ix6XCSrnASj+b19nLq0mv7QJVIPv2R0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659470899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0+45JLGnZfMHQQnDGOsiLF2twVwamYBrdFCbJu2NgIA=; b=Udcuxm+kX192l9CCjJ+iiD9zxCIkEr3WKI5rQeLk3c69yfUwsn5aNsBcfFzLa3HEDvynTJ 8wMR+Np0E68Q7X/4EJF0E2WsVOFGR5La5wm5SNLbPw5bHMsfv0FUv3HzQ+5uLr4cDS910T 4gjuqTXyGrtvBg2WcBJKnagQFqu7VeE= X-Stat-Signature: 4i67dwb78yyjk4uhn9wie58nmckkkugw X-Rspamd-Queue-Id: B69B5180119 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jpPabckj; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659470899-391711 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 12, 2022 at 4:05 PM Marco Elver wrote: > > > +/** > > + * kmsan_task_exit() - Notify KMSAN that a task has exited. > > + * @task: task about to finish. > > + */ > > +void kmsan_task_exit(struct task_struct *task); > > Something went wrong with patch shuffling here I think, > kmsan_task_create + kmsan_task_exit decls are duplicated by this > patch. Right, I've messed it up. Will fix. > > + > > +struct page_pair { > > 'struct shadow_origin_pages' for a more descriptive name? How about "metadata_page_pair"? > > + * At the very end there may be leftover blocks in held_back[]. They a= re > > + * collected later by kmsan_memblock_discard(). > > + */ > > +bool kmsan_memblock_free_pages(struct page *page, unsigned int order) > > +{ > > + struct page *shadow, *origin; > > Can this just be 'struct page_pair'? Not sure this is worth it. We'll save one line by assigning this struct to held_back[order], but the call to kmsan_setup_meta() will become more verbose. (and passing a struct page_pair to kmsan_setup_meta() looks excessive). > > + struct page *origin, int order) > > +{ > > + int i; > > + > > + for (i =3D 0; i < (1 << order); i++) { > > Noticed this in many places, but we can just make these "for (int i =3D..= " now. Fixed here and all over the runtime. > > @@ -1731,6 +1731,9 @@ void __init memblock_free_pages(struct page *page= , unsigned long pfn, > > { > > if (early_page_uninitialised(pfn)) > > return; > > + if (!kmsan_memblock_free_pages(page, order)) > > + /* KMSAN will take care of these pages. */ > > + return; > > Add {} because the then-statement is not right below the if. Done. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg