From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C4CC77B7C for ; Wed, 10 May 2023 16:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2488F6B0071; Wed, 10 May 2023 12:09:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F9506B0072; Wed, 10 May 2023 12:09:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E8026B0074; Wed, 10 May 2023 12:09:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F39CF6B0071 for ; Wed, 10 May 2023 12:09:32 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BC6A3160653 for ; Wed, 10 May 2023 16:09:32 +0000 (UTC) X-FDA: 80774830584.22.525632F Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 5EF7C401FA for ; Wed, 10 May 2023 16:08:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ObkmmUWr; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683734902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n/UqHIj3pp0KBOJJJHffNhpQw/fXZC/Mr36vwvvthqY=; b=jC8VWqaBIP6tI8QZb20eTnl1V5PEOpzSsiNz1E8xYwWyIHhSM/LjalXvg/3f09wg53KvWh pKL+PvoYejuiTN4uXaslq1VuAMOqY2KRoS/A5Ig1TgChKuA2NHZy+OuW6BEoTMfD3h33Yr thsiGr02/LTSPlJOJyJsKM3oMI6MhVA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ObkmmUWr; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683734902; a=rsa-sha256; cv=none; b=yTqaM0zqg+JYIav5R88Y4AiFtCamjOyRdGFJrjyNEgR/QccMEbpkyQLE4IQlR3VyC+NLcB 38MHz43UWS7+ux2HHrX8LFcDWtUvBXTgpd5n6dwiMUuHqvd4+ZGqzmuXeIKCktbwSlVD1o jNgH90uRg/HUK/vSxGj7HIQMGX4oHKk= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-ba1911d60f5so11022763276.2 for ; Wed, 10 May 2023 09:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683734901; x=1686326901; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n/UqHIj3pp0KBOJJJHffNhpQw/fXZC/Mr36vwvvthqY=; b=ObkmmUWr5r8cmbxBerpXZp30yVBkGxn1zIcP3dnTUisY+szfhb7bSiS0wiR64O7Lir BZH/Iie5BMVrgS382MTN4qg9tx17ZqCOqzF/eOk0R8a3GyfXte32abaXTH5LeUujjYL2 xtMQHqOj0Pq9jnV3Enpqe02MLPW/6yJmY/3+cJeb98Fv5q3jVtuvA3PhdQBn8IDzRhxz UyvQT/uEmBEkaoL51GHcWEyHROlpqpyLmaF3XPs55iqXd3DGo/jWaEWJxx49boaA9hQz rwa7NxsP1JxrMzFPnsESCbMhyihw+PkCNoGj74dtsRcX8n+cGVHrh9pArNe6Phbwnykc ENhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683734901; x=1686326901; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n/UqHIj3pp0KBOJJJHffNhpQw/fXZC/Mr36vwvvthqY=; b=De52vEOawJkHENFE6hKEXKvQiw3fMvF7m2jaxChPMGMQYNXzo7T/0jaWXIogGbdqJh U8TtUJmg/zWSUN5C06w/A4xYZl/m9+MOD2ZJCinow0YLkDhUKS8Z+kKVKmAkfJiss9td I9Ssdeyctpf+bYRbPZptVMAUSN8lO6DfoFqFRiAXD4Qq3HFBI2JMcJj0wUb0OQY8sH/b mh4MDZSg2f5DYznIzw5QW7Smwad7+VDD0vnm/pwuktpVrmIuwfaj+kX3G55aG0ifcUrg r7KtmXuo88a7y0/3PAdNY/OSJQgDj2zOZjY1lzVSbpWw3V5aeT8cmaNY2Rn2b6sPWkVj yPNQ== X-Gm-Message-State: AC+VfDwZQn0f66kSscuoLHNHpVd3zxE+pvKpxQ1MdgGJNvd1Iufi6lTx LCK1/5fM4CpMlDyoh2qWEz2kK52sk7BeBHK1ZJmDFg== X-Google-Smtp-Source: ACHHUZ4Ap9p6mkYIcI6e4F8SpR9DNDQB68qeHqrnorBE56x+zI/FsSX4462fcKV4mArEOzvsgmclv3Mwt+DC/T/Ccf4= X-Received: by 2002:a25:d2ca:0:b0:b8f:469a:cb9b with SMTP id j193-20020a25d2ca000000b00b8f469acb9bmr18089016ybg.52.1683734901243; Wed, 10 May 2023 09:08:21 -0700 (PDT) MIME-Version: 1.0 References: <20230424112313.3408363-1-glider@google.com> <6446ad55.170a0220.c82cd.cedc@mx.google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 10 May 2023 18:07:44 +0200 Message-ID: Subject: Re: [PATCH] string: use __builtin_memcpy() in strlcpy/strlcat To: Kees Cook , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, andy@kernel.org, ndesaulniers@google.com, nathan@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5EF7C401FA X-Stat-Signature: hytucttz1erm5b4a6zdib9q9x8z6dqjj X-HE-Tag: 1683734902-273892 X-HE-Meta: U2FsdGVkX18o912Neupd/1YmI3o3KnK0hbOJa1hbQHbV1juU5Bb7lT1WDNZ28S+tJ5zEDZkrRb3AwJu+C94luYIBG+0XtS9pzVD+DwjntdQ4Y2k0pWpAea+moMEMuxiqJg6/FJz+55F16AYJKtEazD9nj9i/Z55KLZ6qz1AMAmHmom+lSeZL+RacWOpe3+FmlXXETE952nWCIbLJXWgK6txgr1jGJG13YNAPtQOzFOtzlhx2zjCe7OtJ39NV1ke7spqrkspc1lpwvqew25k2UCt9gS2FYkXgOfJgpA6N3d/KF0TOLX/EmjIk8GHHKHL0E7AjuHjrJVABwN0PZCrA8rwb2AFl4sxvqbngmFWpD5zEDXvBdAUABwFjQunzCAqmIhq8mlGLRrkoDVTWMGzbociGJ7sHdkzJlvoc+8mWrfjO3tsaykTKQPITn/pOV0A7MD2//sxJmE9gTt5zKtFkr8Os8P33sQh6XudIZG5X+uXaXCk0eazXmyZiRpOXjo1WPbBdfAWUi8vvblGB6j6MN3hU9hxQV6ZFAoCbCYPQIgfITE7GK1FkSq90azk+O15sS8ezwJ6bz69WgoMyEeOL/gk5YV/MjdTknUPXk8mCmFBZKshEB0ah1nTTAWKohucf2iraWII4hQjIVyeyGrrMQLh+T7l0pdgCIamEy93hkyRctJEfJXtG3mC8RaXjgPmB8xbMmQ9tgRXOtZlmzh14IJboqY7Nc4sEuSQYXPGn0j+2hydLqBZSIlo95eh6Ufa7pp5wGjQ1671ZCHRT94FSFxZiQTlhsGtgUfRNB+26ZNrciynNyExmh8JTI/TSNFnudPEbcFQO8qehuP702Gm9XTLrk023k4UGmHM0GjKCq7SUMlGrsx2eutYZKYWAGqGbsqmcfiFXom9t8zoCGHcAQ6epFk2yW2dMPyO3hKbe3AE956qGXIjPqHU2D4tjQbGKF3RGLhRSlFdgY+RmnVn e+G4XuzL 0+4qFnf1TOkAuILrLENxS0xZ5AK/ioY0K5ZtyRJQ1a0NVGU9rl2jxAIAQMaC2icDjI6HKGvxdJh83rBKkDxdKxVAmW+c9UZh43mE4l+jTezLcT556jTuPOmv9AbI1/wCPAkSGyKQ2O/VkE2UPcVi/nzLpKNUNH9dIzWj4q/U1lIQK4N4B9xIyizMeGu/SSxrZmJ5bLy1vagB/I4Iv+GMcHILsmIt7xKc6YgrWlGe8+X7kMUgNXbrW/uLPPDcs+Kmwj3dq1K9OfZhy6wzR70XDbeZlnJ2+0MKEluXAy7r6EZhEIkw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 9:48=E2=80=AFAM Alexander Potapenko wrote: > > > > On Fri, Apr 28, 2023 at 3:48=E2=80=AFPM Alexander Potapenko wrote: >> >> > I *think* this isn't a problem for CONFIG_FORTIFY, since these will be >> > replaced and checked separately -- but it still seems strange that you >> > need to explicitly use __builtin_memcpy. >> > > Or did you mean we'd better use __underlying_memcpy() here instead? I am = a bit puzzled. Kees told me offline that the patch in question is fine. @Andrew, would it be possible to queue it for 6.4? -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg