From: Alexander Potapenko <glider@google.com>
To: Kees Cook <keescook@chromium.org>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
elver@google.com, dvyukov@google.com,
kasan-dev@googlegroups.com, andy@kernel.org,
ndesaulniers@google.com, nathan@kernel.org
Subject: Re: [PATCH] string: use __builtin_memcpy() in strlcpy/strlcat
Date: Wed, 10 May 2023 18:07:44 +0200 [thread overview]
Message-ID: <CAG_fn=VgkA0OdjqJg1FCBX5FcXtm96h9PTTTwAt3qWa0n0oNyw@mail.gmail.com> (raw)
In-Reply-To: <CAG_fn=XmSbaMQQAwCWVmZ8UYDrsmeQWiqi92Vi4CQqy4GK+0ug@mail.gmail.com>
On Wed, May 10, 2023 at 9:48 AM Alexander Potapenko <glider@google.com> wrote:
>
>
>
> On Fri, Apr 28, 2023 at 3:48 PM Alexander Potapenko <glider@google.com> wrote:
>>
>> > I *think* this isn't a problem for CONFIG_FORTIFY, since these will be
>> > replaced and checked separately -- but it still seems strange that you
>> > need to explicitly use __builtin_memcpy.
>>
>
> Or did you mean we'd better use __underlying_memcpy() here instead? I am a bit puzzled.
Kees told me offline that the patch in question is fine.
@Andrew, would it be possible to queue it for 6.4?
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
next prev parent reply other threads:[~2023-05-10 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 11:23 Alexander Potapenko
2023-04-24 12:39 ` Marco Elver
2023-04-24 16:24 ` Kees Cook
2023-04-28 13:48 ` Alexander Potapenko
2023-05-10 7:48 ` Alexander Potapenko
2023-05-10 16:07 ` Alexander Potapenko [this message]
2023-05-10 16:07 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=VgkA0OdjqJg1FCBX5FcXtm96h9PTTTwAt3qWa0n0oNyw@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox