From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA51CC46CD8 for ; Fri, 22 Dec 2023 11:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 540446B007B; Fri, 22 Dec 2023 06:28:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C91C6B007D; Fri, 22 Dec 2023 06:28:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 368D66B0080; Fri, 22 Dec 2023 06:28:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 24C146B007B for ; Fri, 22 Dec 2023 06:28:34 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E8F53140896 for ; Fri, 22 Dec 2023 11:28:33 +0000 (UTC) X-FDA: 81594231306.28.6DA8301 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf06.hostedemail.com (Postfix) with ESMTP id 3BD3B180020 for ; Fri, 22 Dec 2023 11:28:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sUgjr5BV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703244511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1p7KqUeaWemOFaHH+JSolT+/fQ/fl1zP2/9KT4NrzQs=; b=UJsCg6mJHTIcowAnHGYM+ueGPmG4dz5PdCefCNN08VqtAIE4JFkPZKlpY0xQn5Y/j0/SNM QirOqmSHmVFk6l/clgjpAcGpJXzf/jN+DgqJswayQiJSlwHeHOgCJcEy/Gzb+GZAP+se79 rooEaAnXjmPfgR6TuvcUMMqs5vD+eFQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sUgjr5BV; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703244511; a=rsa-sha256; cv=none; b=bLwvITNCgX9SIi98o4BKkMjbPLYzVLdWoB1xsxK+SztKlumarb0whGrq6I/TNqJq26mVvM NT58Ju1rpYhooEmu1rI/cPySbSOrLCn7WwAStp6+2a1XMu80PQ4t8uKEgaMkrA+6TRb0a0 eLutCpnjCBBKhBbgiPE5FJLX59NorDw= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4257ba1bc5fso12225771cf.0 for ; Fri, 22 Dec 2023 03:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703244510; x=1703849310; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1p7KqUeaWemOFaHH+JSolT+/fQ/fl1zP2/9KT4NrzQs=; b=sUgjr5BVJJwuLpwwSFduWBuBOYg7Mh0Ykbi7bs+WWDKNPIJGIn3THm+0IWYVxzyyYC Bd7MlhbCfnAJs16T6zIDetzNyuWDTQRLoBiWe8KQVsnhQbde1yHFWx94Mpbal1qjT98W tuiyt1pzyEiuBZ+Aux/5/bfpVmaIsoIjwHYrTLuEA/d3fdNgKeV/TWxCUEX8AA5m9gak X2xJufF14ZmSfNmofdLaDRFTGdEqniWcpxTEQioyoUSGoIb3wSS8KkYIokmp2tewNOt/ iHayTLB1lz0tpilR2gO3chTBBmCDXVknTNjtMa1V9UkO69QP7ecjPjnS7QXh8FsN3kMx aQXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703244510; x=1703849310; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1p7KqUeaWemOFaHH+JSolT+/fQ/fl1zP2/9KT4NrzQs=; b=GnlEufEp4+HDQDNxf7RVtgdFi8xSD+nFgDKejLWW7DiUStxOYp7kg3Lgj2jXO+AzI/ vLsJfqOu/KPwnho20giSAqx6U8Pgqv3s+sLvVeKAx2JcuOaCBZI3Rhr67Dz6AzOPW96z CaV7i4TQxnnzuvL74X3yGmeIeeldoymsQL76fuV77gdvoBqTfhpNrzXAlj97lKAllMu+ VDR878+Shg/ki2l1wAtubIXlKIwFt2pU695RFmwn+48cMQF9wjszp/Q+7cgdw4+Ii835 SNEgaMUl+bSI0fG8y0Itfavv3GcwmwEHYmza0GRFKyNvx9I8Olyx6m9P7f86QXDp2ZRa gecg== X-Gm-Message-State: AOJu0YwBJc51TEWXNG6n9d10IM5TRYxboTm9rvGcWWCc9Aiu5HRz1oAO Id1eGyFZnshw/l3tQvA5uEl2YVR3JlJ6Bbkbf0afcroD0gJ8 X-Google-Smtp-Source: AGHT+IHPji95ha6HR/0zNsyc4lcIIhIIZ0QuPDK3fEve1mQsC16ko8lq10eB/oWPfvvIAqy7RvyLZOYcE5PauCz3ktA= X-Received: by 2002:a05:6214:62a:b0:67f:9eb:f1ec with SMTP id a10-20020a056214062a00b0067f09ebf1ecmr1541233qvx.56.1703244510192; Fri, 22 Dec 2023 03:28:30 -0800 (PST) MIME-Version: 1.0 References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-28-iii@linux.ibm.com> In-Reply-To: <20231213233605.661251-28-iii@linux.ibm.com> From: Alexander Potapenko Date: Fri, 22 Dec 2023 12:27:50 +0100 Message-ID: Subject: Re: [PATCH v3 27/34] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3BD3B180020 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: c7ptrd31ac8epsaqcdeqt3fayg3qsn6x X-HE-Tag: 1703244511-523100 X-HE-Meta: U2FsdGVkX1/WcN0dxggIEZf7GtEU07YcLNJietff7a02i2KYvOasJXXxY8Cs87JmhVTnIef4SCHMSTGJSCrapz3FZ+fQsoZnHCflFB3NEDskt2cWPoDWqNXjESuzL7ke0RSjHK6vUKtZOHooftd7/MNZdpKunuRTqJQcVaS4AquQJ7fty1zSgSAbRpj3Z/N4ZujrHWuTFZpnbP4ueamyugWnne3BHnpN+9rxZQ/mgD0nlYBdthSSXwSbu6nAhtnwSiKOF9STjn8cTAR6HtNxqNaWfve+rpiiqEBOEYyVVrsb6evWeJ+LEQqu9FnWwyPKv7N5vmmOjN3fA06XrN562Xu627AmMROiAjshbZMjvIHJtEll/kGM5qWo2CnBG/qJKY6SjMSUcHtBMmE4Glk02qvctGUIqFwSnWCENpIObVyZvX4Z39ZTNQ0C3FG7oZ+PBHCbIvhz3wsl1TRuLLj7mp/UxSNEFKXwaSldJcd17AHFoCwj4l/rjO3rXU5h/Uh8okR/UDJzCQzPvLTmIUHbERE0W5Lb0aJhbPDn4NsZ7T4Oz8tR+VHp1P51F6cYLF2xeyAAIl2K9UcTmgHMW1xICH0wKocsvw5wsb/SsTQxlu8L2mngvnVYj07xwN9GE56Mu0pmnnogTpI0pkeCnwMrpqrOw38cibxJjUYNQH00QdBKW9wmFPYyKB1akHHm3ziLF10Q4bOd+aDpdbiDVTnxLtXZ+Oa9ult7bo/p5K1PVYlnkkcimftjsv0disqP6FnJsvsmLAk832UgNcF8G01SHQfOP6R/qoxfbsla5mbiZsmyUrRchxlC4BmAcxlwvOy67Kzxk5B4Q/EdfRIebJpsZni1IoDyAoJCDFPyh4HTNLko39ijGVvNA/RihpRahT4FeFce6scE2VvwkfebkzwroT++xAKXg7W7sGM5YA0dMD2UUImHuRT+5P9rPdmBYmqq1oFwAz7RNVGqoLmGcvK XKW2aRex xSFmphCz72TzB7bL2l/qYBmrUBbLMC6jRgJ2Zci4/zfVC+HCX1sbLR12Qbnlk2jDl9d4EfkzrSkFKSX7H8WyZWjyE3OwAYnaYBBz2+FLKKwYbNM/i3BDr9/KV3RgQsJeDGtFwqxq8NBvu5yJdIeW8opr6NiyB3FjyYhf1U6kfCjJXA0EccuwmqEiIcftsrFI0xZgUjzzx0px6K+PZTWMN94GJSTAe4KQRLPfbcpAqCWuPRb9g7gZCmk4ZW+k0UQOLuhLzHDchlyRK2RGQJUF2uDK1Dnmif9ECq1LDwP5NmYe/LSHTVZqtM/iKifFaq+CcKcyBNq4MBiO9bNwa10q0mC78N2kCfAMtELtjTg7xBuU2wiAZEHXrh04LUCUDasb9IaDZ99btGDEe7JE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.182439, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 14, 2023 at 12:36=E2=80=AFAM Ilya Leoshkevich wrote: > > KMSAN generates the following false positives on s390x: > > [ 6.063666] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled()) > [ ...] > [ 6.577050] Call Trace: > [ 6.619637] [<000000000690d2de>] check_flags+0x1fe/0x210 > [ 6.665411] ([<000000000690d2da>] check_flags+0x1fa/0x210) > [ 6.707478] [<00000000006cec1a>] lock_acquire+0x2ca/0xce0 > [ 6.749959] [<00000000069820ea>] _raw_spin_lock_irqsave+0xea/0x190 > [ 6.794912] [<00000000041fc988>] __stack_depot_save+0x218/0x5b0 > [ 6.838420] [<000000000197affe>] __msan_poison_alloca+0xfe/0x1a0 > [ 6.882985] [<0000000007c5827c>] start_kernel+0x70c/0xd50 > [ 6.927454] [<0000000000100036>] startup_continue+0x36/0x40 > > Between trace_hardirqs_on() and `stosm __mask, 3` lockdep thinks that > interrupts are on, but on the CPU they are still off. KMSAN > instrumentation takes spinlocks, giving lockdep a chance to see and > complain about this discrepancy. > > KMSAN instrumentation is inserted in order to poison the __mask > variable. Disable instrumentation in the respective functions. They are > very small and it's easy to see that no important metadata updates are > lost because of this. > > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alexander Potapenko