From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4272BC76195 for ; Mon, 27 Mar 2023 11:05:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D0136B0071; Mon, 27 Mar 2023 07:05:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 780846B0072; Mon, 27 Mar 2023 07:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647DD900002; Mon, 27 Mar 2023 07:05:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 540A06B0071 for ; Mon, 27 Mar 2023 07:05:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E94061C5FCA for ; Mon, 27 Mar 2023 11:05:48 +0000 (UTC) X-FDA: 80614397976.05.8733066 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf12.hostedemail.com (Postfix) with ESMTP id 10A794001A for ; Mon, 27 Mar 2023 11:05:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="b/cIc4Mb"; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679915146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ehsWNKlF0rOfJEhYzl+s3Qt/MT/o/tgkdKM9etceMxA=; b=EjQJU9fdYPjknsomlYV0l0q2d0ioBxwXCLgH0nyi8fq2i8n/4BF5E2qHrcV/R0bo4SwT2T 8Q0rdFpRA+sHprtstpfPblKQdNPGiJu6tIQmGubJFJxXjt9SPNvw6JZfkrCO+VDdHLSDgL ge9EZroNNwy5rbT8U0HJLI8R+MFyEe8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="b/cIc4Mb"; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679915146; a=rsa-sha256; cv=none; b=PdwwJiVYIL0gELS28nmMc7prjkSwrycZMhcHUoxeh8rb2b5rFy8sPV8fA/Y608nlVQvntj 1VBf60czpbd6UvSoOA9O3FRJ5vOlZQK43ZOqOb2MXL1AD+B2O6k3NRmcEYvLd+YqKOCZSB 633nHCj989vnyUh2HGEMpsIJVNVyas0= Received: by mail-wm1-f50.google.com with SMTP id l37so4802738wms.2 for ; Mon, 27 Mar 2023 04:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679915144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ehsWNKlF0rOfJEhYzl+s3Qt/MT/o/tgkdKM9etceMxA=; b=b/cIc4MbvLRHtWGN8L21g5I7bfjRqRPmXfvJ5KTWHCnLw8UXIlmBZHx74R2EuC41SX BU5/k7qgGe6KTX+mOQSZgmSUY8qN3XV/kOsgbfhCnkjwOTv8O/s6iis7WFXDksbsOThe NpwlLU3jAYgz9qCzwNT0MyJwDc2VzbNbi2EyxZZsgCbYg2dzWwEG7H/2BtafYrWZWUir /9L60TnHoUgdSiwNcoZrgLf2VSMmuldh0VgSII5pck847xYccV2a5EC2mviciUa9U2NR pmYtCfK4qoINZoy1IbtKBZo/d67bkov1ndzKao8Qv3edhm1vAn5DwIpxLLTioKG/q9IH E8Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679915144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehsWNKlF0rOfJEhYzl+s3Qt/MT/o/tgkdKM9etceMxA=; b=jmP8CAptzEPN/lIOwVeT9Tl7uDEeWqaE9Ev16215nzWpfEQUL7mtcGtW7SUb5VIN6q 3fTyg+mxxO7BkOVY4zlPmriYzCQWAO6dd0cUzuPkJ38M4S0R4Mj1Hre56nYtsK776HzL NZ/PxAAr04DbxbpZPMniXyrol/pGCzjkkRTaM7hpwx+P0zDg9ysIQQxNfl/BQ9LpNAp4 63ZLG/DOHGk6QIC4isZRJfZa/rZ8ukk2Ew0SUqezC0qk7MKYvfff46cqMO9+oX3G5SRx 7XYEE8uKYLECM9K2//T54Rzo4YWj3+UnV6zQClE6P+QR55THutaKF9ZKi//61cc5MaUY F3jQ== X-Gm-Message-State: AO0yUKWYhjMGN39vFNmYYwahDI7z3sQfyNLw0sgC49ubZXZ+KJAIH1ii zpZ5QKZAg+VhIfDzotpN3cUNYIE21yqzY0pPcmIH4w== X-Google-Smtp-Source: AK7set8A0Txc1zlj45/dH5R295Jf5SnDiewPZOSCHPNeQ+47JZZhHBFGkkabaqFtS4EbNLIYmqVtZmN7+bFxB6wTMiU= X-Received: by 2002:a7b:c3c7:0:b0:3ed:fddf:b771 with SMTP id t7-20020a7bc3c7000000b003edfddfb771mr8982017wmj.12.1679915144600; Mon, 27 Mar 2023 04:05:44 -0700 (PDT) MIME-Version: 1.0 References: <20230327034149.942-1-thunder.leizhen@huawei.com> In-Reply-To: <20230327034149.942-1-thunder.leizhen@huawei.com> From: Alexander Potapenko Date: Mon, 27 Mar 2023 13:05:07 +0200 Message-ID: Subject: Re: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags() To: Zhen Lei Cc: Marco Elver , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 10A794001A X-Rspam-User: X-Stat-Signature: zttfdm56ssz6qixtd1en3yc55ocgmdm6 X-HE-Tag: 1679915145-67338 X-HE-Meta: U2FsdGVkX1/fNwcOaJA+Y55roLJHZpCz2GHQ/YTKYiT6ZAeABcuVPlbnGS5dm90nHHRnOC6c3gKKXm5obUJxCAXvF55orqztrDhhYMT7PS5gxK2L4ZJ1Ji5a7RXU6zZs7KETwY9lEG8oAuBrHZ4RXTi5DQwEWnfb+ScGELF9BiwloKS3GWOfsqL0yHlb9w8dRvv1IZPmlDXQSXcapOWK7j3V55XBDRS7UOutmMOa8giSbqS8gj1HQ+pEgmISP5kJeO/3aAIr5byB/YZyMMOmbY4LUUbnUVvdtbPonuKVMWcEE4rpIT9FSfxQj92raCpaJZOesOkie6HvZDM3aInfsvPgv/WfWKq+0xwX9Y6H67ac3WZ7y9XaTeevZDkPotSsRIWyTL9X7xepbNhKGuZFgS/bUWN8lMdqbdCk02q2V0GIk+vQiW8J5PjxIaBCKKQ1e0Nu2aXZXZtjq2KeDYLVREWmnKCVmn/SPOVIT3YFVK41Zxa4lPVtApx9C3/w16Zh7EK82ZxUKywM8+BvBi4QHwD5Q+DKsjbMHWebc5JlNgk9nadQ4Wb901MyfjYkMXopVOTGWD7jrhpeHpenfCxbLhEOUNn65+bsxe/zRYSxC1zEAmX2h/CQqA+odRL79RrqKR764IkrSpr+iptf7wG14KLlAnQ10ynrWdveJWl2S4eXgyeo3XQx1gPdtbPD5wWHZUtrNNpQ3Vpd9kQmV7eXGgrSWry0s/fdaBk8KpR1EqOMua5Q37rVOksWBFxa/mta6SJTFwHwlKwl0bCULTav6ZuWRzZZWkIFttO//+lN3ZRPJYO/UUYRRZuDyIPDl6zbtN+vIYNyNJi0Ew6cwxPoi22cVQ1GscO2d4D/YlDLX/0Cn3einLXqDcx+44zSBDIPl0GfGbDAO5jJxCGADtyivEj+MAlwvYFCC+ZXqicJxFlKcfmgXMi37Guq1nll2vmBh0YzMwlmre+fV6+B6sz 9oWXUVlQ iKC3zK7tzwFn3zWgf4cOeYjBfKhJRwZsvZT/E5uW21zgTj5Jjjz2nbQg5MxXfl4DvnaJKASKrwjLHTeC6HHxhM4GVeck88xZv9WQXaB32NVikqMMQFlANMHhMTiP3OQMQM7JQofJ4bZ4ThMSVB6NNXugcPWerh7cOB0XcmgrmU+H2rr+BeXt7g47b21mEOJ/yEEYaGX8nI1Ciy1CJzs9S7YmxFKPkx8YQLTJEBJ84kiXuDpp2G0yA9qcZ3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 5:45=E2=80=AFAM Zhen Lei wrote: > > After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and > commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and > __alloc_pages_nodemask"), the comment is no longer accurate. > Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the > comment rather than update it. > > Signed-off-by: Zhen Lei Reviewed-by: Alexander Potapenko > > nr_entries =3D stack_trace_save(entries, KMSAN_STACK_DEPTH, 0); > > - /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask())= . */ > + /* Don't sleep. */ Thanks for spotting this!