From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D59E4C4167B for ; Fri, 8 Dec 2023 13:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 296AF6B0085; Fri, 8 Dec 2023 08:49:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2478C6B0087; Fri, 8 Dec 2023 08:49:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10F1C6B0088; Fri, 8 Dec 2023 08:49:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0125A6B0085 for ; Fri, 8 Dec 2023 08:49:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D34ACA1044 for ; Fri, 8 Dec 2023 13:49:33 +0000 (UTC) X-FDA: 81543783426.19.ADDE75E Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 20261A000C for ; Fri, 8 Dec 2023 13:49:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=id0OJWCQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of glider@google.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702043372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pyp/ZFyiUOjenQgn6G8kYMLVmsBPMd5m8mXyGEY1Mx8=; b=w3FTdwbanF1tSge3Bq7+F5H4ywVcg28Z2N7v46TzGUzPl/hOcwpIJmrvTFiMLr1LKO1Kzm hNR779qVryck3qdxn0jy6ehASwC/IcK6aE0SMrpLCZLRcIWg6CTdgulJF1mCZK8shVvbKa WT1Guxxpc7iEG2VIyljq9BgNUGZONJs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=id0OJWCQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of glider@google.com designates 209.85.219.43 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702043372; a=rsa-sha256; cv=none; b=tIh+3ONI7gwypW3X6XzGEELgg9Okn6b/6pWHCDupzFm/GCdXqTBJsTpWqC7wI9RfP4V1jx SBEmq2QPtD1l5LA++gq/wQDP7u+qHF1XifNe+AGAWXXLMlWkjYzJKXBBIBu2HsMneBWPLD ktCSWLzWkSe9ePHFMW3x63dg60caCqs= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-67a89dc1ef1so11684836d6.3 for ; Fri, 08 Dec 2023 05:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702043371; x=1702648171; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pyp/ZFyiUOjenQgn6G8kYMLVmsBPMd5m8mXyGEY1Mx8=; b=id0OJWCQhpPcupkqn5gaY9Jo04FjubU1Xp3yV9YwRWEg3xi0wUAa26lXD57JZCnj0q 2Ql1KhGtUbXd4dtTZe+Tg/Fa03n1BqVpkPsaMI56Tjk3mrXl2NCgMaX76FcwY3N4Xkxs k4vw5jEdcB2asc8REtw8jEd5PpHPit6o7UodyNECrABf+yKSBwBxL2jLcVRKbxhV3YBx KhxNdA/p2e0XgoxPv/+yuv64kaFRTUMGcsWYSJdqKLkEWyQRF5v9BWVjtg85Rj0Jh+cK 6zcfFncerKpn/AOyM3fEm5l1qdXzeWsflSbVOWHqef6rZJ+BgSKL93Jw0MV49fzrMhF9 o4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702043371; x=1702648171; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pyp/ZFyiUOjenQgn6G8kYMLVmsBPMd5m8mXyGEY1Mx8=; b=P2OCDnqC4LcLomd53IJmr+wDw/pycLuZn86q40bqdD5moTgYk2AK5GrGGcBBbQ/vnK 35FausC4q1ACu3HGkIjmYZdzB0zyQgzF6sUaQ1n4LW6a8exvEO/RnXYvvZ38ow8SO5Iu MA1cDN9GSJ8bOy1HYWZFeeWWJqTHqtzyIxBzq7dcIhn1knVUpW6qx7BTqG/T6l8De9Cu TvcgfZ2xvw5JDHI/h+JNAPQ0qr4bZx67oOf2/cHgD80ddPfUPP+Kl/OOUQ0da0DrCMl5 vnu5xYCI2RwUiUyu4pkabxDRxs63wpUAY5wA+DDpngRg+XP0w38YQDq0NrCXH9ty/Emy DvIA== X-Gm-Message-State: AOJu0Yy3Vq+6zBxAvjlXUy0kvSmUx0bbNCk0/WdnugiynOSKOcy3dOMA UVG14TvY3Ln9g3gTJDHopqIA0IZo4URZVmy0mLvtQA== X-Google-Smtp-Source: AGHT+IEr68RmSA5aYBUgmYtuiSsf9rYsZogw9kLYvnY2zqG64Y2/8MrVDe8thwflyfC3jwZMQ9WgLXTtXopCNqK1OqA= X-Received: by 2002:ad4:5de2:0:b0:67a:c8ff:1641 with SMTP id jn2-20020ad45de2000000b0067ac8ff1641mr5787725qvb.79.1702043371101; Fri, 08 Dec 2023 05:49:31 -0800 (PST) MIME-Version: 1.0 References: <20231121220155.1217090-1-iii@linux.ibm.com> <20231121220155.1217090-14-iii@linux.ibm.com> In-Reply-To: <20231121220155.1217090-14-iii@linux.ibm.com> From: Alexander Potapenko Date: Fri, 8 Dec 2023 14:48:55 +0100 Message-ID: Subject: Re: [PATCH v2 13/33] kmsan: Introduce memset_no_sanitize_memory() To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 20261A000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 84dgakg6j159u633mdu1xak4t8faz78r X-HE-Tag: 1702043371-835269 X-HE-Meta: U2FsdGVkX1+GQPgiTjx3DiEkyDGGV8apL/WyBF9pt5HqPACjzmeTV6eHGNaIWvmL+QZRAdQegSBAqDDfsq0EvYumK9dv0pAkUs5kumX2Qa7LWo3sCaGlSqGKZgQWcARw/3JzCS5BPFmreHOqNFnAzcU2Arn+MppVhpmh4c8NckjS8MTozbVqG43ZfsktmWvoXKqGVut0LG2V/2yyhmjja0azJ03De8XOwwGE+DEDukDwqiCbEirGy7k+LlRU8ftYW1kayH/4Lzo1O1maro4gk0UB8UfrvOyjE0H9E4H++Y9X8TMgo4oG32rg4/1g2GsXCkGSABLSczMK98pqhw8VRoFuR6n3lQqPRlSDLM63Bc8BqrcrOdx/2D1YB0vijRjYUPwnXF2BCurWHOPppWrZBtV1HnS8hUDLABovZJozDPUzf50K89Tq6yc5H6xp8y9DdDbtYC6y1eA1p4cKgzWv7aEPBxbCAPbLUoYzdDAEHqYDmSbfolsAzn7G8CNmr+zv7WPwQMTn9O5CcPlnSx4yGcP4cMYLPknUgCwdZAN2UyqJQcwGOw/ArQzNHLKUXpZeBwrbJS3HG4BRKvXf+zFOH5zzpwXVfqy/LEug2y6uLZXaJumF5CvlZagUHkL7ltJcKN5kmi50s1gbUCm2ZzqZSauS6pD5VRdnzlJQPpIMqmlK0J++8T3J71DW6bnob8Wscu0MQsPPVayDdoQqCjrVKIVQTgGemBOQ8HZJI3jLIqeFCGUY5Cwp/JArkbUlPSlQH2HpeaLolRFA3GOeuPHYKk7IRmCcuwUV2qOadTqDWdjioFAgHotI/JGbz1lS8VbAndFprt+Kfvn8XDFVa5YoWFvdA70a7oQCnXnn9ULBkmNfLlovg5Et3J6WVwF9crhyzcFBIN1xAFi1KZth1GjRjoMv2vAg6Bv086yUmluoqmrbnb0n3QMgmRftyuxMmFacy3v8biacfxL0ZPh+6dq wvB9Guax 2W8BzXMwNyerWertzMAbwATySIdNG5AIK9UMM/I6sHNEwMOAfjiZ3/Thbdegn1pqAbT0V+YM/zweVzOXv8pfGX8adhUerV5Fpy5xeAb03UE/DGZ6S2fuWOqLq5KKyuv5Sgpmwx0kZnBN4JEumB5wHTqhNBc6AY6uod9sgGDz2pGKXSnGHYfim3hgJxUM6L8OhmtGJkSuMTJC+/Z66M1u8xGwcG8Wa31B6K84Ibecaogs4bhSPJj+Encvgtp7hdP5sYOek5tVOl3KT8IfmEHHfYklmACz39Izdjls8JPzUUpwNxjnRm9/qjZTHoO1c3HvQWMde3VUMbcJVDlf2ajN2Sf1HYfkdktOKlaUVhBaYhfdivME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.028193, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 11:06=E2=80=AFPM Ilya Leoshkevich wrote: > > Add a wrapper for memset() that prevents unpoisoning. We have __memset() already, won't it work for this case? On the other hand, I am not sure you want to preserve the redzone in its previous state (unless it's known to be poisoned). You might consider explicitly unpoisoning the redzone instead. ... > +__no_sanitize_memory > +static inline void *memset_no_sanitize_memory(void *s, int c, size_t n) > +{ > + return memset(s, c, n); > +} I think depending on the compiler optimizations this might end up being a call to normal memset, that would still change the shadow bytes.