From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234E2C46CA3 for ; Mon, 11 Dec 2023 11:51:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 375746B00CB; Mon, 11 Dec 2023 06:51:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEDC6B00CC; Mon, 11 Dec 2023 06:51:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C5E56B00CD; Mon, 11 Dec 2023 06:51:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 053506B00CB for ; Mon, 11 Dec 2023 06:51:06 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C64A5120760 for ; Mon, 11 Dec 2023 11:51:05 +0000 (UTC) X-FDA: 81554371290.08.E96966C Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf30.hostedemail.com (Postfix) with ESMTP id 0E5928000E for ; Mon, 11 Dec 2023 11:51:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eIpIcw76; spf=pass (imf30.hostedemail.com: domain of glider@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702295464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFlOaOKOFTUGeU3hihhI0E9Jv6p6CgBMgpCcvHMWbLI=; b=x/V6eT122B/+mVKE+zzAYriG04LqVHBqbg1d20yYe+WoBOUyo7arLFNawJful3QY60fWTt jqX70WK9hVJRjEZyvrSAl4uWbcbJe5KlN35fCsC5/wA/H4dbZpM9veB9NBFzlLmwsrSRPw 8xP22jKuw9RwbN5TxFqRgcL2YpelJck= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702295464; a=rsa-sha256; cv=none; b=m5Y0x0VWpZRgI337v86nva5Nt21T/tdWDtGe31uj3PrOgtAuMkrnaunoYD2rj7fEejjSxS Sk9OCjDVvewZPqET3nIRNtaJeRg8/L7xVDzA/ac9iL6yIEc8cix72ViZ99bIuj4cHES9Tg xxwIcf4PVsZeCQCsr0V469JIdIx+PXU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eIpIcw76; spf=pass (imf30.hostedemail.com: domain of glider@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-425a84ed4bcso21616791cf.3 for ; Mon, 11 Dec 2023 03:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702295463; x=1702900263; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eFlOaOKOFTUGeU3hihhI0E9Jv6p6CgBMgpCcvHMWbLI=; b=eIpIcw765yHUhxRlwNTS072ytr50Lt6JLy4pJ6E6jruAfYPLmtBIMqLD0HCyDi7vo8 GOGlko+2DaaYbS5lPA7obadkjHcCGRs6pZuXezs887veWqOHcjt/ARVrv3oJw0m9rh99 L7FWOY0PLAXZ/2x1gYWmsQ1hFukc7QipQde28x+PUNK3yyrZB18yihNybK1Y3/U12Dit Pqtiqdu9Rkzt8N1X06HBGF8C5vKhcoLLiMvXXCXEjPyJvxV4j2r0FrxkRisItCT+lV6f IcNy8v9EY+Kpi9csLBUznleS74FC08KtKREcRmVpVK7aTzjFuo2dPoTw0SeS4NvGTNvP 5jCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702295463; x=1702900263; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFlOaOKOFTUGeU3hihhI0E9Jv6p6CgBMgpCcvHMWbLI=; b=sMN84VEZMTaTOwed++Vo90O2+n/cCe3D1xw6kdEj57wOl/KRtD66gWFlsr8rJ56+lo WgfGGYjYtYLdhKYZz0n9xK02iY8J6l98G8RjcaZObOfC5wt17LxslooHtfzWJjmFikZP xvZfMcHpKbnIkidhhZFW1aIzADoLuAFPLIlbov+h/xmaXVgfYpROO2rvagBdqG4I0DEi FKlDvl3/4FPqkUF0zeap99KIDCeZf10McxIJXoVKlCkO2bvZoJmzlOBojvgaY+ZvoXDz N50fxn0M3FOPBJ20dfSiSf0+J/xYf3kwZCMO+7mpExl2dnL7TFjz+cSP15qFBVfo7kbw DP8Q== X-Gm-Message-State: AOJu0Yyci7PIZjiplX6T3YE15gDI/vSLA5sS3Pc84ECUEw0hHqD78Kb4 e4ZUyGwDHVL3fMgjCJmD7m92aegTm3w4MHHdRvoWmA== X-Google-Smtp-Source: AGHT+IESpOk1+13dVI9Xc1VuCWEKnD2SuIEKb3OpBVqsUwAw0LqpvmwqlMYZQkeY3oFDarm5X4BCzXvYf66ohaO4eV0= X-Received: by 2002:a05:6214:2626:b0:67a:b923:6ae2 with SMTP id gv6-20020a056214262600b0067ab9236ae2mr6255559qvb.23.1702295463057; Mon, 11 Dec 2023 03:51:03 -0800 (PST) MIME-Version: 1.0 References: <20231121220155.1217090-1-iii@linux.ibm.com> <20231121220155.1217090-13-iii@linux.ibm.com> In-Reply-To: <20231121220155.1217090-13-iii@linux.ibm.com> From: Alexander Potapenko Date: Mon, 11 Dec 2023 12:50:22 +0100 Message-ID: Subject: Re: [PATCH v2 12/33] kmsan: Allow disabling KMSAN checks for the current task To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: z7nj3igctcnyxecigwhykdsz1w51hw8a X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0E5928000E X-Rspam-User: X-HE-Tag: 1702295463-69358 X-HE-Meta: U2FsdGVkX19BJv6SwGL17jDr2AcIhrRg78eo4uyr2zdIPSNJn0R2xToBXkhi0+OgFhsXu4Koer5av3uPW6/JOYHuBkqS9Wmdep0HXHnuIn/Ydrkk4AkVAMZ9ZtDaI3Y9p90gwdeOpUwJNgMjH+zd7OJ0o1Ff6Ky9IDZYwkkUoRs1jsrXdDKBS/ZPEjgYFnDysMA/tgp+6YS6GLPnQoEUkW40sttaGX+JZIArKWLbc92FA3x12QyhUewSGSuGDqZGjAKD+nWv6Dt8gZX7hYihDl7rgT3FhOYtngGTm6e1C6zzKoX6k4VMsepJ4rfL420zGKOX356aRfUe/kr3h08+ADjWttdGzPb7QnHqGHrhwT9OM0Eh1/G7aOgAa3+J0an/N2lm5ARjJReMDKvP7Vnw47IpXFZ1CFTdkuqmeJQkMhRsPavDs2qidvHHEah42umKUJ/deVAxazcNF5dtKDHzYwwRLX8CynXEReBjzY3Q4LK991cZNlaLeKI8IrStAkeecEX2t7uMjfxV/KC+GnEjcSYYdiSLDcZ+HAeg6j6DHWhdXYXElx71jJfuGX3k0uBtgFvDpk/wwUnaU5jPnr7K8NxmAFHdzaVQAz5TQ+ZHsX+ZnI+jeA6U/WXrExqK+oFE9FQ7b9iPNjWHjrZUrDaMkMOecdR8qytoMjHJ57sf7DJzuYI5aEP/XVjR/aFEzKYLdaPlNQa3GIDPWEUAmOtB12QrmN+CRwPmpObEQBLSu79U6CDEkf7CW4ru/zADaG13X2HPSEa0ArpGIMHzY8Ezzm9sQriYqN9BqTWGG6uCINHLUoZUB3+5iuaJyBKCDidUAF+LB5Jsfo6GfeLdY14M2iO6g63xHOYhPo0HOSRMoaTsPwNghQRUjWkChM334yCMk7x+IiKpA2DWnkQh1rPUMFYS5qqF+aP70/5HCTzOQuCqpLAtRKIh3/k7BogwbOES+FT8qNnbXA22bzvQHk5 +jZJbRhk A2JmghMfPMu4JMdHGtI5HwB/4i8lVkljQNo9iTLMBEPOZCRnTUSv17nQkI5aCxygugvR+ixEX3YSpCKeQrj2RoaRstNo97wBHx25pI1ULRbI2X20eemxgxt6uPqtg9yfAD/HgzyxhZn+B9tUIV9Lkvhe6EDKMEm/YHPYzeY0MUXbt1ytGYLV5S5mI5UGpwPlaGVDNlbPjjKzvBu2AlNyR8+X9HijB+pksKAlZ8ASeZVKk4vqXvPbZMLDwR6JZ1S0AO1eR2OZtWZCazIGREtgf7IR2VllgXYMWjNK93MPdVb42ygxAOOH682VTyJPWAlA9Oj+MBYkSg8Ymx7+5dlj0WYhGKIu37ffD9w8R X-Bogosity: Ham, tests=bogofilter, spamicity=0.319252, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 11:06=E2=80=AFPM Ilya Leoshkevich wrote: > > Like for KASAN, it's useful to temporarily disable KMSAN checks around, > e.g., redzone accesses. Introduce kmsan_disable_current() and > kmsan_enable_current(), which are similar to their KASAN counterparts. Initially we used to have this disablement counter in KMSAN, but adding it uncontrollably can result in KMSAN not functioning properly. E.g. forgetting to call kmsan_disable_current() or underflowing the counter will break reporting. We'd better put this API in include/linux/kmsan.h to indicate it should be discouraged. > Even though it's not strictly necessary, make them reentrant, in order > to match the KASAN behavior. Until this becomes strictly necessary, I think we'd better KMSAN_WARN_ON if the counter is re-entered.