From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361E4C433FE for ; Mon, 7 Nov 2022 14:25:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7838B6B0071; Mon, 7 Nov 2022 09:25:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 733E26B0072; Mon, 7 Nov 2022 09:25:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FBC26B0073; Mon, 7 Nov 2022 09:25:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F4AC6B0071 for ; Mon, 7 Nov 2022 09:25:29 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D82E980575 for ; Mon, 7 Nov 2022 14:25:28 +0000 (UTC) X-FDA: 80106869136.19.F9E5F55 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 7A39A2000B for ; Mon, 7 Nov 2022 14:25:28 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id 63so13782419ybq.4 for ; Mon, 07 Nov 2022 06:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oboWyf02L04GWiqbRTZkWaKzcVjcV8xl9eLiAMUj/TI=; b=LdnEeXZkxBrQg9Ms96uDBWkmElXhDznOcnELRv2Ey5Qwll0tTlJBePAmkt5+/Bbgqp q7gWl5N2Ha+HWWYHMbnqhcUvL9V3lNfkloK5KP2RdfxwmNn8IDDePW8A2e0yAMQ0+00d 8FAkRtjvCegWhjpi/bd+oMzdEMxLWGT0xG0KM098sa5nadSYtYZ3NC/p4zDg8+eT2eD7 wZaUu/5z2aHRkzozSD5CIWAOb0PuNPPcP1HU3/04D7VQVHELTnERd4sovNIz1KIEEwGl Et0KI5ry9O5LyqrPLnuNo36Cg7rEWhj1L5GUcL6HCr182XnTrdq9vADERKTXKSsMaNsK 7h1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oboWyf02L04GWiqbRTZkWaKzcVjcV8xl9eLiAMUj/TI=; b=roBd6L9pd8PL7yNK4D4G7uo641PPK5hmrfH/Dks97vvtw0dk1T8h34+mVGquGOYdXR uKzeqtzX6j53iEIJcPrqwUKFuY5PFhFRy+qSvRfPuuW6NELPnQEtp6gmlUuM1eN5zU9I 10PoKo0t3YeR6MdHYEg4IVxzL0s5SKoMKoXjpzTq8wuKSdXezAeFSquaH7MMJrgSqC/v ZEP/7mC/MO7K3Id665QjMzYEtCO8nuXN/7h0cG/9Icj00PpsPTieMiZ6DzFTtVC3jPxh 8bmTNW14De13/OLeCqgD007eZB3S3uGOOkqfBVfZiEPpy7gBB8Eo5mztEM3mFB0xLFXX +xcg== X-Gm-Message-State: ACrzQf29S3Kj9EJ/wBRp7zU0Sm2Q7gxyOM/mX/ytNPzwgEXR53klDdVx 3c6MO/x0W+yihBD6VueeTIFAw0J7SgLLFlt0w/QidQ== X-Google-Smtp-Source: AMsMyM7Mom0FLlg17x5LYT6YE5L4ZOZDJwMsDDGTbFczWdDPz7zdoi3jn/lnW2YZ3cWVNAW1AOW75h9ViiPgOjuZAEk= X-Received: by 2002:a25:9b43:0:b0:6b3:9cc2:a651 with SMTP id u3-20020a259b43000000b006b39cc2a651mr47557091ybo.485.1667831127440; Mon, 07 Nov 2022 06:25:27 -0800 (PST) MIME-Version: 1.0 References: <20220905122452.2258262-1-glider@google.com> <20220905122452.2258262-7-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Mon, 7 Nov 2022 15:24:50 +0100 Message-ID: Subject: Re: [PATCH v6 6/44] kmsan: add ReST documentation To: Bagas Sanjaya Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667831128; a=rsa-sha256; cv=none; b=3/teFpvqWGjMkOASObnZ3MI5sSV2DWNuh+YXu/1z/TI6LP+AYNDOLfbq1c891urEV4Tyz1 O8CsNZGgUTvJYF6Os3+GhzL0DMwg80+Oi5tmsQpbuwXNXe24e1kFPkL8N0WqFDluDG2A08 o7MYxyodIrydTG9YmQzeYaFGfNxZDk4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LdnEeXZk; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667831128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oboWyf02L04GWiqbRTZkWaKzcVjcV8xl9eLiAMUj/TI=; b=z5c3bM36dFq9tGUwxYg+FLQsiahonYmHh9d4ridPnJCwj516HgENxj5jbsj7wEkJCt37LY SGaxVmHT9h+U/ZULKdI/jdaTlzqZTT+x+H5JBMJ98kbfiWWHYubFMT/1QZk9E7MrPss+e+ lK0aWWlUJXXwnHd/HKNz+1axM4jlDcI= X-Stat-Signature: auap7c3cuz1ny9m13tnjjjskrk6fwhrh X-Rspamd-Queue-Id: 7A39A2000B Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LdnEeXZk; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1667831128-710922 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 6, 2022 at 5:10 AM Bagas Sanjaya wrote: > Uh-oh, somehow missed this letter during the review process. > > + CPU: 0 PID: 6731 Comm: kunit_try_catch Tainted: G B E 5= .16.0-rc3+ #104 > > + Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2= 04/01/2014 > > + =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > Are these table markers in the code block above part of kmsan output? Correct. > > > +A use of uninitialized value ``v`` is reported by KMSAN in the followi= ng cases: > > + - in a condition, e.g. ``if (v) { ... }``; > > + - in an indexing or pointer dereferencing, e.g. ``array[v]`` or ``*v`= `; > > + - when it is copied to userspace or hardware, e.g. ``copy_to_user(...= , &v, ...)``; > > + - when it is passed as an argument to a function, and > > + ``CONFIG_KMSAN_CHECK_PARAM_RETVAL`` is enabled (see below). > > The sentence before the list above is rendered as definition list term > instead, so I add the blank line separator: > > ---- >8 ---- > > diff --git a/Documentation/dev-tools/kmsan.rst b/Documentation/dev-tools/= kmsan.rst > index 2a53a801198cbf..55fa82212eb255 100644 > --- a/Documentation/dev-tools/kmsan.rst > +++ b/Documentation/dev-tools/kmsan.rst > @@ -67,6 +67,7 @@ uninitialized in the local variable, as well as the sta= ck where the value was > copied to another memory location before use. > > A use of uninitialized value ``v`` is reported by KMSAN in the following= cases: > + > - in a condition, e.g. ``if (v) { ... }``; > - in an indexing or pointer dereferencing, e.g. ``array[v]`` or ``*v``; > - when it is copied to userspace or hardware, e.g. ``copy_to_user(..., = &v, ...)``; Nice catch, thank you! Sent a patch to fix this. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg