From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64390C05027 for ; Thu, 2 Feb 2023 10:04:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D67956B0075; Thu, 2 Feb 2023 05:04:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D17CA6B0078; Thu, 2 Feb 2023 05:04:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDFDC6B007B; Thu, 2 Feb 2023 05:04:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AEE846B0075 for ; Thu, 2 Feb 2023 05:04:53 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 60549C0D84 for ; Thu, 2 Feb 2023 10:04:53 +0000 (UTC) X-FDA: 80421918066.08.E45AC88 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf01.hostedemail.com (Postfix) with ESMTP id A849840008 for ; Thu, 2 Feb 2023 10:04:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y7i97OuP; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675332291; a=rsa-sha256; cv=none; b=z8BNf8X8YBCUwrWfD50GBKQ8kq8hpEUJOCYaUUAAoJc/PDA4wfhwqn0JLSaeXIjrx5rxf/ kxVe7GehjjB3pr53bvDVC4luHYj4QWcEzkZAXLvAkqAwYNT/pcoqSsZGeDpe3U8LrDflhG zx3y0mU3Nq1fsp7JxIdVZQFNKQTXFEs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Y7i97OuP; spf=pass (imf01.hostedemail.com: domain of glider@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675332291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OTOvqWUVVZlijg12oIE77cCshSPOfIDDk+4jVZ655+k=; b=NfOBWXlv7tq+J10kdGTLaxPLbpNHtzF38QFDjhnjKrAnM0PH02zqB02MQZebqMdPk1UAb5 2niBpZovnOLpSVK80quNXiZbAWIrws6JEDOSxVHEEmY0ZhbLYP145pomqgX8HQ5ocPSWri EdTYuqt9+A6x2TQ+8q7lj2vytdzwdbU= Received: by mail-vs1-f49.google.com with SMTP id h19so1239602vsv.13 for ; Thu, 02 Feb 2023 02:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OTOvqWUVVZlijg12oIE77cCshSPOfIDDk+4jVZ655+k=; b=Y7i97OuPVRG0MgxTC9jku/WRmfXJzJgR11Xi60ud4fHWkw7cLDQYIdWugE6JNqWnhd zxDgruQpaaB4LFUDWXcMSYeomB81VQX+3ATeeEqUeEUcYV0EZUWrjL3wOBJblWbRpVW1 Gl7h9olEHVokDvWVeTLUZQkKU+OvOIiihhk0mCjAK4uwblHWRLHCA60HwPXBE/iCBa9n T8G8wzVtJ2m0TB3qrVKuJgHUhQkbAiqcJmN3TE6i/Qc8nDPNJRvHNU0ZJAANxudkyU5e ENdpuQzV9CWdipdZJs1aL1KBjiWwUgH58AUI9/UXDJp506L1+5IF8R62Rtxd6SUf3C9k a23Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OTOvqWUVVZlijg12oIE77cCshSPOfIDDk+4jVZ655+k=; b=05krNukzwwgFHM2aGLGc8Y1DCRgCqZqvGiWZOHqndq9JCWefK3Win1vzn9rZGYWVjP GtJRACho3gp5UevxMHSA7Wqw+TphGXltnnAyYBkYXdWOmietmvst79A+4S5MZuToVHVn 2pRS+XQ1vLF/VOWXKjya2vwBImo6R4ilNCrmVh6xuRC5gwzmxex8M5+2IGAAWMQmSaW8 KqVIqIyu+mvREalbS4sWNT/Yp+0kEkGvdQLOUUwWV7PTh7pay8KOZvaIEtIJ+zmegAAa DLzhC94chSRgRDR9LPOj4YpOvlJOcnJ9Tq4rLEV1euhhZk7KSmwQzpOzP58K3NTd+fpH QQ5w== X-Gm-Message-State: AO0yUKXCe59OrtDuOMzhjmcKm+kKFLWoGv8tm3lf+BDrXpIhr1cpmS2F hV1LT1Wct9G18y/w2yYOVjaAbmiVcjW3E7bCqSuvCQ== X-Google-Smtp-Source: AK7set+m0o4TzaHt7t+a9/rf2tPz/cn1DFL8um9JSDcZSJY/WerimKLUAL6/+SWq+cj4vMyKkMrrYJIk30w897DMp8k= X-Received: by 2002:a05:6102:1343:b0:3ed:1e92:a87f with SMTP id j3-20020a056102134300b003ed1e92a87fmr927918vsl.1.1675332290796; Thu, 02 Feb 2023 02:04:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Feb 2023 11:04:14 +0100 Message-ID: Subject: Re: [PATCH 15/18] lib/stacktrace, kasan, kmsan: rework extra_bits interface To: Andrey Konovalov Cc: Marco Elver , andrey.konovalov@linux.dev, Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: A849840008 X-Rspamd-Server: rspam01 X-Stat-Signature: z8ef683xqjb5qhmphyz5ypdmdwbefw8r X-HE-Tag: 1675332291-371883 X-HE-Meta: U2FsdGVkX181nj8Bj3NB0YqswJgS6fMlN3m7BLWv0ZGWcXPfiS2atwejijNv68FO8kN7qr+emprqr68HixSWYWpf4RWy1pMP6EVeZxYHsMfrbtXHhLEfTMYPjojS6PyzTSqwPg9PXgBXVw/Jbwh8RCSALhEl4nW0RMtZ6dapIGFDfiAl8RgmWEfRzojpR3zGEiE5ucDEKZ4IRXGLmOxpJZ/2sjdrKiSdS7eMe6CxMkafTnxWiSbUZLJ6QTvoH6WQo53e6kgSRbspH+yFJ15tkaPUVQpy37UbgSzDMbiDwN5QBRTMCEwYJIkuHyYCvQLwytFxYkqhhfpz1tI0Lq+l40Gt4kc5aU6xN5WQZ9fOhQVNtKj+UYBqj5hSuNlzUgohtqEXcFg9z+XHzyahOBvqu0yP0+MPk2Ekbjndm1uNHl39Sp444zaqOwI6MYrRnlpIwS0UVqBkgzxEtZ5GYFIylUbF1z0UEYwTZWwdEmZsUmvFju+kKK8C6Dxfc7WcG+JSRHl7fxveJKL2TqIU2ITaEVOOI3+/RaR1vVS1Vqq5wfP7Gd3EqxgMpLFywrZWzvD+TFM0tZLMQHjzGP2wftitg+8r/NNn83Nl1t8pfuDSzORqw8DW/mU7Za0xPk4JDk8VivQ8R/MSBugEGicjOMHfoeFCXKJ+s9jZyxHoasK5R6Q85CVNQWoK9CXa3DB1t0QonlMCColLFGl5XbmjtpPGbFeH0ndy96xPz2vMwVSY4vyQf3NCoxxN1lhN8IobYltrhwQO7sjsuAD0ZXtIzkPYfPFr8Rw8ojZHJcvIvr3ejFvrn21Ry5oWps/X95YJaShakm8qQAv4kpXRWZ64NP7U7+yPinS+BUtdfmByBU6R4dip6vn5kG5ZipPY5zAG01zcVSgcCHKJJrcXlL+94bSbGoCGcjrqoihKWmA5KIfiV9VaKDqLPOmNn3PVt1JLIpP5JzMNxE16sTUE48kdVZj O1Xzvmxf AAYq9ppZQq2MRWI5TBsaT7MaQsjttW7AwYgfaCZMVaKGKW1DwP6rK4uGxvTrTOJRYuM/lbcPhPYaVrku8ZC8yALngwGcLNuoj0fFKME9Ai/4bi8eA0W0bMHJI+mJwYGDWu17XSkVVpwju68YpsW3m9tFynmRMaDtKjI9HnIMo3h3Y8pbr1AjJ7E4yFFoXTx5jPan98SimwS5SfKehygzQM0jr2E5zSf+S8U3PIY7XikKT6fA+aNAGJNteYevzRxNwKDyWLwEmQyI2vZZLHbUbX0IZJYrVXTmwlzXChtFsSa0dGUJyed+bWaP0xyXbI+2XuLB+VUUYmYJiTZ/HbdODYbQqoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 7:58 PM Andrey Konovalov wrote: > > On Tue, Jan 31, 2023 at 9:54 AM Marco Elver wrote: > > > > > +depot_stack_handle_t stack_depot_set_extra_bits(depot_stack_handle_t handle, > > > + unsigned int extra_bits); > > > > Can you add __must_check to this function? Either that or making > > handle an in/out param, as otherwise it might be easy to think that it > > doesn't return anything ("set_foo()" seems like it sets the > > information in the handle-associated data but not handle itself ... in > > case someone missed the documentation). > > Makes sense, will do in v2 if Alexander doesn't object to the > interface change. Thanks! I do not object. Thanks for doing this!