From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 607A3C77B7C for ; Wed, 31 May 2023 07:58:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4365280001; Wed, 31 May 2023 03:58:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF416900002; Wed, 31 May 2023 03:58:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABB57280001; Wed, 31 May 2023 03:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A052900002 for ; Wed, 31 May 2023 03:58:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 632901C70D3 for ; Wed, 31 May 2023 07:58:38 +0000 (UTC) X-FDA: 80849798316.05.5E40524 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 78FF640012 for ; Wed, 31 May 2023 07:58:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rAWvgvyn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of glider@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685519916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nHMZgb7ql614fjK+awMwSPS6BsriEA2nG/M+3wX+ebo=; b=RUkeBcQe73rgpKzYvATKO2xgCr/0+qEXpkETSy+eFCBXFqkUvh7Ko0ks30bu7aZPlAfm3/ Mp/GgyxyIt/JZh3arVr2C3s1c8ywiEVqSi6pfFU4CJ3OPGqSApSFM5QBD9pi/f/VgCvA43 fwOm9+CcGvVsqXpk++kBZoDbh3S/yhs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rAWvgvyn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of glider@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685519916; a=rsa-sha256; cv=none; b=es0LlgeRWdQlbh5b9V46KMsYU1zDMZwvLD6pX8CASqvYRLbL2AMKfX+Uan6IwP9DzdcROz tnP3kcEdI/drBQn9cDdxwEDmO9BuX/nuhlUS+xsY0TBMgDcHCaOjtdZcMP/ZKrAhW/7p9u 6BArHmtvJ1g3y91m3K8oQjlCC7W4hs4= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4f4d6aee530so5903548e87.2 for ; Wed, 31 May 2023 00:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685519914; x=1688111914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nHMZgb7ql614fjK+awMwSPS6BsriEA2nG/M+3wX+ebo=; b=rAWvgvynY7FQZDuKtEe8VkUPbI1utwSiRnmiQituf23HFp9h9SYV426Y7rQ5qEtS2U 5vmqffOOYUQbnIS4BdA1H1YpRXOBe31oD0Bjjj6pklQOSt8jbGA2hAlNI1LswwpMIggl J3acgn7N+oBGAphseuqGwBpOGDz0DYms6pL/FuxQKQpG0qhqcEvDp+8CMNnsJGRzmk8v MJuIKeBfkzB5zKPBBMlTgpLLRZPnycTeBbbNkXIWSa3q+osuWGXheRaGNqcqpIzU5tl8 aJFwlHGKQgLXpPxg1s4HGwNG+oFdWQ+TtZGCTZPXpESQgDyePumZ7C6WeMRo4hwF6lYv PVKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685519914; x=1688111914; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nHMZgb7ql614fjK+awMwSPS6BsriEA2nG/M+3wX+ebo=; b=SAsFK3xqo1PqaJLmWt2IJx8Wh6chgp5TMY6z7zqD5MfdFTB03sh6jkS2/ED61CewN7 0xKwhjTm77PRjSq06DJbss2xurYsjDfE4zL9mUcXMnSByBH5Zhz4/YQOtabbL/U9Ujhh eYQXHacpQlzB3PyJluIaxCDUs05HyLskPx61T3KWT19BAtRreXDo83PEpx8faqQdIMpV d58T5kBrEwXjs08aHbFXgaYxGOaDQeBj68SMOtiHpv78acqTbLBD5W3BWUvM5P1MBU8E 5BkurnGBOTCBcDdX2HjSEfyxljYTa1TcTHt3Z5nrPZ7XpNC7iILr3YmoB/vka3ncenWG vdyA== X-Gm-Message-State: AC+VfDysgxuwUk05ZTKlaKYHfCG8tB/vDLM6PmEuQv1GXdgCZzQK1dN1 rFK8pxOolBIZeJW475aDmVQp26PKsrlUv1/YzY+g248PUTbadEOjjDU= X-Google-Smtp-Source: ACHHUZ4msTYDsVRwVxD74zod2Lb7ncBEh9BDQyd221RWNR/YdKHP6jYPWV/UlShu30Tpb9hapU4Y2K4CtbDMbW5NBUM= X-Received: by 2002:ac2:51a2:0:b0:4f4:d41b:f416 with SMTP id f2-20020ac251a2000000b004f4d41bf416mr2067501lfk.4.1685519914228; Wed, 31 May 2023 00:58:34 -0700 (PDT) MIME-Version: 1.0 References: <20230530083911.1104336-1-glider@google.com> <168548824525.1351231.6995242566921339574.b4-ty@chromium.org> In-Reply-To: <168548824525.1351231.6995242566921339574.b4-ty@chromium.org> From: Alexander Potapenko Date: Wed, 31 May 2023 09:57:57 +0200 Message-ID: Subject: Re: [PATCH v2] string: use __builtin_memcpy() in strlcpy/strlcat To: Kees Cook Cc: andy@kernel.org, Andrew Morton , nathan@kernel.org, dvyukov@google.com, elver@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, ndesaulniers@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: p98hi1a51yftbfhe1dzhynyh9z6btmo1 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78FF640012 X-HE-Tag: 1685519916-494951 X-HE-Meta: U2FsdGVkX1+AQWpJlgJnVSlIrARLrVezUHJlfvuZFB1pHZqQTuftkW1Ru65CJYlowA3vTrQhRpb52LvtMoZXyAYftyyMeTAuhXh6xvYEeW2Ujpqp8UGMDsifVbPpI8Nyg7CJ/PxStJ6HJj60sk3UqbfIlKmBoKvdqfmBoem6Ygv9MZOWOlLGNKXgUYJrEDc8oJuPAvQgFYXBPBxHJR+uYOPMgfKCpChGagWwP46+iE82g9TIrKkAXfL9KcDApHG+Ebvfp+5Ms4MtNSXG7uQju5NCxiTqFJcHHOhqKUkBQjdYkVPt+JFxJTQaTqDnt7ihdS5OCMXIQK4MDTQMtR62qId65oxuANXbiPd/MxONeJx44x99ltHzGjv0Q1OAFk0auKr2KI6JJtz+AV7GrMnKoom8ODXCGlHNl64/bg98p5Ntz0SqdFWO/U5Th7cNOV4lomHgzGHUnPMA9R4fQ44DNrG0T8hCthSLx9/3zwCrusefC7Ie/6MhAI163OBHp7jBLKFqCBLVO4PIhJ8KVNZ9p4KyPfyja2qOug2NSRti6jStyEP+6NLTtIUx14u9PVPd7avIfXjKdpywkpwN2XtEjsutawOeoyHCbhs7egMTxqfqF/qo36F4fgPpJo4NWo9qGpq63QkloLsP6b7N2eFZBabKwRwk6jrIWfKnoN2Z1rnyyiWaF+25N0MLkor6l+1Jou8/V1MG1EsW+kvx03WvZIB7Wk6ThVQxhPyMb2cfId6d6yZ4HmH7snvaM/63XmH7gqYryplnYezs9GqTjHAzq14CRaN1xDdP/0KLaQ5uB3MhW5acQ2xpS/wgqNHa9piNE0Whzb7KIl0abLeiVBPuTRecK8lb2i0YOxqp5fsSmMZ2z9rNlboeuIAjThj9f902enOTt3krpr+LFYZVkLh/LJT3bbcqz2c0IN/fJ0Yxzcv5u62fb2ex69jM5S51oQHec0ANtfGgl/XXbCnU77s hlQFPbiz rU5CYFXCCDTLrzyzGe8eIdnX6DcR6WyQrsaedn36GHFkBFhAMZZLqKTQD0Fip4kUztjt5zhUN5ZrdG178SjtoTwkq9Je4DjwakzgTO8PV2Y7WaFjuLWVI+sWyvxQagw0RlCsPmRinVNabzNBojDUEdrsEXKBGwowLQpcedrZSJzyvNyfID6p/l7BQ0fmc1g7anBDmZzXPgZ8CHc55Ugt26Icln86VE2XkbegrdMZfqgn8sdSIrxV/uB+tnoHVFkopjyAWUlXO16l8qHn381yr7bVU/lBUiulk2rr/h/88ZRAiG1rOJVbLfvzOOmwYFWmVBMknVqvj8jSuF1OK9357zgyi1s6DWKsAuB5KOzWkT0ZWdHw4PfOzyQpPhTz1P/IMk0o2XBNLm3jf/HM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 31, 2023 at 1:10=E2=80=AFAM Kees Cook w= rote: > > On Tue, 30 May 2023 10:39:11 +0200, Alexander Potapenko wrote: > > lib/string.c is built with -ffreestanding, which prevents the compiler > > from replacing certain functions with calls to their library versions. > > > > On the other hand, this also prevents Clang and GCC from instrumenting > > calls to memcpy() when building with KASAN, KCSAN or KMSAN: > > - KASAN normally replaces memcpy() with __asan_memcpy() with the > > additional cc-param,asan-kernel-mem-intrinsic-prefix=3D1; > > - KCSAN and KMSAN replace memcpy() with __tsan_memcpy() and > > __msan_memcpy() by default. > > > > [...] > > Applied to for-next/hardening, thanks! > > [1/1] string: use __builtin_memcpy() in strlcpy/strlcat > https://git.kernel.org/kees/c/cfe93c8c9a7a Note that Andrew also picked it to mm-unstable