From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86955C432BE for ; Wed, 25 Aug 2021 10:58:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35F4261184 for ; Wed, 25 Aug 2021 10:58:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 35F4261184 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C93E88D0001; Wed, 25 Aug 2021 06:58:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C444A6B0071; Wed, 25 Aug 2021 06:58:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B33268D0001; Wed, 25 Aug 2021 06:58:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 9547D6B006C for ; Wed, 25 Aug 2021 06:58:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 39E858249980 for ; Wed, 25 Aug 2021 10:58:19 +0000 (UTC) X-FDA: 78513303918.01.3111294 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf13.hostedemail.com (Postfix) with ESMTP id EC1641010FAB for ; Wed, 25 Aug 2021 10:58:18 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id l24so19428208qtj.4 for ; Wed, 25 Aug 2021 03:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=814QjR6zkCfIOSzonK+alcyMN9fiwOlsyyZrKehQu1g=; b=K6fcAHHWrAgkmEvAF4Uj+VXADPTnvvoOnrQsAaxiUpZx4hwJVG58U6qms9C6C8jSar jIK6i7ABOusI7HQR/1V4EdwSDx3AsTjojs4by6/6P4Sgt6SCevsOGab4ba0U3c/wAJ+M 8kIMceHhMRdGYOk2x2e2W2o2CuPJ3jdJx70MBKtG0WjHwXh/y4/RgzRxuimYNdYUUtfP pow+lKGn2eRt5l3bO9WALlTeW1wDQXdjLGH2eMLxc1P4Y0ab0W/kST0aFf9vL2Qi+OLP Jy9fGnACyIq9PiRdUF7oEYCB2i8URA8Q12klTkR2FW32CxIIXTYtWIGIl6NJW2RZ6iL1 M1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=814QjR6zkCfIOSzonK+alcyMN9fiwOlsyyZrKehQu1g=; b=irsFMvtNHq0smJHleDW5GT1IdJQnetqMThpXPHSwWPgtOK0SMJYtZrTuEk6IRBv5fT azXOQOVhQNhR1k9RJ8WKrpkSF2HGp54+IWX4yZ/Gl6X3X+EywpdTdzsIaj67CPKMWmYl 4wYnUNrKhvaM3eLnJMjjGQgCYJJk5XnFW5H3dpnvcEdGA9xRUtL1upOrbt8c+l+NUnYW Dmltf7pF902DstkdMvldlAKi2h81StTxebHNElCZURTB2SMF156fxb1SO+LdKgW0xg74 Y0lQPMVKRc4+Bjicqjl/Ta9TY/azovdx0G4/Cka3EAARDxHqGM/ZYer4hEV0rdrYESwY DIzA== X-Gm-Message-State: AOAM532aSpaPsywayclH6ziPNTlkKfQn5CwaUcNjs/B/PpxmG4vIIVWo QiWGACgOCJUshJgOQzwMDzIuHxG0kCiqqYkgB7YuKw== X-Google-Smtp-Source: ABdhPJzHp8DWDytoQbbdL51Uh4LBATWm/OEylGryBMp5ckAmpks/IrQOnyJ/0aufv06FDV/McCTEPVmBeB6W0EnZcEw= X-Received: by 2002:ac8:46cd:: with SMTP id h13mr39096818qto.369.1629889098034; Wed, 25 Aug 2021 03:58:18 -0700 (PDT) MIME-Version: 1.0 References: <20210825105533.1247922-1-elver@google.com> In-Reply-To: <20210825105533.1247922-1-elver@google.com> From: Alexander Potapenko Date: Wed, 25 Aug 2021 12:57:41 +0200 Message-ID: Subject: Re: [PATCH] kfence: test: fail fast if disabled at boot To: Marco Elver Cc: Andrew Morton , Dmitriy Vyukov , LKML , Linux Memory Management List , kasan-dev , Kefeng Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=K6fcAHHW; spf=pass (imf13.hostedemail.com: domain of glider@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: z749yas88nhxg8tyukk466y3ugg9e65a X-Rspamd-Queue-Id: EC1641010FAB X-Rspamd-Server: rspam04 X-HE-Tag: 1629889098-690339 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 25, 2021 at 12:55 PM Marco Elver wrote: > > Fail kfence_test fast if KFENCE was disabled at boot, instead of each > test case trying several seconds to allocate from KFENCE and failing. > KUnit will fail all test cases if kunit_suite::init returns an error. > > Even if KFENCE was disabled, we still want the test to fail, so that CI > systems that parse KUnit output will alert on KFENCE being disabled > (accidentally or otherwise). > > Reported-by: Kefeng Wang > Signed-off-by: Marco Elver Acked-by: Alexander Potapenko > --- > mm/kfence/kfence_test.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c > index eb6307c199ea..f1690cf54199 100644 > --- a/mm/kfence/kfence_test.c > +++ b/mm/kfence/kfence_test.c > @@ -800,6 +800,9 @@ static int test_init(struct kunit *test) > unsigned long flags; > int i; > > + if (!__kfence_pool) > + return -EINVAL; > + > spin_lock_irqsave(&observed.lock, flags); > for (i =3D 0; i < ARRAY_SIZE(observed.lines); i++) > observed.lines[i][0] =3D '\0'; > -- > 2.33.0.rc2.250.ged5fa647cd-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg