From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1388C197A0 for ; Thu, 16 Nov 2023 10:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B96D6B0454; Thu, 16 Nov 2023 05:34:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2426C6B0455; Thu, 16 Nov 2023 05:34:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BDB36B0456; Thu, 16 Nov 2023 05:34:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED0906B0454 for ; Thu, 16 Nov 2023 05:34:22 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8D59C0C22 for ; Thu, 16 Nov 2023 10:34:22 +0000 (UTC) X-FDA: 81463457964.19.F7B5CC7 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf24.hostedemail.com (Postfix) with ESMTP id EB315180004 for ; Thu, 16 Nov 2023 10:34:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mXNu5ASP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700130861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nCzmGpWmQul4wYiJvXX4QGBTD7ZNE9De5NBHM0dQ8JI=; b=Qweid/NatmD26y5z003fi0Yhqzr9PvI3PEFt0Ur+5nx4lwa8GpFz03q/pENF+14LcSyrXg PHqTPFHVd/FGV5ef+oRdBTLX+4jibphF3Zg3/KFcIb8zsw0XTeQPnFOlNhcmNpeNclEcvk BlxyJUzOIXn5NtFfAzuLno6x2kBInCw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mXNu5ASP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700130861; a=rsa-sha256; cv=none; b=VUTZnmiLMgzOD13/trooCk4fJv9RABJDAbQr99WRihr62pnGP7RvsKO1wqmcgbJNJrX48L swQOLKJ7446fFtmSKlJ1XemyArQA+SmyR78FBQE/bat7j5lbzpF4e08rWTqz1S/Ty9c47D lRQmImoWcZZivUwit2W62Sa4xaIQMgY= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-67089696545so3340866d6.0 for ; Thu, 16 Nov 2023 02:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700130860; x=1700735660; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nCzmGpWmQul4wYiJvXX4QGBTD7ZNE9De5NBHM0dQ8JI=; b=mXNu5ASPLggQ3v/YFSMGl4D2EJnQ+EKR5hHOuu1ZT92k+hR4b9fVd590QTy9NHbnlN 0YXmawdt4v9NbYgEBT1M8AvblNSrneHzlhz+pAk8Nf3FpJxEy2bfjZ7awdHBpgAlduuH 9r+i2NWpcXs2071T3KHs5tlVlnQywVz6Xw9VD/Y9vCSygCO0y6Lquxl5ehUvLP9EDYcq GnNJVj5GdtWCaDHszg+UAXBB2UqsOsBa4NurZ9QZVQWl6TkRCj0QjGhuqLUzmBGa4MhV xHZv17QvT4y3nhJWIcPLGKm2ddo4KLvkq1pPFs4IlH/6jZViWQqV5R8YQFw19KKdMJwE 800A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700130860; x=1700735660; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nCzmGpWmQul4wYiJvXX4QGBTD7ZNE9De5NBHM0dQ8JI=; b=HA1aGdUnD/1zRFQfH2XPOUhnk8pODW/L03Q0UZ5L6eWtpQbctKQEQWmsW5a1vOP9Ty RFFXTTjUMnX9C2pnvzskwW1alIACFTNS3x6Hno9m07a6+8eMPIIwMO9fVQy/MP/N+wYQ qqPQgESZF86VVpr8ZQ2BpS3yTRyGMn+5YP3nLlNWCwC4fsn8E+eSB/x4zhwv3DR/SEdr gDGSOvKLRoDXfwqxHSJU3K1cJz3TYV6FdziczyPOxyB6Bam0cFOcWJRQf21lNgkl6rVe gkUKek007HpGRBSOpZQpR8IOApBfOshUGYgkTRqJQhkVqbejOUim4I1mWdx3tACXBZ5g 51kw== X-Gm-Message-State: AOJu0YwIdHoI1NKeQm2H+yYRgZClWZj0J7Fl3cMW4A5+7eNHZEhq5k/L eze1DD3IAyobae7z2dqxbDBb33d9uys6aiLvz/ipxQ== X-Google-Smtp-Source: AGHT+IG4aY9GHR76tVKMTAGmd0CseNMuUXkNiPOGtMWZyskYlNgHZ6XGDtn1AzcetJJpwAPmQpPFevQ/edxH5B4nbxw= X-Received: by 2002:a05:6214:12d3:b0:66d:1d3f:17d7 with SMTP id s19-20020a05621412d300b0066d1d3f17d7mr7472430qvv.8.1700130859918; Thu, 16 Nov 2023 02:34:19 -0800 (PST) MIME-Version: 1.0 References: <20231115203401.2495875-1-iii@linux.ibm.com> <20231115203401.2495875-20-iii@linux.ibm.com> In-Reply-To: <20231115203401.2495875-20-iii@linux.ibm.com> From: Alexander Potapenko Date: Thu, 16 Nov 2023 11:33:43 +0100 Message-ID: Subject: Re: [PATCH 19/32] kmsan: Accept ranges starting with 0 on s390 To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EB315180004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 96i9hq13t3km7x8u8mz5d86jwsh4rodn X-HE-Tag: 1700130860-558989 X-HE-Meta: U2FsdGVkX1/sU1BMM7FgjMWqtfmEpp3gGvia4+rgsbYXwznBNwpunUSXImGlkyxp+dKOgHcOviwEebjMZUheuVFx0kR5fl/kLc/cqgLsbRM9Oh9qP/F+OZFEaxTP5SA4VyaXQBh6jnh4pnXS+OZ6zn25Pli8BY0ILZMbaZ5dGzntSywUQhMqQcxH8H9hVbUg97XzTFItAsYiddQHL4iXhwMjFFdqnCFQdpm2tq2zKFD7v6MvvJYojXlpliitienyiR341xuXDFkJWh56kshxp0yxSWYUlg4gYl8npdIsIrAy+i9bQ523McD5SPYq2rlxJ8pnL2F5fU+x4ssOobqJr8w6fHOOAv6FT8HLUK0g5WCGY/U+YcgeOT2IJ8s2R46fmGAYaydppIt/r+wW2EA5+ds9Z+Izy8HtRZzKEbfIoK2i8z8u+uRCupaDryj2tDPG5gnLg8wcLFxYAI8cmQSZddDfqcpOSoDppKqfxhCZM2NwJCwUZDHey3cGbh2vIDBngZr+vFjNEDCEPHtO8l87xVTZa4muZJRqKfbKl50tT7D8X2cx/Hn62wgB7W1Obd9J1Locg14/pwFtZcL5T1Tm6FFtG62hhzpJxgBxWsncDkFcXt5xnv0ew1go2XeaHrfbblS3Gk3zNzXyHlvOxN4KhFoKwgUkbrGSTM77954D3juCND1V2M4qzHqO+WQAoD8SbjhzecTEn5q6DC7H3Kf+qYJwDUcsstM3hI7dUlKHSlesJWsh9NR8eXz6FbAScWxc7l4T7sw6FjSNlXUWxwbigqmP6XUagIXa/03ojmAZQj8sanXQ5E1fi2K6uNv7ensLngc/Py4J6XpZBUB9VJfVXRsIZFhjXHTi+77VQRW2ll8kopajDk2tuacaTSge7+1IOpS7LxtEMJocBW1YBsyTrTJhRAreHrMwFWPQoQBFbfH1gJMDnQRDNNDt93BpH8B2FKVg2XArrje+jSglB9D r3F4cqos 3FvdGVXhOBSc5XbeY9Wk7AODQVJiqr5ZBK6jLoExhh7V2sG0rOoxgJ4DXyfhtEdZB6BHOSLUGmmM5dsKLKTgPwMCimVLHZgP/B2s6Lyc14kaLeIb+P8OJlYXB7T/IcLSLUu630XvbooCbtrJkaWOJYqUkzzYd0VDD50D8g9dcUJ2gpazWEmobBigwcQZXigpA8NLPjIsKytHUAkzwekXWJ9alw2b/2fQPD7SFm8XdVv7TVpCAySZtV+LYgi8DOuXTQ8RNtjkIbKMqoY9HXikxmNXex4S/34Bgea5Lp8nZw66Wtp95b9ikUnousT72q/X8c03aTWEuCKxbNKk24mmr/cWyWpDVcAO3BUKg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 15, 2023 at 9:34=E2=80=AFPM Ilya Leoshkevich wrote: > > On s390 the virtual address 0 is valid (current CPU's lowcore is mapped > there), therefore KMSAN should not complain about it. > > Disable the respective check on s390. There doesn't seem to be a > Kconfig option to describe this situation, so explicitly check for > s390. > > Signed-off-by: Ilya Leoshkevich Reviewed-by: Alexander Potapenko (see the nit below) > --- > mm/kmsan/init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/kmsan/init.c b/mm/kmsan/init.c > index ffedf4dbc49d..14f4a432fddd 100644 > --- a/mm/kmsan/init.c > +++ b/mm/kmsan/init.c > @@ -33,7 +33,9 @@ static void __init kmsan_record_future_shadow_range(voi= d *start, void *end) > bool merged =3D false; > > KMSAN_WARN_ON(future_index =3D=3D NUM_FUTURE_RANGES); > - KMSAN_WARN_ON((nstart >=3D nend) || !nstart || !nend); > + KMSAN_WARN_ON((nstart >=3D nend) || > + (!IS_ENABLED(CONFIG_S390) && !nstart) || Please add a comment explaining this bit. > + !nend); > nstart =3D ALIGN_DOWN(nstart, PAGE_SIZE); > nend =3D ALIGN(nend, PAGE_SIZE); > > -- > 2.41.0 >