From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41AA1E95A91 for ; Mon, 9 Oct 2023 12:06:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3CF78D005A; Mon, 9 Oct 2023 08:05:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB478D0031; Mon, 9 Oct 2023 08:05:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3408D005A; Mon, 9 Oct 2023 08:05:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B1EF8D0031 for ; Mon, 9 Oct 2023 08:05:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6935014022A for ; Mon, 9 Oct 2023 12:05:59 +0000 (UTC) X-FDA: 81325794438.23.E206350 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 6D3124001D for ; Mon, 9 Oct 2023 12:05:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c7rpl9Ik; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696853157; a=rsa-sha256; cv=none; b=bbq6GeGYCzx6RGD9e6+aVoMuhA3WSVZBMVxBch+s8woBUdV/HoWZKhZMGu0gmGT2VJQpHA 0g5eZrA1gTG3SJcVKTLBjbo/duXS/JFwTXPCtnEpmXD/QiDGSeXx1Va79OmKaLT1xpYS2X D3HK4gkmYv+0QUv4xe5+ag32L8LXNlU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c7rpl9Ik; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696853157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2VY/6yygJv/miZhZ8h6odHp72SB3kIR4yZRTmobOqWU=; b=FDtsylPRPhbAB5M2ToQieg7r7Nqy1ypSRxfUyXXkE6GcrNIjBD2UWpt5I0t0Xjqj8My0sg EwRMpzJo8njEijLViNPD5RgVHtPyU6NFXBwcUMh+z4LsIsr4f9Eh0kDv4DS/4eQo+2AeUY Gf6cKP3qBAM3Xsx9Lww6YI5eYR5KdEc= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-65b0216b067so45784736d6.1 for ; Mon, 09 Oct 2023 05:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696853156; x=1697457956; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2VY/6yygJv/miZhZ8h6odHp72SB3kIR4yZRTmobOqWU=; b=c7rpl9Ik+2bgG7Lcr/TIMr4/AfEPFNR1A4cDg0bUzi2jaUxkeX88/yTHg3E8q/7iSE GcBlIjY8RCyxFWLwzeaQ/NV0bg643IcKbAAprUWgWwqRNkbG8fXsyM7mVfJVzX/N0QQE EVo/4YNx5pRXpB7X3JOiQOLmp9wHeyuyya7x7Wa0qVdPXRCCqiZEhWj2ba7Dusp0Nke6 eJMcqThZhMzd9w2OM9Mib69uwXlMe1Bnao2rYQV5Ou+1SInlwtpcTpyFMim1ZHdNmjjl PifjCPbM5ZkA4yRqOPK1NCflwp7hHQhBtNf8D+IW535UH3f3KXgmTYqR/ZOdEGIYC6Fo nDoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696853156; x=1697457956; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2VY/6yygJv/miZhZ8h6odHp72SB3kIR4yZRTmobOqWU=; b=Ps82cYLgptkWL2hKoUsLto22q+kdhXcIsJ8489z4y8wGGciF+CbvhDaZ1bDXsKwhvj eGoeaGa0R2QaN29D7WsxQAlfVa/xpmtUmC22i+kUdi/23rIu5n2t8rg5Qiv9rcaud+FF ei6TLNDwufZ4DIfYrVw9nQEHsgkaLED/pzNMkw5ujZIIv8MF4wjSsYM43XPpInFBxBDB 96EUqtTyyrtRBGazWE6SYuxtO6uBSI1S0nuqDigH6aJ9C0gd4KWoNg6mNdoEY0xIPlSn iH0ynYVyQNP9wJNZlZX32vjxvlGWjoV6XbAKkWd7MLAyc9AntzNAS94LTbxny6WnlwOi e/1g== X-Gm-Message-State: AOJu0Yzj4GbHKaQE8OS544YDjo4j0vqA92NmT6+h71gTPbk7vP1DKOX3 4KlePXngY/BId9sbO77Np9S5WoWiUNv6jtqiKyuPglHeEzcXUVEeCpY= X-Google-Smtp-Source: AGHT+IFrjSRXPfPjjYka+W0FmZBdaoIIqHaKOgYlAXf2BmSBCfxr3bTODKn0BMDjv6ZYP+4c+W/Dec/C3Izyg7gfKm0= X-Received: by 2002:a05:6214:762:b0:65b:72a:78df with SMTP id f2-20020a056214076200b0065b072a78dfmr16256736qvz.10.1696853156331; Mon, 09 Oct 2023 05:05:56 -0700 (PDT) MIME-Version: 1.0 References: <556085476eb7d2e3703d62dc2fa920931aadf459.1694625260.git.andreyknvl@google.com> In-Reply-To: <556085476eb7d2e3703d62dc2fa920931aadf459.1694625260.git.andreyknvl@google.com> From: Alexander Potapenko Date: Mon, 9 Oct 2023 14:05:16 +0200 Message-ID: Subject: Re: [PATCH v2 17/19] kasan: remove atomic accesses to stack ring entries To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D3124001D X-Stat-Signature: 1ou5qwgt6c8frqd76hwx5k1ee8nogtok X-Rspam-User: X-HE-Tag: 1696853157-832499 X-HE-Meta: U2FsdGVkX19r3Q+P0fcfKZ6NjPjBb/73kOMTySVBl+Y0GfMOFdUkAo+yDIUz30aqXNyA6GEkf79BywytjgPLqObvoywVlaOJ6vS79xn6SWc9yv5RNnJAQGRExnlt+cE8r6zs8VOufPV4mrjxjyHtTKA4xl79BFnrxaaKwKUciM1R93QfoQNQUYFKlDgcx9WFdYoAqNjYb/TOO9N3ruXHTGnHvr9tLSjfgWPqC/Lh88wrwQ2hk95mWUOwQPxjJjAbhb+zDdKYO8Z1XUcECsb682ekWSUZhhnZc74HCaHmuOa58s2OyA7leGGsmHYIJHj3ODlX7dIwzju/gc/r5DWPGSHHgRymZuLioNoV3cdF9ZTzHXKMMpp3WwnRA8daBNN/KrW+XLQvmhobIHGOhGbclHkkLVgugbfPf8kgFJwD1wxIrZxPbCoJjbmD+SmBHhSrE2qnm2n3T7GLRNwPWr/qdfqVKd4vE4/ATwnP5XuvZ3TOEMw/Sto5GuIfDXv6lQheSlFxH7ndgUSp9AvsxtJAfacBDtHD+qLGbA3X6Es+UGzEeGjfZYKRfkNGd812KBfctS93a99e32VKU+TJ3j5gfG7xwS4cpo3AgGmQMpD2fGGup5DOKLKlwYxFiiCQypgqHeFyTIpJ7ObF5Z77vSjyhHJFru8UhrhsgwqfP/nqCRzP1mGMEZi4xAf3mD25Pg4Mb+k5+8VEiB0K5LjPXl7NjrQYaX3bH8oWZNb08BbR0cae4yVTZ+Y6vd79h+BlCz9dHg4r6wxD3JV+RYHijA8rvyFXVQicATwLkNFaM69ko99Xvn7tUoPF9jQQHf5Xi6LzEbRh25joMA7/cC6VEZWLCJGfyyEJVxLou8zekKW1YVcFf1wH9xS1RzQRRZttnmc+XEHjL2/Fp5qjtFDGgXz+1nzfddULd2YafIDL6s+vCBCuyo5ujI64r4Vn3VaXM194wHEFVZ5aMgzxherSJV6 BPCU4CdO Ct1fAWRVhWryYy8d+mHQwZtWBu+PE9n51W4f5sZzeMtAYCsejdYzu9hEkse/UH3sbc2GY63pAlUchncP6cOLSv3tAF9CGQF2z73ZYfYMv3eL/qcieG5osgZA2i81oGz6NIr1Q8UMmZAYb/wWp6FExadB6K5o4S94t+I099sbWNvAUS/QW7C5iITDB10svuVy0dQwX6wHbJXsDh4lgK+r9OHGgJbSX0mMuG373w2hfubyItCO/tWnj+m6G3/Xw5FqRdpvlcAAMmGkyDOkR5UCi2+xpFPI04YaGgGux6MtgNuuCSf5EPByGL7P4wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.018901, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:17=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Remove the atomic accesses to entry fields in save_stack_info and > kasan_complete_mode_report_info for tag-based KASAN modes. > > These atomics are not required, as the read/write lock prevents the > entries from being read (in kasan_complete_mode_report_info) while being > written (in save_stack_info) and the try_cmpxchg prevents the same entry > from being rewritten (in save_stack_info) in the unlikely case of wrappin= g > during writing. Given that you removed all atomic accesses, it should be fine to remove the inclusion of atomic.h as well. > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko