From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCB8C636CC for ; Mon, 13 Feb 2023 10:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530E16B0075; Mon, 13 Feb 2023 05:36:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E1BA6B0078; Mon, 13 Feb 2023 05:36:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A9F06B007B; Mon, 13 Feb 2023 05:36:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2AD046B0075 for ; Mon, 13 Feb 2023 05:36:10 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0B8A160CEB for ; Mon, 13 Feb 2023 10:36:09 +0000 (UTC) X-FDA: 80461913658.06.6B269AB Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf26.hostedemail.com (Postfix) with ESMTP id 35667140006 for ; Mon, 13 Feb 2023 10:36:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IG2Iretl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of glider@google.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676284568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MB6QgxzH0xV/jeUMQj67Vw4mnLp5zoDu0fxoHPLQUaA=; b=YEU6VtXiZsmEW1xyYUyzkFmG0gpzSUF7JrEZ7gNf6rhpFsetO0cSrXFclPCr5neeJZS2sq Xnb/Re0CPyap7DaseLPWUO2TGkhveW/Lk1HWVu1gKq26eyVdDwJd+LiVGVfezorxZQ+bTF pRBJ0WCwAtgW+pBs4AtH5EIMqMvB98A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=IG2Iretl; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of glider@google.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676284568; a=rsa-sha256; cv=none; b=EyIAJ1/zUgulZQszG96zn3rXh7YakxmfJVdOwIiR0mid+7UwDaEpzPg7Y5IeNbXJYFohB6 M9yFED+2r9P6iGoo5aK2lCPEXqUQgD/xd3mDcS/T9IsofKxRyhDmljfBN5kzwweSqiT11V QzVSSiY/9d5Wd45QbNgesWwZ5u3909k= Received: by mail-io1-f53.google.com with SMTP id w24so4295717iow.13 for ; Mon, 13 Feb 2023 02:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MB6QgxzH0xV/jeUMQj67Vw4mnLp5zoDu0fxoHPLQUaA=; b=IG2IretlOcw+z4pwWWM5lSZI848RIW7S4QEelsNLH0uDw+n6Ns7ANXKOUPM0VMwtT+ FzgirQFCKjkU2mMLnK/7GAqSNJm+6PH8vnL3FY9QrVag+MDyOxs60zYhNzkxMPhP/n0C 62w2svDn85cJQraYhO2HLkuCeEiSfhT+yyBe4X9dJlkDLqoxYoHVogY17Svp7/HaQgUo uoQZn08BjjI2Hkq6ne85hJbK5MEqRfSOUXPyEK/UdwNS9p3TcsQxe0KML2Uq9a7DXjbM s5B0CfTNOG7Pj9x1yup/qcDVQvAlXmjrNSU1/5M7hPKwcTXQTURJ2b7RJzjxvEjpcEe+ xa/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MB6QgxzH0xV/jeUMQj67Vw4mnLp5zoDu0fxoHPLQUaA=; b=oTSUKty5J6TZIKQVaeqDg00TTxKnoRwC32DJ9g1DBtns/KaIlRia5yn3ORvEbUQtri ysK3WULocm9YGLoY7qhoQ1rzH9cLmFQU2ntrWACUrEih12mk24m+/BUEyV8g3gdENKeS ClYBp4PpbJrYsbo8fdONslO1OL3huNvlt0bHcANsMTVhOPPqjEA9cVfEjuwdE9neEqds y2rIc6DFS82RKnOoKDjnPrxuzbajlFPZSd+dNGCvON1FT6xQoJBqOJX5B4PJorc/kStf 5xDBXSu+8/sP+5vKYkEDSx2l9LOrzWQ45r28DF0/joFTYfNL8UM7xJPYIh3NzdLbKV5A TWlg== X-Gm-Message-State: AO0yUKWKqpQhZF1f5Ar9iLd0dXHb8BYQjUlkAhPno7O8HLch+4ChfZ7l LzTqSsCY30A3/Hs4istspSms55IutpONe/u+o7i91Q== X-Google-Smtp-Source: AK7set+xYzi0y7mls5yH064yKj0n1VIpNRvrSBS212i/X19YyD1Tom5PcHDLJ4Gey/fWP9Ef0SQi8iqB24Ns7fnVDIA= X-Received: by 2002:a02:a794:0:b0:3ad:3cae:6378 with SMTP id e20-20020a02a794000000b003ad3cae6378mr12237646jaj.16.1676284567286; Mon, 13 Feb 2023 02:36:07 -0800 (PST) MIME-Version: 1.0 References: <923c507edb350c3b6ef85860f36be489dfc0ad21.1676063693.git.andreyknvl@google.com> <2085e953-ff9d-4d2e-cb35-24383592f2c4@suse.cz> In-Reply-To: <2085e953-ff9d-4d2e-cb35-24383592f2c4@suse.cz> From: Alexander Potapenko Date: Mon, 13 Feb 2023 11:35:28 +0100 Message-ID: Subject: Re: [PATCH v2 09/18] lib/stackdepot: rename slab to pool To: Vlastimil Babka Cc: andrey.konovalov@linux.dev, Marco Elver , Andrey Konovalov , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 35667140006 X-Stat-Signature: 15b4zprx4c3ogofg66z9arefn8m64tuw X-HE-Tag: 1676284567-201407 X-HE-Meta: U2FsdGVkX1+HMrrkFb9j0Mq5OdYb4MAjf5BLEOAbM+3DH4YtQN4vvM3/3TbOrzG3143yQOo+AJBsDTfuhzTXJZ7J/tzqKensfseUmoWcZL4ZMx7uQ/KM+pxj0L6UxxLW04UxV8yb/1FIOesC92ry2PwsVbN4lohtf8NN4cY89TrQZ4FSt/Hy+Kd7Leg7px+4jqMEnWzIQk1M/ArWuXBKbMXDnbiV/mhpckutytI/Jrun7s5kqhFDxMg2GZ9A0YAEVYBEMf6o9T/I/TuKietyHNb2UxkwJljfisL1OJVwUDGQD9aUahdS3BNQd6vRDS+iN6MR4TAwUoroRgvgQP+kePbvt5I7TuoUYKDSExJgF7tQtJNfwKMtMuWDHx83u9uemFe2tK4u5XoF4kt+nCjnFLEs5g6cNuyzsiWih8AlkNdwezWfP8115w8Z+QaaeDIet2rdKSXpOyjBWsjamhHW37BeEyOOeeuDKXpqdZR9j/DX3egRBODKqMl4zteVZjLcvHRXFhhoFCHWycUxoVGdOEzEhpep/rZbrHYe1VAHoEqtHUSRjE4nInThnt3O+SGaPFom6G/7WDgBF2IFov0CjLHZZxCVZJO8jIe4aVMbnzVZ0OsBnYKMhdopPHJTc+EcyHcmljxRaOKEkbg7jzmbaEyK1vkw01ieFCQ6uKgEbrB/1q0fmkMWYuu/S8UpDibWuRX85sw3WKshZtQDxVGiRF15WMAMp5/s0U52ScPyPZdZpffbVdTQ5pEapnfGbvgCID4aBKI9vjhu9RI9OwXglvh7eVooSy2E26QZWC7z2AE7MsViaUeAN0eLdHAsYgxXP3ABux2j6UjDiyEm5/dn+Mbr259UKUjUaU6FBvvVs8exRxbbQiTQHHk7pMnwYDOslh4jypEs3nOjwVxqfAiGGOA74dxKiokuNrga2+vPutViBwzaqt0QpDPrsH80QSZFUj/fNUzR/q3qoT7CFhE CKO2Ros7 7kv//hq4EIG1HIue7+rKWQxiCFyTIIxN+0BILOVXAPMnbgTsuARP0XWjLYyAW/AUzjm9Zb4piDIsSfjgELHR8LcUu4Yqt/9nY/75QfADwbHWkzIpX8tl1RPe5jv4cCy4J08iPYXvbFKOA+miqtpvGPFv9qMDgNuPGB4YNT+kAC0CdlwkViNnfXljptN4COHr6ruGGRZcjnKqXZdtgum+atHUL285tD0nwCjk7lgmqhXj6RDj/tqBYvgphF0wk0xCRur8Oyg+aUgCWrBZlADpVbyWBsUhMLQIfutG8vZShdtw/ybc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 11:20 AM Vlastimil Babka wrote: > > On 2/10/23 22:15, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > Use "pool" instead of "slab" for naming memory regions stack depot > > uses to store stack traces. Using "slab" is confusing, as stack depot > > pools have nothing to do with the slab allocator. > > > > Also give better names to pool-related global variables: change > > "depot_" prefix to "pool_" to point out that these variables are > > related to stack depot pools. > > > > Also rename the slabindex (poolindex) field in handle_parts to pool_index > > to align its name with the pool_index global variable. > > > > No functional changes. > > > > Signed-off-by: Andrey Konovalov > > Acked-by: Vlastimil Babka Reviewed-by: Alexander Potapenko