From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16571C38142 for ; Tue, 31 Jan 2023 10:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A75F36B0078; Tue, 31 Jan 2023 05:43:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A247C6B007B; Tue, 31 Jan 2023 05:43:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9132A6B007D; Tue, 31 Jan 2023 05:43:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8430B6B0078 for ; Tue, 31 Jan 2023 05:43:35 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B81180175 for ; Tue, 31 Jan 2023 10:43:35 +0000 (UTC) X-FDA: 80414757990.20.65D0BE0 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by imf03.hostedemail.com (Postfix) with ESMTP id A89AD20014 for ; Tue, 31 Jan 2023 10:43:33 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=enJHYOBV; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675161813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M753LZjz9jIM5UZsN6i1l5g2fsIv/6aiQIsgYIsM+/c=; b=4djepc7JKThDzzWdcqiUZl2ExAM76iO55FcQcmn/5dlHQ7I+etBqkYMUtLW+nxXU+p6ikQ UxfiRQ74TgMIlFiRByfyVaNTT2WjnsL1uDTUUIxsdDa4xlWjFNEb8B6Zf7nszK2IFRfiQb bKiTU7eWJLAB+Whq7ZZpyEA18cGe42c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=enJHYOBV; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.217.53 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675161813; a=rsa-sha256; cv=none; b=6NsU4IYdZx2+yCxdIkUXcS2JQBSrLLz2l7WTbEUVNwBPyR+xauib+Wb7mTDSTN9yzbM4yU lTjcSlAU45LlMzpVf+l3lIDz/FFjzw/L6Av4GKeDgkSvpmBcChi68gawFXmAcdg4Jsf05R W3m2HWP3v6I9dcH+lOybE14MDMz5ViQ= Received: by mail-vs1-f53.google.com with SMTP id h19so13811330vsv.13 for ; Tue, 31 Jan 2023 02:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M753LZjz9jIM5UZsN6i1l5g2fsIv/6aiQIsgYIsM+/c=; b=enJHYOBVZFEP+cfsiWZz1361EcSHN2tXhM0kwfSjnwjcvxZI8G63emelBbN9BxT7T6 QYtzHs7d/BhL67M6Upn6azzWdc9GTKm3ME1BTDf0UpEhoEyQOwK8NJ3yrBIfDGM/Hx+E qzN99hE0qUIsi7euMl0j6eK7HlIOi5SUSVGJb78z+a4p7okqPCF8fkbHUTxo/5+5b5zv mEkWVbsKwgTdvnFQsoXQpxYyH4bDlN+lNsZl4d0OcA5GYS1s/dnJK870yuWAlYjno8d9 +/rIhv/Qk9+CpzdOrkC+MqcpvZmevXFd//udWGPSFbystpA7YtZ0zUI18HrYO8vHjNNA 0J6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M753LZjz9jIM5UZsN6i1l5g2fsIv/6aiQIsgYIsM+/c=; b=ZKdXMysmzS7cnWtI4aQByLqCAe1y0A4r5O7ux5ntrfk0KTeWU83BaQSoZe+Z9VWwjv 70PXVO1N0SF+asFXVX7U34aDxSw3TvnPK+K2PZENxOBTBsnkHlprJnNUX7OPWr67bPIH vQxc58+9sUEY1KRZ0J2uIXPRZuAc0LG5K85sCPmaSG9tixFiudiAKDfQgWP8O8j2UiNw Wiu4p3iuj/3zq5qSEgCPXKeaqJqFEOGWimmi7mUReePHpcONU8/lFl+ChTHMQjGnuPQ+ KTtY5hZhQDVdrxNYB3dOmV+zhoklw5MoVTxo6mITzczwuAMuzS4tKf+7/lrp7Se8PKor OlLA== X-Gm-Message-State: AO0yUKWzASJo28WPF9TEsnPs/KtCyUnjlpXOhsSeLx/0LUWSnJTGNdAN 4kHYoPvB2dxXXY/T4cNcUH8T09E46u34FhbHhOSagw== X-Google-Smtp-Source: AK7set/UCy97NS1OgWQ3E+UC3FDdA9Pde6pSsrUhHtJ36o7k6yVvsdQHeHE1uwGPFI29ub2qTqgNXtmMUSlSs1QBEeg= X-Received: by 2002:a05:6102:449:b0:3fc:3a9e:3203 with SMTP id e9-20020a056102044900b003fc3a9e3203mr634380vsq.84.1675161812760; Tue, 31 Jan 2023 02:43:32 -0800 (PST) MIME-Version: 1.0 References: <4ed1d0828e837e15566a7cfa7688a47006e3f4b3.1675111415.git.andreyknvl@google.com> In-Reply-To: <4ed1d0828e837e15566a7cfa7688a47006e3f4b3.1675111415.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 31 Jan 2023 11:42:56 +0100 Message-ID: Subject: Re: [PATCH 08/18] lib/stackdepot: reorder and annotate global variables To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: c5fypmi76j6roeu6mdacmhg3dwjxijm3 X-Rspamd-Queue-Id: A89AD20014 X-HE-Tag: 1675161813-552196 X-HE-Meta: U2FsdGVkX1+pIJ+i0t2vlTikzOSGwyh1PM4wLAxzG6V3J6L2GQzX/UNDgRNmst+MI5cgD2drCQ4e3kdLrg13A4LhlSsz8yxBNRoJeh0cRGMs8gbh7qDRpFSCLPIjP+2eDHQOKcxOyS3/X9JlhUcFisN6pm7esJejHxY+9lCM34vM63RcwAGEXd2w+EWb7pxONR8MG1l+G3E5jU6My93k6KLE5MggSbk/jVjryWQ902U5mtupru3uTaDzx3i5X9K/iNjsPTBBVMgakubbCWfE8BaQJOJSRhbD/dTme27vKpwf5Qrd9DQEyeXMque5tc5kBERlkqmvdlFSuk0WkhMlkUukmOFvIQd0H6YXkSrVQK/2evaKThGT2jvlpATvHw1uTnFOkig/vCOhfy0Eb8Z5DuS9V2WGkNnfrcfQiX/Sp11oDq7CI0JPKqjHqiTh1Cl/5gk3T3CEQERc6zCFUDVTG4s5T8V15mVKatzam0fEcFw1V27/I60ZKDF45iHUylhzOFp+snwyKDC4BmFOWT4XVcsS635o8G/wNwswA3sIWSlkFknQH0b+bkxARmsOytle8pGQP6BqgrlZwp2vW45aZ5lyJibC9r48Y1eLLxCnM2mcqAgSf8dWGef8R803rt9d6P73iJA7cjHqjV2lrjNcaSNgWKzB2Bov93LNyh+8vcQ0vE7R6+q9Qw23f1Gg1Qo7rW/H7ocFX3/Wa/9cOow+DejN7N9NpbGZIU+lxjTPV31MNggkueEiYL99s8z/xU7WLhsBJKXJiFwimWZFzhkw8biIFa2P6ccJ4q9zwk8rAdf4vkWXO4LMImQ0fbZplHqH+2HEqeUXSbOoAgD7rmxHa4RRvMv4WCq9fP0pOVPiZL4566Yb0CAjmnPNbLjmd1/0mOOOHQWH9MnvsluxbMhPsPn9wUTPi6nbwseIJYVyd41JJyWv9XEVVUxYFlhmm33j7wvonTq694haCNLpBCb QaVevEWn mzsFDQwdGIXp8uaX7QtiafytPOk1v2q3GBoR8fcTYR8IUGrSFngx8xMdrB3IylOLu7H8ki0bNLZcmZMBDCJXPp/tw1F20viXlO9tT8qo08QVfuaeoduI3gku9qX4y9Kk6Ca66eNZFqSUi0pPgJbUGzFud4ZK4sho9D70XBL4/4SfuKVOYhJy8cfCaTY9m1hPKP6xyEd3HhvnrH8fLG6mWPNUrGfpihfrK3QfJbkk4feFw/1YURi62jSKlfqy1GlXzHmatcC1lc2u6sWwzDii0CAJ8eLqVpqVjqHnoW3H42tCdT48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 9:50 PM wrote: > > From: Andrey Konovalov > > Group stack depot global variables by their purpose: > > 1. Hash table-related variables, > 2. Slab-related variables, > > and add comments. > > Also clean up comments for hash table-related constants. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko ... > +/* Lock that protects the variables above. */ > +static DEFINE_RAW_SPINLOCK(depot_lock); > +/* Whether the next slab is initialized. */ > +static int next_slab_inited; Might be worth clarifying what happens if there's no next slab (see my comment to patch 01).