From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93467C19F29 for ; Tue, 2 Aug 2022 17:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDD246B0071; Tue, 2 Aug 2022 13:29:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8C3C6B0072; Tue, 2 Aug 2022 13:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2DBE6B0073; Tue, 2 Aug 2022 13:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BCD816B0071 for ; Tue, 2 Aug 2022 13:29:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4F00B1A143A for ; Tue, 2 Aug 2022 17:29:40 +0000 (UTC) X-FDA: 79755339720.03.C5BE943 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf12.hostedemail.com (Postfix) with ESMTP id E301A40117 for ; Tue, 2 Aug 2022 17:29:39 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id y127so24648582yby.8 for ; Tue, 02 Aug 2022 10:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=MvRBkFzdQaYaXfpQTRaszNRJA99lxIjSlE2BIJqxf/w=; b=QRi9qghYw00C8ncMgz03GPp5X4XZwYBjLhTst+txxvrrxIKQSUmvN0iydfY7XxTRPZ FljvcSTp2ADimYd7Symv/nntq6KpZiWp6d//C2GypYu/OlpHeLOtYJAAvDcymW7JC3z0 vFmHS4EctNa1FeEfaDLNxOsvpogUFSLuXoQkFy1gkjcrY42Fcsk3slvwkX0sSHWa2PA+ tx4YnR0p+wucGibEbwhrHFYXYZI38NDi3qKYYQnitOrDk170nf3Jt8K81Ues6I017fas rtIy9n7wsldT5qtbZc3Up54mQyY1/O/xbkmoCTmJ7Qwc73uY29KBeFOWyQvihRzUNGNx LxaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=MvRBkFzdQaYaXfpQTRaszNRJA99lxIjSlE2BIJqxf/w=; b=g9R4daPRI1DYM/6SwfmQbs7U9SrfTjq0pBGW2hpEf1rT9o6RxgABMVcIAF5RJ2hc8y 18XNdnGFA0UlspW80XNIANkFqPyTQgP7froSntOMR4orvFSADWl0J2/QBb3Qcgaydwgp DLEsZGkK/rRRJzorlcrlqbrNv6A/Y8Pqak1I5VnGWtqAv91+XO/EKsPeRZ/R2EJBCz+a lvD2jKYoxe83ZRo9zg1CwFu45Rl0zKePWYuQrGRxKkKnPv2fDbB8KGRVJ1D8zBj/6a9t DmDHEYoQha77gKHHbIh5oEOh/0A6VGuNM8MvFHoZj7mR9EjC6NMe+/qRvc+okU+Q5pdt QyYQ== X-Gm-Message-State: ACgBeo0Lo4y1T+S2/kMLhiIGAEshYaGSbdQDEq7s8uhRh/S/Bk+fQclm MRnPH9qqv3bnkQah/t9BCV0w6rCu1TQmKzIupKpxGw== X-Google-Smtp-Source: AA6agR7VtR+Gv6MIRMZVXbACWuJKrFK4u921sU30CJ51jY/b/Dg4+iYwU/syVU8A9VvADNQ3PrTrNZmZWMU0fOSHqlA= X-Received: by 2002:a25:bc3:0:b0:673:bc78:c095 with SMTP id 186-20020a250bc3000000b00673bc78c095mr15729538ybl.376.1659461379014; Tue, 02 Aug 2022 10:29:39 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-26-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 2 Aug 2022 19:29:02 +0200 Message-ID: Subject: Re: [PATCH v4 25/45] kmsan: add tests for KMSAN To: Marco Elver Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QRi9qghY; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659461380; a=rsa-sha256; cv=none; b=l4rhpFWmlo5IXoBdJYeITzS/bHPc0JN9yd87bJQYPtHGQxP90ChzFwCEUqP3RTouX/Dqji zr/E8UxMLcfpykf/uWNSJ1/Ra52/rEKQEyF4a5iINto2JD+o5I+OdvpBb4AhU3kISdXeOQ xU5FBJIYt+G0aRYSRx3hmFq2z3w4KeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659461380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MvRBkFzdQaYaXfpQTRaszNRJA99lxIjSlE2BIJqxf/w=; b=bRESmZoQdMASd3WtkHe5jEIpn8SG8KfApjn1nugJ2Ky/P0WsVzNQd/vTHp0Ms8JBPOC9K1 5HSJDZt0q70NifF35tpIjOJ+JyEz8OuJYm+OXehoFUsQrZvtAR06cYFClgbSaw+c5OLPbO uksuqCdayUNMeEPdMQD7JpN03TZqBvw= X-Stat-Signature: mi4kntuaw1dhzwf7wettn3zm6cpyitta X-Rspamd-Queue-Id: E301A40117 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=QRi9qghY; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659461379-805138 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 12, 2022 at 4:17 PM Marco Elver wrote: > > > +static void test_params(struct kunit *test) > > +{ > > +#ifdef CONFIG_KMSAN_CHECK_PARAM_RETVAL > > if (IS_ENABLED(...)) > Not sure this is valid C, given that EXPECTATION_UNINIT_VALUE_FN introduces a variable declaration. > > + if (vbuf) > > + vunmap(vbuf); > > + for (i = 0; i < npages; i++) > > add { } > Done. > if (IS_ENABLED(CONFIG_KMSAN_CHECK_PARAM_RETVAL)) > Same as above. > > +static void unregister_tracepoints(struct tracepoint *tp, void *ignore) > > +{ > > + if (!strcmp(tp->name, "console")) > > + tracepoint_probe_unregister(tp, probe_console, NULL); > > +} > > + > > +/* > > + * We only want to do tracepoints setup and teardown once, therefore we have to > > + * customize the init and exit functions and cannot rely on kunit_test_suite(). > > + */ > > This is no longer true. See a recent version of > mm/kfence/kfence_test.c which uses the new suite_init/exit. Done. > > +late_initcall_sync(kmsan_test_init); > > +module_exit(kmsan_test_exit); > > + > > +MODULE_LICENSE("GPL v2"); > > A recent version of checkpatch should complain about this, wanting > only "GPL" instead of "GPL v2". > Fixed.