From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B61C43463 for ; Fri, 18 Sep 2020 09:44:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6174A21D7B for ; Fri, 18 Sep 2020 09:44:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sgJDFSBw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6174A21D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D35376B0055; Fri, 18 Sep 2020 05:44:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE4596B005A; Fri, 18 Sep 2020 05:44:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF9C56B005C; Fri, 18 Sep 2020 05:44:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id AAA4C6B0055 for ; Fri, 18 Sep 2020 05:44:56 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 714FC181AEF1F for ; Fri, 18 Sep 2020 09:44:56 +0000 (UTC) X-FDA: 77275698192.25.cat88_08110482712a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 4FBC01804E3A8 for ; Fri, 18 Sep 2020 09:44:56 +0000 (UTC) X-HE-Tag: cat88_08110482712a X-Filterd-Recvd-Size: 4439 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 09:44:55 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id a9so4879711wmm.2 for ; Fri, 18 Sep 2020 02:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LO/JMXpkI2PbHh8j0Ay5k/YAYJdyl7P+uRkiEmvpGOA=; b=sgJDFSBwBWkR4r6tUV31bj4R0AUbSy0wtklvn5xEw2vvcYwAGXSY7CjqOcb+me2W2E HCjXlUeYMSLimOkA2DEmMxyh0g+7IIaeABsxVKExMTdqDQnJZ9fhb2ZmkECu2vSrqjRC LxgRp5gHjRnvdrKtIG+sr5IQdoMwok9Q81IbIx3QMEHyTbM34Uu7uwUnnG99BfXU+36W FHQnUz4PaqJZRkwxq62zpdcYvkXSH8w3lqER26ZxkIzi5SGkKGYDf5cbsOxpvVuaAr8h rZRqv137Xt2xILlIP553KGh4xeG81xYMb/c6h299ZX/wlKeT6q80w9EoxZnDY7NeaAS5 lwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LO/JMXpkI2PbHh8j0Ay5k/YAYJdyl7P+uRkiEmvpGOA=; b=Q/TmHp3iQcND+eugSxuJByqfRfYrEPHBEzz+YMKq1MbcmoVv2mJckyXg/E744H0K6p Lha0obXJ+eIsxy5fHTxT4JlgsO/p8Ab6IZVEVFnjORzHAVedLUxYrMYKZm51SC9v3vPC ivNBhVjxIbPapylxbHVmm+6l++nrrJBwhf0eEGwIvvKWx6ZvZ4lnGMH5FO0DCg0GPWj+ DYcFZvJIeDH+0dfD3+JPExdP8JqtUNq1W4mLmwPBLLd2pO3UxREIKAiu9R5ElgSIq7V+ IMUDcwpYW3iwdVV9l9whoa+ZQjepfmfRg447bjpeuJlYqMoVjPlGME1fC6A0YkhUCcLg AIUw== X-Gm-Message-State: AOAM531YYPws+s3NQsTRtbjGIZE3Iv0iD02Oq+ibFBaKMwFlrLzqo1rr RgTuxe3K0W4zenbv7ZZoHw/3mFdFb65UdsdpAyrZDw== X-Google-Smtp-Source: ABdhPJxPu/JsT3aBHGWsZ+LNZb9BB6Ax2CHDkSAmGDKE0bo1brBQseXtrCYgLaGeTibTZojfKGrx0Dsz4otWuJoOhps= X-Received: by 2002:a7b:c4d3:: with SMTP id g19mr15304732wmk.165.1600422294758; Fri, 18 Sep 2020 02:44:54 -0700 (PDT) MIME-Version: 1.0 References: <28d17537bbd029104cf7de4f7ca92246449efa50.1600204505.git.andreyknvl@google.com> In-Reply-To: From: Alexander Potapenko Date: Fri, 18 Sep 2020 11:44:43 +0200 Message-ID: Subject: Re: [PATCH v2 20/37] kasan: rename tags.c to tags_sw.c To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 11:41 AM Alexander Potapenko wr= ote: > > On Tue, Sep 15, 2020 at 11:17 PM Andrey Konovalov = wrote: > > > > This is a preparatory commit for the upcoming addition of a new hardwar= e > > tag-based (MTE-based) KASAN mode. > > > > Hardware tag-based KASAN will also be using tag-based approach, so rena= me > > tags.c to tags_sw.c and report_tags.c to report_tags_sw.c to avoid > > confusion once the new mode is added > > I find it a bit excessive renaming the same file twice in the same > patch series (tags_report.c -> report_tags.c -> report_tags_sw.c) Also, as we are going to have CONFIG_KASAN_{SW,HW}_TAGS, won't it be better to call the files {report_,}tags_{sw,hw}.c ? --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg