From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A5BC433EF for ; Mon, 21 Mar 2022 14:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B66456B0072; Mon, 21 Mar 2022 10:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B15876B0073; Mon, 21 Mar 2022 10:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A176B0074; Mon, 21 Mar 2022 10:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 936296B0072 for ; Mon, 21 Mar 2022 10:13:33 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 432C9A3EE8 for ; Mon, 21 Mar 2022 14:13:33 +0000 (UTC) X-FDA: 79268586306.24.DCAFEC3 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf27.hostedemail.com (Postfix) with ESMTP id A618D40031 for ; Mon, 21 Mar 2022 14:13:32 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id t7so11951954qta.10 for ; Mon, 21 Mar 2022 07:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SpcQ2fQs0B6gsc0zmrC1AWzw07HBH7voJSyZVgn+CmY=; b=YMmPb6ufUoPO1xJawFqx/pw7tcukS4GdHAOpTMI6TNm1HeyLUsenwKkAlmFC5sskS9 G+wNHb8XVZRirIOXD5IKpxnzUczJMsQkb3lb26bM4xIpkG0BSfd+K9hOZug87/lkap3n loetXdhMOO4esSZ12p6xttO72PGLNa5Hjolu+3w+yQPa2P/PJi6jx/BzjMHrk3CRVets x7Dsj4N9NW7rj0axqNTcVj/HX2wMlYDfqvxQ/+uge9Lm786bX2wDZMSBj82IRVskN39c UY8Q8tqzp7am3VQ1xUTUHBNkExHsBO5n5rJvr14CodpI8BFubxJhna6n/VaZsQlP+qru 6A0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SpcQ2fQs0B6gsc0zmrC1AWzw07HBH7voJSyZVgn+CmY=; b=dVpkOw6B9BBxiucSxQRG5pdCf//ERfnIeb2Di/6rMcsWickGp2mXOJlv4C1L600x7c X6Mkz/FwAjKNIEKgfxQKn9zJY3sbbf9sLJdvXpmOok+ZKnK6LijJspX8PDSvbgE6DOCv 92ChAvV2KDlxhskqJZIVWP5Ad8W9QZfX1nPtriac8AKoofYj5C47QcLzhsLIoje4chaX 7EjQk3B2iqgPvsIHzqehWOJAz5RBmqdGHCxdXqngF8YRIxYA5Msete+pnoa7mKwUf0rx X4evUDfGUqszzX8Ww83C2aP0wu53GpQtl3eh1523Rz3iicV2RDVfSSXZGtlwC9fvQjZJ BiJw== X-Gm-Message-State: AOAM533xFEu3XvplYaREUd8TLWRJGVD4jEbemYRVqphn7ZdvOG/o3X7H HjUBQyfyNRiEQzBFOU3yxRvdyUd5tsQwhQicYxQc5w== X-Google-Smtp-Source: ABdhPJyWAH+sDRJ270zMfxco+YyNWJFwLR4+S6xqqYj7oSaBnbkhA+KnL9o9TtC8VsgFFIuLqvJvGIdWalshA80NzoM= X-Received: by 2002:a05:622a:1709:b0:2e1:2cbd:6139 with SMTP id h9-20020a05622a170900b002e12cbd6139mr16332484qtk.578.1647872011635; Mon, 21 Mar 2022 07:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20211214162050.660953-1-glider@google.com> <20211214162050.660953-14-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Mon, 21 Mar 2022 15:12:55 +0100 Message-ID: Subject: Re: [PATCH 13/43] kmsan: add KMSAN runtime core To: Greg Kroah-Hartman Cc: Alexander Viro , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Marco Elver , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , Linux Memory Management List , Linux-Arch , LKML , Mark Rutland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A618D40031 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YMmPb6uf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of glider@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=glider@google.com X-Stat-Signature: os4wyp4gpd7nhb4bstyaj9jmuwx8zgki X-Rspamd-Server: rspam04 X-HE-Tag: 1647872012-534744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > > Just to make sure I don't misunderstand - for example for "kmsan: mm: > > call KMSAN hooks from SLUB code", would it be better to pull the code > > in mm/kmsan/core.c implementing kmsan_slab_alloc() and > > kmsan_slab_free() into that patch? > > Yes. > > > I thought maintainers would prefer to have patches to their code > > separated from KMSAN code, but if it's not true, I can surely fix > > that. > > As a maintainer, I want to know what the function call that you just > added to my subsystem to call does. Wouldn't you? Put it all in the > same patch. Ok, will be done in v2, thanks! > Think about submitting a patch series as telling a story. You need to > show the progression forward of the feature so that everyone can > understand what is going on. To just throw tiny snippets at us is > impossible to follow along with what your goal is. > > You want reviewers to be able to easily see if the things you describe > being done in the changelog actually are implemented in the diff. > Dividing stuff up by files does not show that at all. > > thanks, > > greg k-h --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6schen Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie = mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.