From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE9CC10F00 for ; Sat, 7 Mar 2020 13:38:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B27D206D5 for ; Sat, 7 Mar 2020 13:38:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BToZ6IZu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B27D206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACB966B0003; Sat, 7 Mar 2020 08:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B3E6B0006; Sat, 7 Mar 2020 08:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 942526B0007; Sat, 7 Mar 2020 08:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 7DC646B0003 for ; Sat, 7 Mar 2020 08:38:07 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6EE6A8248D51 for ; Sat, 7 Mar 2020 13:38:07 +0000 (UTC) X-FDA: 76568669814.26.toes46_29c5af43fc70c X-HE-Tag: toes46_29c5af43fc70c X-Filterd-Recvd-Size: 6280 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Sat, 7 Mar 2020 13:38:06 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id 6so5366609wmi.5 for ; Sat, 07 Mar 2020 05:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ote3uPO/sOWGHscrz8dkWOtgqGPI8pZUbQaRfpl7CZc=; b=BToZ6IZu11GfK+fkHfmMDK+O3N5AR9dOMAgL9bYThcqTTF6sPb4Uur/E0CywKihWZ5 DX6liiQw0P6rYPbdK/He/uU0Ss3yNSMD8UcQ3unKtIn4mjo+Dww7reV6jV1PG7sDGBkf 9jeglptAGQgXTmON6Ff0O/ryx9Qbo8yX0Hy4ZJcNipmfQDJzsD4LGa9bd8Znmi/pb3Rn R8Pjq/gPD7HYbDD1/v9zI0AAoKN3ZYWG9dMSsRI8EOnOhmhIDAxq+wKU1eAi0hXJmKXg StMA4OU5HpPVWnlCVhdVak1aLR+WmnsBxQ/QeI3A4V/c1vWXlzAGcPukACDgNc7J8vvp X0WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ote3uPO/sOWGHscrz8dkWOtgqGPI8pZUbQaRfpl7CZc=; b=WlSWX+KDPBYoUtNXU+h9rx53fth3Kfg4rk7jB+FH9laT6esV2eD6yAdgK5KG/8Q67r aQ8EfY6dJyVw6IuvMeB/d/g6yOiJR018xHsC9uP6FCnWOouJcaFy05cPmPhE+F70UBtw kSMjCKE1B6rFRRFu/VX3VIqQspdUUtNMktseEl13AVvH2nvZQx8AtNaxjJDqFsjFIg4c YtTOvRN7LpKcJmGpTlxGX5j1pQ/MMASRLNVDmI1e3RUnaECo5ZIuaktgCaECSRNZD157 b46Q/oOC4b1QY4xhosNQW9KcwKDOcUWpON8gZjHx3MqiII+KLQWawV0T+MFsqnbuq/tV CyrA== X-Gm-Message-State: ANhLgQ2ebptO2yvY0wiKP/MJGc5VhSCDeSwyciqLU3da1f/Tq3AyrFs3 EDXV/vE8clZqATi3ny8I7yZPXm+JHFoPBOkgpgeexQ== X-Google-Smtp-Source: ADFU+vs3Ph7sMVjBNZPknQ9+Q1dqfiuIVw4k5T54nzZchxbXLl+l385bANvtyc+l4PGa1JppajXsuxApe/rvZV0XnOM= X-Received: by 2002:a1c:7907:: with SMTP id l7mr9579373wme.37.1583588285111; Sat, 07 Mar 2020 05:38:05 -0800 (PST) MIME-Version: 1.0 References: <20200220141916.55455-3-glider@google.com> <202002260412.ybvj1aPM%lkp@intel.com> In-Reply-To: From: Alexander Potapenko Date: Sat, 7 Mar 2020 14:37:53 +0100 Message-ID: Subject: Re: [PATCH 3/3] kasan: stackdepot: move filter_irq_stacks() to stackdepot.c To: Greentime Hu Cc: Nick Hu , Vincent Chen , Andrey Ryabinin , Andrew Morton , Arnd Bergmann , Linux Memory Management List , kbuild-all@lists.01.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 27, 2020 at 4:16 AM Greentime Hu wrote: > > Alexander Potapenko =E6=96=BC 2020=E5=B9=B42=E6=9C=88= 26=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:53=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > Hi Andes maintainers, > > > > On Tue, Feb 25, 2020 at 9:26 PM kbuild test robot wrote= : > > > > > > Hi, > > > > > > I love your patch! Yet something to improve: > > > > > > [auto build test ERROR on linus/master] > > > [also build test ERROR on v5.6-rc3 next-20200225] > > > [if your patch is applied to the wrong git tree, please drop us a not= e to help > > > improve the system. BTW, we also suggest to use '--base' option to sp= ecify the > > > base tree in git format-patch, please see https://stackoverflow.com/a= /37406982] > > > > > > url: https://github.com/0day-ci/linux/commits/glider-google-com/st= ackdepot-check-depot_index-before-accessing-the-stack-slab/20200222-065605 > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linu= x.git 0c0ddd6ae47c9238c18f475bcca675ca74c9dc31 > > > config: nds32-randconfig-a001-20200225 (attached as .config) > > > compiler: nds32le-linux-gcc (GCC) 9.2.0 > > > reproduce: > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # save the attached .config to linux build tree > > > GCC_VERSION=3D9.2.0 make.cross ARCH=3Dnds32 > > > > > > If you fix the issue, kindly add following tag > > > Reported-by: kbuild test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > nds32le-linux-ld: lib/stackdepot.o: in function `filter_irq_stacks= ': > > > >> stackdepot.c:(.text+0xc6): undefined reference to `__softirqentry_= text_start' > > > >> nds32le-linux-ld: stackdepot.c:(.text+0xca): undefined reference t= o `__softirqentry_text_start' > > > >> nds32le-linux-ld: stackdepot.c:(.text+0xce): undefined reference t= o `__softirqentry_text_end' > > > nds32le-linux-ld: stackdepot.c:(.text+0xd2): undefined reference t= o `__softirqentry_text_end' > > > > Can you please help me with this? > > I couldn't find out where this section needs to be declared, and I > > don't really know whether nds32 is supposed to have softirqs or not. > > Maybe filter_irq_stacks() should be no-op on nds32? > > Hi Alexander, > > I've disccussed this with Nick. > There might be 2 solutions, but we are not sure which one is better or > maybe there are another better solutions. > Since nds32 doesn't support KASAN, we might not need to use this section. > > Solution 1. > We may just add the dependency in STACKDEPOT depend on KASAN > > Solution 2. > Just add SOFTIRQENTRY_TEXT this section to nds32's linker script > > What do you think? :) Hi, I think the latter solution actually makes sense. --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg