From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AFCC77B7C for ; Fri, 28 Apr 2023 13:49:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2C7A6B0071; Fri, 28 Apr 2023 09:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADBFB6B0072; Fri, 28 Apr 2023 09:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A47E6B0074; Fri, 28 Apr 2023 09:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DA2E6B0071 for ; Fri, 28 Apr 2023 09:49:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26CAF1601E0 for ; Fri, 28 Apr 2023 13:49:11 +0000 (UTC) X-FDA: 80730931302.22.BABAC36 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 523B820003 for ; Fri, 28 Apr 2023 13:49:09 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=f3+M7QDL; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682689749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K1hIAJ3PDs1STD5Nf5EOLfCuqukCGdV5NWCw8Nh61NE=; b=fu7mnoBVQ/qTjxhyIc7mfAc7pzCe2nK8Oq61cV6DE6r8YE4+ukmUqyu5uvnGAx1SlLp0dp zUCGFm3EFyHJCgW4ExRRPhr0nKsqM0UFGR1FjTiNbA7/5WGsZWaRmxZs//qzo088y0+NrX fgf2ZeoIsUmqoIDU+MjX3jwv9VKAhSE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682689749; a=rsa-sha256; cv=none; b=QQV8HshZ0mg7drbCmMizhgopHpLs3Iqjppw0AUIcRG5r1CkGZwpd0Ch5WozWjiFSuDLvTU GReUaoZbUG8gFN9M7KXm83EN5spls8gXZizj/Q6isM3cVzy2rTrFLmBdmGabl9FO48t2r2 GCtlQKCdZ6el1WE0RBd+hjxpPu+LvxI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=f3+M7QDL; spf=pass (imf03.hostedemail.com: domain of glider@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-b8f557b241fso7944250276.0 for ; Fri, 28 Apr 2023 06:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682689748; x=1685281748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=K1hIAJ3PDs1STD5Nf5EOLfCuqukCGdV5NWCw8Nh61NE=; b=f3+M7QDLI2K3jtQKfqNELdarX3fK2oxPoOnWILM3KM+kk/9ndNXsaH8G0Tq2fIon1k lscXXpxJfHhxZVJ756aRWAUl2uKFfaBBccBkxMukat/IgzIMi49CwVd9kyPf39VnX6z5 8soeywYZ6HvEirTn/Qu0bQ9bt2NCVZYCMsDGhwbzv5bdUUTng5abmcUZOgGi6XUgwW4F nvjF4onfIXm7+rK+HgvEICQocWjQaAfZVl/hN3wAil7RUq2cMDnLIUFu/45OPvPbeR+R fZ+dEFnacgszupM2mF/H4X6nBsNg4cG1pIs0PprvKCNf1WhHB50fou5fy2LP0IDO3970 MS5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682689748; x=1685281748; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K1hIAJ3PDs1STD5Nf5EOLfCuqukCGdV5NWCw8Nh61NE=; b=NLJf5I+RiKKNeac/gl8J69ahvlQz3z45NaAZaO+Fn2kDnU2RT0QfWScjqE27ZlA0av E07jrLr9jASTvX1xHg5Wf4wBMCOzf6sEhL18OyFMj29TEmAFAJN4Ro47+gtlT450pXk0 3pz8Mp+GMlhSByFuVdR0AuCtfRYccQV96OGT1zL5SRkx4ieyoiT7HRLJiWbwoYF0AveU 0bnG/2wmh5eqfFa57R2rJsut+a5VNiYUypHGU71oPzj+VgnFRP60Mqd3kPmynbbg0zWA 1yMG49QxEQf22EsTns73s5nGsi2/ppNhaa2E8ZZmJzSXDKT/12UwUhakIM6D+86jvDe1 uJqg== X-Gm-Message-State: AC+VfDwdHtPkLLNtefKZh7q+1MyqLzKUMrl0MsL2aEjE997AP7zckMrW INA0CSJJoI7f4Q9tzen3umEpBe9pK4tRSfEf9M+V9A== X-Google-Smtp-Source: ACHHUZ508x2WD1jBRaH4gJwp/r4tHTq2TpEEorzeTmIyqrBXR0wvHIDDbxq7i6hmjQN14qjhYXF9mp1hen2Dor5rac4= X-Received: by 2002:a25:2843:0:b0:b9a:38b2:8067 with SMTP id o64-20020a252843000000b00b9a38b28067mr3442325ybo.12.1682689748091; Fri, 28 Apr 2023 06:49:08 -0700 (PDT) MIME-Version: 1.0 References: <20230424112313.3408363-1-glider@google.com> <6446ad55.170a0220.c82cd.cedc@mx.google.com> In-Reply-To: <6446ad55.170a0220.c82cd.cedc@mx.google.com> From: Alexander Potapenko Date: Fri, 28 Apr 2023 15:48:28 +0200 Message-ID: Subject: Re: [PATCH] string: use __builtin_memcpy() in strlcpy/strlcat To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, elver@google.com, dvyukov@google.com, kasan-dev@googlegroups.com, andy@kernel.org, ndesaulniers@google.com, nathan@kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 523B820003 X-Rspamd-Server: rspam09 X-Stat-Signature: hk8t8pbfzi5josq86spijxpancfgy6c4 X-HE-Tag: 1682689749-804622 X-HE-Meta: U2FsdGVkX1/BVj68qhA1YD/xIQW/FQ5bi4L5drIANoBY7bBTpPLMfMmSanVTIJQoThYPncTTiOLwbcABZN+lwZqJeOb0FAbLIvtgDvQAoi0jRSJdSMhpr64+S9c4hYVipQlCw6TRWLJUmJLsXljZ1PEK4bUyiulDZ9Lf7EB3wyblpc5N4giA1LGN8KiJwtQcbVM90PRFUeEGT5JDy7l6j109mZlsWnTJDOtggK5TcYEADTK8jLfLEswBQMZ5ppVhZ1ubAaqfK4sUYVJYUdlF1XbKxj03fQIwbjQxGBj8F2R8PPw62Es5suuAmvm489Qu9InFSOvFCIL32u0PqL1ufS2D69U+V26Ot/+mF9mO9YL4hSPbysjJXqRB5e9Q6tzrcLDSiVMwRr/5v3R62b3Fi6LceRsxNmb0sPXXh50fIS/lNiCsCabPlAcgWsZhvWXxQdephObR02pq77rAWOyaVWlujv/LCt7eKcg3RsPSus9rAYZKEj3t+GbKRM/uzHLVRKNtT0HavD4NJODnNmqRk5JmIPmTuclbFgE/vcOh7jFsOcO0fpb92ek/ALbKSMJLeT1cE0OohEgv9Dhg4AXRmbHcpj0a7o99Dw8XJursFuO+qxc39PPlIcUXoooXQBNGju22+g49zftb5DjASXCx1Je5poEHjBtl8l30Y0d2OQ/Q4DfbStYOSSUYJfLN5IjN1KevT4IJXNAnrA7NO3nxvXHMjuYC6huYo302PhShJTdt9sr0RNS3qblZ5t4oGk9TjZ+qCJVDzO+zkvyYAnGvn6f4ewhUErUd3h6oEFgQh7rlP3iKly9IPEGTw2HHdeGa3RFN/V+/t6CApVk5GqAvq2FVx1oRsWfB6evoi4WXznKkiK0F04TgXs1LpStMhxmMQwvooKf6NIl42/aOhWgY1a0tw/UcqM46q2r3iQfQMe2lyffu5uleaqzf3qv9GaIKU78GtivC32Vk3b925Ra B2l3JVoZ eBj1lx/9RlEDxzHeYdb6qMInPsht4pS2kUn17elu7+xYDa88Jn5DODPYGVUaP4mUf6jcCcz7aOH4iJLg5eQe7mCwyXwQH/WHntsc6r5M7PBs+0YOF2JgXoD7FmzT/K/VuAo3StTc9s9nOBvyuPm1wkWWIctJasvjUNkdw8mrdc130PKNvZ7SDkerWp+BkxwUrWE77ZmCavN0seWcHtE/v6csSmn5IZg3fQ4/T6xkE1IuEFGIaio40du/Po2Z12M1cIj62Ek0a+YSF9Rnf8mlFygV+9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000785, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > I *think* this isn't a problem for CONFIG_FORTIFY, since these will be > replaced and checked separately -- but it still seems strange that you > need to explicitly use __builtin_memcpy. > > Does this end up changing fortify coverage? Is fortify relevant here? Note that the whole file is compiled with __NO_FORTIFY.